search for: drm_format_help

...is patch makes drm_fb_xrgb8888_to_rgb565_dstclip() accept a __iomem dst pointer and use memcpy_toio() instead of memcpy(). The helper function (drm_fb_xrgb8888_to_rgb565_line) has been changed to process a single scanline. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- include/drm/drm_format_helper.h | 2 +- drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/drm_format_helper.c | 113 ++++++++++++++-------------- 3 files changed, 60 insertions(+), 57 deletions(-) diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format_helper.h index bc2e1004e166..d1b8a9ea01b4...

...pt a __iomem dst pointer and use memcpy_toio() instead of memcpy(). With that separating out the memcpy loop into the drm_fb_memcpy_lines() helper isn't useful any more, so move the code back into the calling functins. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- include/drm/drm_format_helper.h | 3 +- drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/drm_format_helper.c | 45 +++++++++++++++-------------- 3 files changed, 27 insertions(+), 23 deletions(-) diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format_helper.h index 6f84380757ee..bc2e1004e166 1...

...is patch makes drm_fb_xrgb8888_to_rgb888_dstclip() accept a __iomem dst pointer and use memcpy_toio() instead of memcpy(). The helper function (drm_fb_xrgb8888_to_rgb888_line) has been changed to process a single scanline. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- include/drm/drm_format_helper.h | 2 +- drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/drm_format_helper.c | 57 +++++++++++++---------------- 3 files changed, 27 insertions(+), 34 deletions(-) diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format_helper.h index d1b8a9ea01b4..1594a1f967ad 1...

...just that. Switch the drm_fb_*_dstclip() functions used by cirrus to accept a __iomem pointer as destination and pass that down to convert_lines_toio(). Fix the calls in the cirrus driver to not use __io_virt() any more. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- include/drm/drm_format_helper.h | 9 ++-- drivers/gpu/drm/cirrus/cirrus.c | 6 +-- drivers/gpu/drm/drm_format_helper.c | 74 ++++++++++++++++++++++------- 3 files changed, 67 insertions(+), 22 deletions(-) diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format_helper.h index 6f84380757ee..3532b76c234...

...0FF00) << 4) | >> + ((pix & 0x000000FF) << 22); >> + return GENMASK(31, 30) /* set alpha bits */ | pix | ((pix >> 8) & 0x00300C03); >> +} > > Maybe we can move this format conversion helper and the others in the > driver to drivers/gpu/drm/drm_format_helper.c ? I think there are still a few issues with that. First is that drm_format_helper.c is in a separate module, so you can't call its functions from the main drm module, where drm_panic is. In my drm_log series, https://patchwork.freedesktop.org/series/136789/ I moved this to drm_draw.c,...

...; + ((pix & 0x0000FF00) << 4) | > + ((pix & 0x000000FF) << 22); > + return GENMASK(31, 30) /* set alpha bits */ | pix | ((pix >> 8) & 0x00300C03); > +} Maybe we can move this format conversion helper and the others in the driver to drivers/gpu/drm/drm_format_helper.c ? > + > /* > * convert_from_xrgb8888 - convert one pixel from xrgb8888 to the desired format > * @color: input color, in xrgb8888 format > @@ -242,6 +250,8 @@ static u32 convert_from_xrgb8888(u32 color, u32 format) > return convert_xrgb8888_to_xrgb2101010(color); >...

...ed a few helpers to > > convert XR24 to other formats, for display not supporting anything > > else. Because userspace. > > Have a pointer to these helpers? grepping around in drm didn't turn up > anything so far ... tinydrm_xrgb8888_to_* imo these could be put into some drm_format_helpers.c to be shared. >From a quick look the xrgb8888_to_rgb888 is missing, but for a quick hack you can just use rgb565 to get going. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

...ed a few helpers to > > convert XR24 to other formats, for display not supporting anything > > else. Because userspace. > > Have a pointer to these helpers? grepping around in drm didn't turn up > anything so far ... tinydrm_xrgb8888_to_* imo these could be put into some drm_format_helpers.c to be shared. >From a quick look the xrgb8888_to_rgb888 is missing, but for a quick hack you can just use rgb565 to get going. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch

Hi, > > tinydrm_xrgb8888_to_* > > > > imo these could be put into some drm_format_helpers.c to be shared. > > I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got > there yet. > > Gerd, if you end up using some of those functions, feel free to move > just those you need and I can do the rest later. But if you have time to > spare I would...

...rt XR24 to other formats, for display not supporting anything >>> else. Because userspace. >> >> Have a pointer to these helpers? grepping around in drm didn't turn up >> anything so far ... > > tinydrm_xrgb8888_to_* > > imo these could be put into some drm_format_helpers.c to be shared. I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got there yet. Gerd, if you end up using some of those functions, feel free to move just those you need and I can do the rest later. But if you have time to spare I wouldn't mind getting all of them mo...

Add support for ABGR2101010, used by the nouveau driver. Signed-off-by: Jocelyn Falempe <jfalempe at redhat.com> --- drivers/gpu/drm/drm_panic.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index 74412b7bf936..0a9ecc1380d2 100644 --- a/drivers/gpu/drm/drm_panic.c +++ b/drivers/gpu/drm/drm_panic.c @@ -209,6 +209,14

On Thu, Apr 4, 2019 at 7:51 AM Gerd Hoffmann <kraxel at redhat.com> wrote: > > On Thu, Apr 04, 2019 at 12:58:09PM +1000, David Airlie wrote: > > On Wed, Apr 3, 2019 at 5:23 PM Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > > > Time to kill some bad sample code people are copying from ;) > > > > > > This is a complete rewrite of the

On Thu, Apr 4, 2019 at 7:51 AM Gerd Hoffmann <kraxel at redhat.com> wrote: > > On Thu, Apr 04, 2019 at 12:58:09PM +1000, David Airlie wrote: > > On Wed, Apr 3, 2019 at 5:23 PM Gerd Hoffmann <kraxel at redhat.com> wrote: > > > > > > Time to kill some bad sample code people are copying from ;) > > > > > > This is a complete rewrite of the

....h> + +#include <drm/drm_atomic_helper.h> +#include <drm/drm_atomic_state_helper.h> +#include <drm/drm_connector.h> +#include <drm/drm_damage_helper.h> +#include <drm/drm_drv.h> +#include <drm/drm_fb_helper.h> +#include <drm/drm_file.h> +#include <drm/drm_format_helper.h> +#include <drm/drm_fourcc.h> +#include <drm/drm_gem_shmem_helper.h> +#include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_ioctl.h> +#include <drm/drm_modeset_helper_vtables.h> +#include <drm/drm_probe_helper.h> +#include <drm/drm_simple_kms_h...