On Thu, Apr 4, 2019 at 10:30 AM Gerd Hoffmann <kraxel at redhat.com> wrote:> > Hi, > > > > Speaking of wayland: Seems at least gnome-shell insists on using XR24. > > > > Yeah XR24 is pretty much mandatory. Noralf added a few helpers to > > convert XR24 to other formats, for display not supporting anything > > else. Because userspace. > > Have a pointer to these helpers? grepping around in drm didn't turn up > anything so far ...tinydrm_xrgb8888_to_* imo these could be put into some drm_format_helpers.c to be shared.>From a quick look the xrgb8888_to_rgb888 is missing, but for a quickhack you can just use rgb565 to get going. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Den 04.04.2019 10.52, skrev Daniel Vetter:> On Thu, Apr 4, 2019 at 10:30 AM Gerd Hoffmann <kraxel at redhat.com> wrote: >> >> Hi, >> >>>> Speaking of wayland: Seems at least gnome-shell insists on using XR24. >>> >>> Yeah XR24 is pretty much mandatory. Noralf added a few helpers to >>> convert XR24 to other formats, for display not supporting anything >>> else. Because userspace. >> >> Have a pointer to these helpers? grepping around in drm didn't turn up >> anything so far ... > > tinydrm_xrgb8888_to_* > > imo these could be put into some drm_format_helpers.c to be shared.I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got there yet. Gerd, if you end up using some of those functions, feel free to move just those you need and I can do the rest later. But if you have time to spare I wouldn't mind getting all of them moved ;-) Noralf.> From a quick look the xrgb8888_to_rgb888 is missing, but for a quick > hack you can just use rgb565 to get going. > -Daniel >
Hi,> > tinydrm_xrgb8888_to_* > > > > imo these could be put into some drm_format_helpers.c to be shared. > > I agree, my long term goal is to get rid of tinydrm.ko. Just haven't got > there yet. > > Gerd, if you end up using some of those functions, feel free to move > just those you need and I can do the rest later. But if you have time to > spare I wouldn't mind getting all of them moved ;-)For now I just promoted cirrus to be a tinydrm driver ;) Noticed that those helpers (including tinydrm_memcpy for the non-converting case) apply clipping on the source but not on the destination. So, for fullscreen updates that works ok, but for updating sub-rectangles it doesn't ... So I guess I have to add a dest_clip bool parameter when moving them. /me looks for a good place. drm_fb_helpers.c I think. cheers, Gerd