search for: do_readlink

...--- 666,672 ---- status = get_status(conn->fd_in, id); if (status != SSH2_FX_OK) ! error("Couldn't symlink file \"%s\" to \"%s\": %s", oldpath, newpath, fx2txt(status)); return(status); *************** *** 673,679 **** } char * ! do_readlink(struct sftp_conn *conn, char *path) { Buffer msg; u_int type, expected_id, count, id; --- 673,679 ---- } char * ! do_readlink(struct sftp_conn *conn, char *path, Attrib *attrib) { Buffer msg; u_int type, expected_id, count, id; *************** *** 712,717 **** --- 712,720 ---...

...he command has a different meaning than on Linux [1]. There exists the tool 'realpath', which seems suitable for the task, at least applied at the command line level [2]. It is used in `normalizePath`. I suggest (at least the latter) to * use realpath instead readlink within Sys.readlink (do_readlink -> do_normalizepath) * link to `normalizePath` in the Rd document, eventually mentioning the difference Many thanks, Sven [1] see https://www.freebsd.org/cgi/man.cgi?query=readlink vs http://linux.die.net/man/1/readlink [2] https://www.freebsd.org/cgi/man.cgi?query=realpath http://linux.die.n...

...nux [1]. >> >> There exists the tool 'realpath', which seems suitable for the task, at least applied at the command line level [2]. It is used in `normalizePath`. >> >> I suggest (at least the latter) to >> * use realpath instead readlink within Sys.readlink (do_readlink -> do_normalizepath) >> * link to `normalizePath` in the Rd document, eventually mentioning the difference >> >> Many thanks, >> Sven >> >> [1] see >> https://www.freebsd.org/cgi/man.cgi?query=readlink >> vs >> http://linux.die.net/man/1/re...

...tachment 2071 --> https://bugzilla.mindrot.org/attachment.cgi?id=2071 Fix for memory leak in sftp-client.c in do_hardlink(), buffer_init(&msg) may be unfreed if the server does not support hardlink condition is met. Jonathan Armani (armani@) advises moving it down. Same thing happens in do_readlink(): if it's unable to readlink(), the function returns without freeing msg. I've attached a patch. This runs on both openbsd -current & portable openssh -current. The attached patch concerns portable OpenSSH. Thanks & Regards, //Logan C-x-C-c -- Configure bugmail: https://bugzil...

...; >>> There exists the tool 'realpath', which seems suitable for the task, at least applied at the command line level [2]. It is used in `normalizePath`. >>> >>> I suggest (at least the latter) to >>> * use realpath instead readlink within Sys.readlink (do_readlink -> do_normalizepath) >>> * link to `normalizePath` in the Rd document, eventually mentioning the difference >>> >>> Many thanks, >>> Sven >>> >>> [1] see >>> https://www.freebsd.org/cgi/man.cgi?query=readlink >>> vs >&g...

https://bugzilla.samba.org/show_bug.cgi?id=7109 Summary: Need to define NO_SYMLINK_XATTR on Linux Product: rsync Version: 3.1.0 Platform: All OS/Version: Linux Status: NEW Severity: major Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: matt at mattmccutchen.net

...sg); + return status; } - diff -ur openssh-3.0.2p1/sftp-client.h openssh/sftp-client.h --- openssh-3.0.2p1/sftp-client.h Tue Jul 3 23:07:13 2001 +++ openssh/sftp-client.h Wed Feb 6 13:02:34 2002 @@ -88,16 +88,14 @@ /* Return target of symlink 'path' - caller must free result */ char *do_readlink(int, int, char *); -/* XXX: add callbacks to do_download/do_upload so we can do progress meter */ - /* * Download 'remote_path' to 'local_path'. Preserve permissions and times * if 'pflag' is set */ -int do_download(int, int, char *, char *, int); +int do_download(i...

...==================== RCS file: /cvs/src/usr.bin/ssh/sftp-client.h,v retrieving revision 1.6 diff -u -r1.6 sftp-client.h --- sftp-client.h 2001/06/26 06:33:01 1.6 +++ sftp-client.h 2002/02/02 21:47:41 @@ -88,16 +88,14 @@ /* Return target of symlink 'path' - caller must free result */ char *do_readlink(int, int, char *); -/* XXX: add callbacks to do_download/do_upload so we can do progress meter */ - /* * Download 'remote_path' to 'local_path'. Preserve permissions and times * if 'pflag' is set */ -int do_download(int, int, char *, char *, int); +int do_download(i...

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

...reply_with_error ("%s", err); free (err); diff --git a/daemon/link.c b/daemon/link.c index 4536f00..6abe3ca 100644 --- a/daemon/link.c +++ b/daemon/link.c @@ -28,6 +28,8 @@ #include "daemon.h" #include "actions.h" +GUESTFSD_EXT_CMD(str_ln, ln); + char * do_readlink (const char *path) { @@ -132,11 +134,11 @@ _link (const char *flag, int symbolic, const char *target, const char *linkname) if (flag) r = command (NULL, &err, - "ln", flag, "--", /* target could begin with '-' */ + str_ln, f...

...reply_with_error ("%s", err); free (err); diff --git a/daemon/link.c b/daemon/link.c index 4536f00..f5e3cbe 100644 --- a/daemon/link.c +++ b/daemon/link.c @@ -28,6 +28,8 @@ #include "daemon.h" #include "actions.h" +GUESTFS_EXT_CMD(str_ln, ln); + char * do_readlink (const char *path) { @@ -132,11 +134,11 @@ _link (const char *flag, int symbolic, const char *target, const char *linkname) if (flag) r = command (NULL, &err, - "ln", flag, "--", /* target could begin with '-' */ + str_ln, f...

...reply_with_error ("%s", err); return NULL; diff --git a/daemon/link.c b/daemon/link.c index 3ce54fa37..0878fd32b 100644 --- a/daemon/link.c +++ b/daemon/link.c @@ -30,8 +30,6 @@ #include "daemon.h" #include "actions.h" -GUESTFSD_EXT_CMD(str_ln, ln); - char * do_readlink (const char *path) { @@ -140,7 +138,7 @@ _symlink (const char *flag, const char *target, const char *linkname) } r = command (NULL, &err, - str_ln, flag, "--", /* target could begin with '-' */ + "ln", flag, "--", /* tar...

...return NULL; diff --git a/daemon/link.c b/daemon/link.c index 3ce54fa37..f0bd34034 100644 --- a/daemon/link.c +++ b/daemon/link.c @@ -30,7 +30,7 @@ #include "daemon.h" #include "actions.h" -GUESTFSD_EXT_CMD(str_ln, ln); +DECLARE_EXTERNAL_COMMANDS ("ln") char * do_readlink (const char *path) @@ -140,7 +140,7 @@ _symlink (const char *flag, const char *target, const char *linkname) } r = command (NULL, &err, - str_ln, flag, "--", /* target could begin with '-' */ + "ln", flag, "--", /* target...

Version 1 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00003.html This patch series reimplements a few more APIs in OCaml, including some very important core APIs like ?list_filesystems? and ?mount?. All the tests pass after this. The selection of APIs that I have moved may look a little random, but in fact they are all APIs consumed by the inspection code (and some more

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.