search for: digby

...and checking that the virtio_blk driver instance is still around in virtblk_getgeo(). Note that the virtblk_getgeo() function itself is guaranteed to remain in memory after hot unplug because the virtio_blk module refcount is still held while a block device reference exists. Originally-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b7c6701..b50cdf37a6f7 100644 --- a/drivers/block/vir...

...and checking that the virtio_blk driver instance is still around in virtblk_getgeo(). Note that the virtblk_getgeo() function itself is guaranteed to remain in memory after hot unplug because the virtio_blk module refcount is still held while a block device reference exists. Originally-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b7c6701..b50cdf37a6f7 100644 --- a/drivers/block/vir...

...rotecting vblk->vdev with a mutex and reference > > counting vblk so the vd_index_ida index can be removed in all cases. > > > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > > ("virtio: add virtio disk geometry feature") > > Reported-by: Lance Digby <ldigby at redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > --- > > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 79 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/...

...rotecting vblk->vdev with a mutex and reference > > counting vblk so the vd_index_ida index can be removed in all cases. > > > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > > ("virtio: add virtio disk geometry feature") > > Reported-by: Lance Digby <ldigby at redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > --- > > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 79 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/...

...to be lost (vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- v4: * Clarify vdev_mutex usage [Stefano and Michael] drivers/block/virtio_blk.c | 86 ++++++++++++++++++++++++++++++++++---- 1 file changed, 78 insertions(+), 8 deletions(-) diff --git a/drivers/block...

...to be lost (vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- v4: * Clarify vdev_mutex usage [Stefano and Michael] drivers/block/virtio_blk.c | 86 ++++++++++++++++++++++++++++++++++---- 1 file changed, 78 insertions(+), 8 deletions(-) diff --git a/drivers/block...

...to be lost (vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- 1 file changed, 79 insertions(+), 8 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b...

...to be lost (vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- 1 file changed, 79 insertions(+), 8 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b...

...ring virtblk_remove() and let the safely check for !vblk->vdev after virtblk_remove() returns. Switching to a reference count also solves the vd_index_ida leak where vda, vdb, vdc, etc indices were lost when the device was hot unplugged while the block device was still open. Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- If someone has a simpler solution please let me know. I looked at various approaches including reusing device_lock(&vblk->vdev.dev) but they were more complex and extending the lifetime of virtio_...

...ring virtblk_remove() and let the safely check for !vblk->vdev after virtblk_remove() returns. Switching to a reference count also solves the vd_index_ida leak where vda, vdb, vdc, etc indices were lost when the device was hot unplugged while the block device was still open. Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- If someone has a simpler solution please let me know. I looked at various approaches including reusing device_lock(&vblk->vdev.dev) but they were more complex and extending the lifetime of virtio_...

...blk driver instance is still around in virtblk_getgeo(). > > Note that the virtblk_getgeo() function itself is guaranteed to remain > in memory after hot unplug because the virtio_blk module refcount is > still held while a block device reference exists. > > Originally-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > drivers/block/virtio_blk.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 93468b7c6701..b50cdf37...

I'm struggling with time zone version when expressed as hours offset from GMT. Can anyone confirm that the behaviour below is incorrect? It seems that the GMT offsets are backwards: > format(as.POSIXct("2011-05-23 17:23:00", tz="Europe/London"),tz="America/New_York",usetz=T) [1] "2011-05-23 12:23:00 EDT" - this works. >

Can anyone please shed any light on why R DateTimeClasses give weird times for when daylight saving time information changes, and which aren't consistent with the OS? Example: Expected result: in New Zealand DST stopped (NZDT -> NZST) at 03:00 NZDT on 2010-04-04, as confirmed by the OS time zone info (OS X 10.8.2): zdump -v /etc/localtime /etc/localtime Sat Apr 3 13:59:59 2010 UTC

..., etc indices were lost when the device was hot unplugged > > while the block device was still open. > > Can you move this statement up so we list both issues (use after free > and leak) upfront, then discuss the fix? Thanks, will fix. > > > > > Reported-by: Lance Digby <ldigby at redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > --- > > If someone has a simpler solution please let me know. I looked at > > various approaches including reusing device_lock(&vblk->vdev.dev) but > > they were...

...ith a mutex and reference > > > counting vblk so the vd_index_ida index can be removed in all cases. > > > > > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > > > ("virtio: add virtio disk geometry feature") > > > Reported-by: Lance Digby <ldigby at redhat.com> > > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > > --- > > > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > > > 1 file changed, 79 insertions(+), 8 deletions(-) > > > > &...

...g vblk so the vd_index_ida index can be removed in all cases. > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > ("virtio: add virtio disk geometry feature") Should be Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature") > Reported-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > v4: > * Clarify vdev_mutex usage [Stefano and Michael] > > drivers/block/virtio_blk.c | 86 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 78 insertions(+), 8 delet...

Despite lots of investigation, I haven't found any R packages might be suitable for the following problem. I'd be very grateful for suggestions. I have three-way nested data, with a series of measures (obs) taken in quick succession (equal time spacing) from each subject on different days. The measures taken on the same day are temporally correlated, so I'd like to use an AR1

...o solves the vd_index_ida leak where > vda, vdb, vdc, etc indices were lost when the device was hot unplugged > while the block device was still open. Can you move this statement up so we list both issues (use after free and leak) upfront, then discuss the fix? > > Reported-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > If someone has a simpler solution please let me know. I looked at > various approaches including reusing device_lock(&vblk->vdev.dev) but > they were more complex and extendin...

...gt; Fix these issues by protecting vblk->vdev with a mutex and reference > counting vblk so the vd_index_ida index can be removed in all cases. > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > ("virtio: add virtio disk geometry feature") > Reported-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 79 insertions(+), 8 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/b...

...his causes virtio-blk device names to be lost (vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> Link: https://lore.kernel.org/r/20200430140442.171016-1-stefanha at redhat.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> Signed...