search for: ldigby

...ing that the virtio_blk driver instance is still around in virtblk_getgeo(). Note that the virtblk_getgeo() function itself is guaranteed to remain in memory after hot unplug because the virtio_blk module refcount is still held while a block device reference exists. Originally-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b7c6701..b50cdf37a6f7 100644 --- a/drivers/block/virtio_blk.c +...

...ing that the virtio_blk driver instance is still around in virtblk_getgeo(). Note that the virtblk_getgeo() function itself is guaranteed to remain in memory after hot unplug because the virtio_blk module refcount is still held while a block device reference exists. Originally-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b7c6701..b50cdf37a6f7 100644 --- a/drivers/block/virtio_blk.c +...

...nday, May 4, 2020 8:16 PM > > To: Linus Torvalds <torvalds at linux-foundation.org> > > Cc: kvm at vger.kernel.org; virtualization at lists.linux-foundation.org; > > netdev at vger.kernel.org; linux-kernel at vger.kernel.org; Justin He > > <Justin.He at arm.com>; ldigby at redhat.com; mst at redhat.com; n.b at live.com; > > stefanha at redhat.com > > Subject: [GIT PULL] vhost: fixes > > > > The following changes since commit > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c: > > > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700) &...

...nday, May 4, 2020 8:16 PM > > To: Linus Torvalds <torvalds at linux-foundation.org> > > Cc: kvm at vger.kernel.org; virtualization at lists.linux-foundation.org; > > netdev at vger.kernel.org; linux-kernel at vger.kernel.org; Justin He > > <Justin.He at arm.com>; ldigby at redhat.com; mst at redhat.com; n.b at live.com; > > stefanha at redhat.com > > Subject: [GIT PULL] vhost: fixes > > > > The following changes since commit > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c: > > > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700) &...

...vblk->vdev with a mutex and reference > > counting vblk so the vd_index_ida index can be removed in all cases. > > > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > > ("virtio: add virtio disk geometry feature") > > Reported-by: Lance Digby <ldigby at redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > --- > > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 79 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/block/virti...

...vblk->vdev with a mutex and reference > > counting vblk so the vd_index_ida index can be removed in all cases. > > > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > > ("virtio: add virtio disk geometry feature") > > Reported-by: Lance Digby <ldigby at redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > --- > > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > > 1 file changed, 79 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/block/virti...

...(vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- v4: * Clarify vdev_mutex usage [Stefano and Michael] drivers/block/virtio_blk.c | 86 ++++++++++++++++++++++++++++++++++---- 1 file changed, 78 insertions(+), 8 deletions(-) diff --git a/drivers/block/virtio_blk...

...(vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- v4: * Clarify vdev_mutex usage [Stefano and Michael] drivers/block/virtio_blk.c | 86 ++++++++++++++++++++++++++++++++++---- 1 file changed, 78 insertions(+), 8 deletions(-) diff --git a/drivers/block/virtio_blk...

...(vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- 1 file changed, 79 insertions(+), 8 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b7c6701..6f7...

...(vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- 1 file changed, 79 insertions(+), 8 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 93468b7c6701..6f7...

...lk_remove() and let the safely check for !vblk->vdev after virtblk_remove() returns. Switching to a reference count also solves the vd_index_ida leak where vda, vdb, vdc, etc indices were lost when the device was hot unplugged while the block device was still open. Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- If someone has a simpler solution please let me know. I looked at various approaches including reusing device_lock(&vblk->vdev.dev) but they were more complex and extending the lifetime of virtio_device afte...

...lk_remove() and let the safely check for !vblk->vdev after virtblk_remove() returns. Switching to a reference count also solves the vd_index_ida leak where vda, vdb, vdc, etc indices were lost when the device was hot unplugged while the block device was still open. Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> --- If someone has a simpler solution please let me know. I looked at various approaches including reusing device_lock(&vblk->vdev.dev) but they were more complex and extending the lifetime of virtio_device afte...

...instance is still around in virtblk_getgeo(). > > Note that the virtblk_getgeo() function itself is guaranteed to remain > in memory after hot unplug because the virtio_blk module refcount is > still held while a block device reference exists. > > Originally-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > drivers/block/virtio_blk.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 93468b7c6701..b50cdf37a6f7 100644...

...16 PM > > > To: Linus Torvalds <torvalds at linux-foundation.org> > > > Cc: kvm at vger.kernel.org; virtualization at lists.linux-foundation.org; > > > netdev at vger.kernel.org; linux-kernel at vger.kernel.org; Justin He > > > <Justin.He at arm.com>; ldigby at redhat.com; mst at redhat.com; n.b at live.com; > > > stefanha at redhat.com > > > Subject: [GIT PULL] vhost: fixes > > > > > > The following changes since commit > > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c: > > > > > > Linux 5....

...ces were lost when the device was hot unplugged > > while the block device was still open. > > Can you move this statement up so we list both issues (use after free > and leak) upfront, then discuss the fix? Thanks, will fix. > > > > > Reported-by: Lance Digby <ldigby at redhat.com> > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > --- > > If someone has a simpler solution please let me know. I looked at > > various approaches including reusing device_lock(&vblk->vdev.dev) but > > they were more comple...

...x and reference > > > counting vblk so the vd_index_ida index can be removed in all cases. > > > > > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > > > ("virtio: add virtio disk geometry feature") > > > Reported-by: Lance Digby <ldigby at redhat.com> > > > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > > > --- > > > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > > > 1 file changed, 79 insertions(+), 8 deletions(-) > > > > > > di...

...the vd_index_ida index can be removed in all cases. > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > ("virtio: add virtio disk geometry feature") Should be Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature") > Reported-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > v4: > * Clarify vdev_mutex usage [Stefano and Michael] > > drivers/block/virtio_blk.c | 86 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 78 insertions(+), 8 deletions(-) &gt...

...he vd_index_ida leak where > vda, vdb, vdc, etc indices were lost when the device was hot unplugged > while the block device was still open. Can you move this statement up so we list both issues (use after free and leak) upfront, then discuss the fix? > > Reported-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > If someone has a simpler solution please let me know. I looked at > various approaches including reusing device_lock(&vblk->vdev.dev) but > they were more complex and extending the lifet...

...ese issues by protecting vblk->vdev with a mutex and reference > counting vblk so the vd_index_ida index can be removed in all cases. > > Fixes: 48e4043d4529523cbc7fa8dd745bd8e2c45ce1d3 > ("virtio: add virtio disk geometry feature") > Reported-by: Lance Digby <ldigby at redhat.com> > Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> > --- > drivers/block/virtio_blk.c | 87 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 79 insertions(+), 8 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio...

...virtio-blk device names to be lost (vda, vdb, etc). Fix these issues by protecting vblk->vdev with a mutex and reference counting vblk so the vd_index_ida index can be removed in all cases. Fixes: 48e4043d4529 ("virtio: add virtio disk geometry feature") Reported-by: Lance Digby <ldigby at redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com> Link: https://lore.kernel.org/r/20200430140442.171016-1-stefanha at redhat.com Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> Signed-off-by: Sa...