search for: diegetic

...e channel) only. > > In other words, it says that in the file itself (regardless of what you > do in the API), you need to have the stereo channels first, followed by > the mono channels. Where the channels go in the API itself is another > question and you're free to put the non-diegetic stereo at the end for > that. > > > The mapping code > > appears to be working on files I've tested it on so far. > > Well, even if you get the mapping wrong, it's still going to work. It's > just that your non-diegetic stream will be made from two mono stream...

...2() rather than celt_sqrt(), since > celt_sqrt() > > changes behaviour for fixed-point and provides no guarantee about > > rounding. > > > > > > Thanks! I'll make that change. > > > > 2) About these two lines: > > + if (nondiegetic_channels && 2 != nondiegetic_channels) > > + return OPUS_UNIMPLEMENTED; > > > > Why not just have the condition be: > > + if (nondiegetic_channels != 2) > > > > > > We should allow either 0 or 2 nondiegetic channels. > &g...

...for mono (a single channel) only. In other words, it says that in the file itself (regardless of what you do in the API), you need to have the stereo channels first, followed by the mono channels. Where the channels go in the API itself is another question and you're free to put the non-diegetic stereo at the end for that. > The mapping code > appears to be working on files I've tested it on so far. Well, even if you get the mapping wrong, it's still going to work. It's just that your non-diegetic stream will be made from two mono streams and two of your directional cha...

...> > In other words, it says that in the file itself (regardless of what you > do in the API), you need to have the stereo channels first, followed by > the mono channels. Where the channels go in the API itself is another > question and you're free to put the non-diegetic stereo at the end > for that. > > > The mapping code > > appears to be working on files I've tested it on so far. > > Well, even if you get the mapping wrong, it's still going to work. It's > just that your non-diegetic stream will be mad...

...ords, it says that in the file itself (regardless of what > you > > do in the API), you need to have the stereo channels first, followed > by > > the mono channels. Where the channels go in the API itself is another > > question and you're free to put the non-diegetic stereo at the end > > for that. > > > > > The mapping code > > > appears to be working on files I've tested it on so far. > > > > Well, even if you get the mapping wrong, it's still going to work. > It's > > just tha...

Hi Drew, Thakns for the patch. Here's some comments for now (not done reviewing): 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() changes behaviour for fixed-point and provides no guarantee about rounding. 2) About these two lines: + if (nondiegetic_channels && 2 != nondiegetic_channels) + return OPUS_UNIMPLEMENTED; Why not just have the condition be: + if (nondiegetic_channels != 2) As a minor detail, I prefer N != 2 than 2 != N. Also, unless you think it may one day make sense to have nondiegetic_channels != 2, I thin...

Hello all, Attached is a proposed patch for Opus that allows support for encoding non-diegetic stereo audio as a coupled stream for use with channel mapping 254. It also rejects channel counts that are not (n+1)^2 + 2j, where n is 0 to 14 and j is either 0 or 1 (See IETF public draft doc attached for clarification). Please let me know any suggestions / concerns / comments. Thank you for yo...

...: > > 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() > changes behaviour for fixed-point and provides no guarantee about > rounding. > > > Thanks! I'll make that change. > > 2) About these two lines: > + if (nondiegetic_channels && 2 != nondiegetic_channels) > + return OPUS_UNIMPLEMENTED; > > Why not just have the condition be: > + if (nondiegetic_channels != 2) > > > We should allow either 0 or 2 nondiegetic channels. > > > As a minor detail...

On 28/04/17 07:54 PM, Drew Allen wrote: > sorry about that... extra lines... was it whitespace? If so, sorry about > that. No, that was worse than that. It broke all the builds. See the fix: https://git.xiph.org/?p=opus.git;a=commitdiff;h=a31e9fd24cd Jean-Marc

...s for the patch. Here's some comments for now (not done reviewing): 1) You want to use isqrt32() rather than celt_sqrt(), since celt_sqrt() changes behaviour for fixed-point and provides no guarantee about rounding. Thanks! I'll make that change. 2) About these two lines: + if (nondiegetic_channels && 2 != nondiegetic_channels) + return OPUS_UNIMPLEMENTED; Why not just have the condition be: + if (nondiegetic_channels != 2) We should allow either 0 or 2 nondiegetic channels. As a minor detail, I prefer N != 2 than 2 != N. Acknowledged. Also, unless you t...

...- * as many bits as all other ambisonics channels. - */ - const int rate_ratio_num = 4; - const int rate_ratio_den = 3; + opus_int32 per_stream_rate; + const int nb_channels = st->layout.nb_streams + st->layout.nb_coupled_streams; - /* The omnidirectional ambisonics and non-diegetic stereo channels */ - const int nb_nondirectional_channels = st->layout.nb_coupled_streams * 2 + 1; - /* The remaining ambisonics channels */ - const int nb_directional_channels = nb_channels - nb_nondirectional_channels; if (st->bitrate_bps==OPUS_AUTO) { @@ -769,46 +758,12 @@...

Hello, I am trying to encode an Opus file with Ambisonics including Head-Locked (non-diegetic) Stereo sound for a Virtual Reality 360° video. YouTube describes the spatial audio requirements here: https://support.google.com/youtube/answer/6395969 It's the last list item 5. > 5. Supported First Order Ambisonics (FOA) with Head-Locked Stereo format: > W, Y, Z, X, L, R as a 6-chan...

...nput channels would also > allow a future version to support other conventions if needed, e.g. > "--channels fuma" to convert ambisonic channels from FuMa format, or > "--channels ambix,stereo" / "--channels stereo,ambix" to convert an > input file with non-diegetic stereo either after or before the > ambisonic channels, or to force a particular surround configuration, > or force discrete unpermuted channels that would otherwise be permuted > and treated as a surround configuration. > > Such an option would also allow the existing --downmix-mono...

Friendly ping for the opus-tools patch... ---------- Forwarded message --------- From: Drew Allen <bitllama at google.com> Date: Mon, Mar 19, 2018 at 2:53 PM Subject: Re: [PATCH] Support for Ambisonics To: opus at xiph.org <opus at xiph.org> On Mon, Mar 19, 2018 at 11:52 AM Drew Allen <bitllama at google.com> wrote: > Hello all, > > Sorry for the delay (got really

...the meaning of the input channels would also allow a future version to support other conventions if needed, e.g. "--channels fuma" to convert ambisonic channels from FuMa format, or "--channels ambix,stereo" / "--channels stereo,ambix" to convert an input file with non-diegetic stereo either after or before the ambisonic channels, or to force a particular surround configuration, or force discrete unpermuted channels that would otherwise be permuted and treated as a surround configuration. Such an option would also allow the existing --downmix-mono and --downmix-stereo op...