search for: di_arg

This is the next patch series for scrub userland tools. Change log v1->v2: - commands now reachable as "btrfs scrub ..." instead of "btrfs filesystem scrub ..." - ability to scrub a single device instead of a whole file system - superfluous command line options removed - resume is now a separate command ("scrub resume") instead of "scrub start -r" -

...git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 9254b3d..f59b0bc 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1957,6 +1957,68 @@ out: return ret; } +static noinline long btrfs_ioctl_disk_info(struct btrfs_root *root, + void __user *arg) +{ + struct btrfs_ioctl_disk_info_args di_args; + u64 *user_dest; + u64 *dest = NULL; + struct btrfs_device *device; + struct list_head *devices; + int alloc_size = 0; + int ret = 0; + + if (copy_from_user(&di_args, + (struct btrfs_ioctl_disk_info_args __user *)arg, + sizeof(di_args))) + return -EFAULT; + + mutex_lock(&root-...

...efault: usage(resume ? cmd_scrub_resume_usage : @@ -1195,7 +1199,7 @@ static int scrub_start(int argc, char **argv, int resume) * is a normal mode of operation to start scrub on multiple * single devices, there is no reason to prevent this. */ - if (is_scrub_running_on_fs(&fi_args, di_args, past_scrubs)) { + if (!force && is_scrub_running_on_fs(&fi_args, di_args, past_scrubs)) { ERR(!do_quiet, "ERROR: scrub is already running.\n" "To cancel use ''btrfs scrub cancel %s''.\n" @@ -1507,7 +1511,7 @@ out: } static const...

This series adds an initial implementation for scrub. It works quite straightforward. The usermode issues an ioctl for each device in the fs. For each device, it enumerates the allocated device chunks. For each chunk, the contained extents are enumerated and the data checksums fetched. The extents are read sequentially and the checksums verified. If an error occurs (checksum or EIO), a good copy

Hi gang, I was a little surprised to see that patch go by recently which fixed an endian bug. I went to see how sparse checking looked and it was.. broken. I got it going again in my Fedora environment. Most of the patches are just cleanups, but there *were* three real bugs lurking in all that sparse warning spam. So I maintain that it''s worth our time to keep it going and fix