search for: device_add

...3.931108] Good, all 2 testcases passed! | [ 3.931816] --------------------------------- [ 3.933985] smpboot: Total of 1 processors activated (6386.95 BogoMIPS) [ 3.948744] CPU0 attaching NULL sched-domain. [ 4.062321] devtmpfs: initialized [ 4.074456] device: 'platform': device_add [ 4.092038] bus: 'platform': registered [ 4.097560] bus: 'cpu': registered [ 4.098531] device: 'cpu': device_add [ 4.199041] EVM: security.capability [ 4.284570] bus: 'workqueue': registered [ 4.285509] device: 'workqueue': device_add [ 4...

...3.931108] Good, all 2 testcases passed! | [ 3.931816] --------------------------------- [ 3.933985] smpboot: Total of 1 processors activated (6386.95 BogoMIPS) [ 3.948744] CPU0 attaching NULL sched-domain. [ 4.062321] devtmpfs: initialized [ 4.074456] device: 'platform': device_add [ 4.092038] bus: 'platform': registered [ 4.097560] bus: 'cpu': registered [ 4.098531] device: 'cpu': device_add [ 4.199041] EVM: security.capability [ 4.284570] bus: 'workqueue': registered [ 4.285509] device: 'workqueue': device_add [ 4...

On Wed, 20 Dec 2017 12:26:25 +0800 weiping zhang <zwp10758 at gmail.com> wrote: [you used a different mail address in your From: than in your s-o-b:; same for the other patches] > In order to make caller do a simple cleanup, we split device_register > into device_initialize and device_add. device_initialize always sucess, s/success/succeeds/ > the caller can always use put_device when fail to register virtio_device "so the caller can always use put_device when register_virtio_device failed," > no matter fail at ida_simple_get or at device_add. "no matter wh...

On Wed, 20 Dec 2017 12:26:25 +0800 weiping zhang <zwp10758 at gmail.com> wrote: [you used a different mail address in your From: than in your s-o-b:; same for the other patches] > In order to make caller do a simple cleanup, we split device_register > into device_initialize and device_add. device_initialize always sucess, s/success/succeeds/ > the caller can always use put_device when fail to register virtio_device "so the caller can always use put_device when register_virtio_device failed," > no matter fail at ida_simple_get or at device_add. "no matter wh...

In order to make caller do a simple cleanup, we split device_register into device_initialize and device_add. device_initialize always sucess, the caller can always use put_device when fail to register virtio_device no matter fail at ida_simple_get or at device_add. Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> Suggested-by: Cornelia Huck <cohuck at redhat.com> --- drivers/v...

...6:25 +0800 > weiping zhang <zwp10758 at gmail.com> wrote: > > [you used a different mail address in your From: than in your s-o-b:; > same for the other patches] > >> In order to make caller do a simple cleanup, we split device_register >> into device_initialize and device_add. device_initialize always sucess, > > s/success/succeeds/ > >> the caller can always use put_device when fail to register virtio_device > > "so the caller can always use put_device when register_virtio_device > failed," > >> no matter fail at ida_simple_ge...

In order to make caller do a simple cleanup, we split device_register into device_initialize and device_add. device_initialize always succeeds, so the caller can always use put_device when register_virtio_device faild. Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> Suggested-by: Cornelia Huck <cohuck at redhat.com> --- drivers/virtio/virtio.c | 18 +++++++++++++++--- 1 file...

...ices after the corresponding virtio device has been unregistered. However, virtio does not hold an extra reference, giving up its last reference with device_unregister(), making accessing dev->index afterwards invalid. I actually saw problems when testing my (not-yet-merged) virtio-ccw code: - device_add virtio-net,id=xxx -> creates device virtio<n> with n>0 - device_del xxx -> deletes virtio<n>, but calls ida_simple_remove with an index of 0 - device_add virtio-net,id=xxx -> tries to add virtio0, which is still in use... So let's save the index we want to release...

...ices after the corresponding virtio device has been unregistered. However, virtio does not hold an extra reference, giving up its last reference with device_unregister(), making accessing dev->index afterwards invalid. I actually saw problems when testing my (not-yet-merged) virtio-ccw code: - device_add virtio-net,id=xxx -> creates device virtio<n> with n>0 - device_del xxx -> deletes virtio<n>, but calls ida_simple_remove with an index of 0 - device_add virtio-net,id=xxx -> tries to add virtio0, which is still in use... So let's save the index we want to release...

Hi, The main change is split device_register into 2 sperate calls: device_initalize() and device_add, and then the caller can use put_device safety when fail to register_virtio_device. v3->v4: * split device_register into device_initialize and devicea_add that the caller can always use put_device when fail to register virtio device. v2->v3: * virtio: add new helper do get device...

Hi, The main change is split device_register into 2 sperate calls: device_initalize() and device_add, and then the caller can use put_device safety when fail to register_virtio_device. v3->v4: * split device_register into device_initialize and devicea_add that the caller can always use put_device when fail to register virtio device. v2->v3: * virtio: add new helper do get device...

...ing, causing a leak > - vop does a free on the embedding structure, which is a big no-no > > Thoughts? Sorry to relay late and thanks for your review. Do you mean the "extra reference to the struct device" caused by the following code? err = device_register(&dev->dev); device_add(dev) get_device(dev) If I'm understand right, I think there is no extra reference if we fail virtio_register_device, because if device_register we don't get a reference. -- Thanks weiping

...ing, causing a leak > - vop does a free on the embedding structure, which is a big no-no > > Thoughts? Sorry to relay late and thanks for your review. Do you mean the "extra reference to the struct device" caused by the following code? err = device_register(&dev->dev); device_add(dev) get_device(dev) If I'm understand right, I think there is no extra reference if we fail virtio_register_device, because if device_register we don't get a reference. -- Thanks weiping

When we hot unplug a virtserialport and then try to hot plug again, it fails: (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ chardev=serial0,id=serial0,name=serial0 (qemu) device_del serial0 (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ chardev=serial0,id=serial0,name=serial0 kernel error: virtio-ports vport2p2: Error allocati...

When we hot unplug a virtserialport and then try to hot plug again, it fails: (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ chardev=serial0,id=serial0,name=serial0 (qemu) device_del serial0 (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ chardev=serial0,id=serial0,name=serial0 kernel error: virtio-ports vport2p2: Error allocati...

...x00' function='0x0'/> </source> </hostdev> When I execute virsh attach-device testvm hga.xml I get the following error: Fehler: Fehler beim Anhängen des Geräts von hga.xml (error: error while attaching device from hga.xml) Fehler: Interner Fehler: Kann Qemu-Befehl 'device_add' nicht ausführen: Device initialization failed. (error: internal error: cannot execute 'device_add': In the syslog of the host I get the following errors: Oct 7 11:32:34 artemis2 journal: Interner Fehler: Kann Qemu-Befehl 'device_add' nicht ausführen: Device initialization fai...

...rce Model MAC ------------------------------------------------------- 3rd,attach interface again,at this step ,i got erros like below: virsh # attach-interface ubuntum-124 bridge br0 --persistent error: Failed to attach interface error: internal error unable to execute QEMU command 'device_add': Duplicate ID 'net0' for device virsh # attach-interface ubuntum-124 bridge br0 error: Failed to attach interface error: internal error unable to execute QEMU command 'device_add': Duplicate ID 'net0' for device virsh # version Compiled against library: libvir 0.9.10...

...4:56, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 06:47:18PM +0200, Laurent Vivier wrote: >> When we hot unplug a virtserialport and then try to hot plug again, >> it fails: >> >> (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait >> (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >> chardev=serial0,id=serial0,name=serial0 >> (qemu) device_del serial0 >> (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >> chardev=serial0,id=serial0,name=serial0 >> kernel e...

...4:56, Michael S. Tsirkin wrote: > On Fri, Oct 18, 2019 at 06:47:18PM +0200, Laurent Vivier wrote: >> When we hot unplug a virtserialport and then try to hot plug again, >> it fails: >> >> (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait >> (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >> chardev=serial0,id=serial0,name=serial0 >> (qemu) device_del serial0 >> (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ >> chardev=serial0,id=serial0,name=serial0 >> kernel e...

...Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 04:00:56PM +0100, Laurent Vivier wrote: > > When we hot unplug a virtserialport and then try to hot plug again, > > it fails: > > > > (qemu) chardev-add socket,id=serial0,path=/tmp/serial0,server,nowait > > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ > > chardev=serial0,id=serial0,name=serial0 > > (qemu) device_del serial0 > > (qemu) device_add virtserialport,bus=virtio-serial0.0,nr=2,\ > > chardev=serial0,id=serial0,name=serial0 > > ker...