weiping zhang
2017-Dec-21 12:39 UTC
[PATCH v5 1/4] virtio: split device_register into device_initialize and device_add
In order to make caller do a simple cleanup, we split device_register into device_initialize and device_add. device_initialize always succeeds, so the caller can always use put_device when register_virtio_device faild. Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> Suggested-by: Cornelia Huck <cohuck at redhat.com> --- drivers/virtio/virtio.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index bf7ff39..59e36ef 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -303,11 +303,21 @@ void unregister_virtio_driver(struct virtio_driver *driver) } EXPORT_SYMBOL_GPL(unregister_virtio_driver); +/** + * register_virtio_device - register virtio device + * @dev : virtio device to be registered + * + * On error, the caller must call put_device on &@dev->dev (and not kfree), + * as another code path may have obtained a reference to @dev. + * + * Returns: 0 on suceess, -error on failure + */ int register_virtio_device(struct virtio_device *dev) { int err; dev->dev.bus = &virtio_bus; + device_initialize(&dev->dev); /* Assign a unique device index and hence name. */ err = ida_simple_get(&virtio_index_ida, 0, 0, GFP_KERNEL); @@ -330,9 +340,11 @@ int register_virtio_device(struct virtio_device *dev) INIT_LIST_HEAD(&dev->vqs); - /* device_register() causes the bus infrastructure to look for a - * matching driver. */ - err = device_register(&dev->dev); + /* + * device_add() causes the bus infrastructure to look for a matching + * driver. + */ + err = device_add(&dev->dev); if (err) ida_simple_remove(&virtio_index_ida, dev->index); out: -- 2.9.4
Cornelia Huck
2017-Dec-22 13:39 UTC
[PATCH v5 1/4] virtio: split device_register into device_initialize and device_add
On Thu, 21 Dec 2017 20:39:50 +0800 weiping zhang <zhangweiping at didichuxing.com> wrote:> In order to make caller do a simple cleanup, we split device_register > into device_initialize and device_add. device_initialize always succeeds, > so the caller can always use put_device when register_virtio_device faild. > > Signed-off-by: weiping zhang <zhangweiping at didichuxing.com> > Suggested-by: Cornelia Huck <cohuck at redhat.com> > --- > drivers/virtio/virtio.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-)Reviewed-by: Cornelia Huck <cohuck at redhat.com>
Reasonably Related Threads
- [PATCH v4 1/4] virtio: split device_register into device_initialize and device_add
- [PATCH v4 1/4] virtio: split device_register into device_initialize and device_add
- [PATCH v4 1/4] virtio: split device_register into device_initialize and device_add
- [PATCH v4 0/4] use put_device to cleanup resource
- [PATCH v4 0/4] use put_device to cleanup resource