search for: deflateq

...\end_layout \end_deeper @@ -6401,9 +6417,23 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If the VIRTIO_BALLOON_F_ +\change_deleted 1531152142 1346917234 +MUST_TELL_HOST +\change_inserted 1531152142 1346917237 +SILENT_DEFLATE +\change_unchanged + feature is +\change_inserted 1531152142 1346917241 +not +\change_unchanged +set, the guest may not use these...

...\end_layout \end_deeper @@ -6401,9 +6417,23 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If the VIRTIO_BALLOON_F_ +\change_deleted 1531152142 1346917234 +MUST_TELL_HOST +\change_inserted 1531152142 1346917237 +SILENT_DEFLATE +\change_unchanged + feature is +\change_inserted 1531152142 1346917241 +not +\change_unchanged +set, the guest may not use these...

...\end_layout \end_deeper @@ -6840,9 +6845,14 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is +\change_inserted 1986246365 1347188540 +negotiated +\change_deleted 1986246365 1347188542 +set +\change_unchanged +, the guest may not use these requested pages until that descriptor in the + deflateq has been used...

...\end_layout \end_deeper @@ -6840,9 +6845,14 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is +\change_inserted 1986246365 1347188540 +negotiated +\change_deleted 1986246365 1347188542 +set +\change_unchanged +, the guest may not use these requested pages until that descriptor in the + deflateq has been used...

...t; @@ -7382,9 +7417,15 @@ The driver constructs an array of addresses of memory pages it has previously > \end_layout > > \begin_layout Enumerate > -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not > - use these requested pages until that descriptor in the deflateq has been > - used by the device. > +If the VIRTIO_BALLOON_F_ > +\change_deleted 1531152142 1369761770 > +MUST > +\change_inserted 1531152142 1369761770 > +CAN > +\change_unchanged > +_TELL_HOST feature is set, the guest may not use these requested pages until > + that des...

...gt; + struct virtqueue *vqs[VIRTIO_BALLOON_VQ_MAX]; > + vq_callback_t *callbacks[VIRTIO_BALLOON_VQ_MAX]; > + const char *names[VIRTIO_BALLOON_VQ_MAX]; > + int err; > > /* > - * We expect two virtqueues: inflate and deflate, and > - * optionally stat. > + * Inflateq and deflateq are used unconditionally. The names[] > + * will be NULL if the related feature is not enabled, which will > + * cause no allocation for the corresponding virtqueue in find_vqs. > */ This might be true for virtio-pci, but it is not for virtio-ccw. > - nvqs = virtio_has_feature(vb...

...gt; + struct virtqueue *vqs[VIRTIO_BALLOON_VQ_MAX]; > + vq_callback_t *callbacks[VIRTIO_BALLOON_VQ_MAX]; > + const char *names[VIRTIO_BALLOON_VQ_MAX]; > + int err; > > /* > - * We expect two virtqueues: inflate and deflate, and > - * optionally stat. > + * Inflateq and deflateq are used unconditionally. The names[] > + * will be NULL if the related feature is not enabled, which will > + * cause no allocation for the corresponding virtqueue in find_vqs. > */ This might be true for virtio-pci, but it is not for virtio-ccw. > - nvqs = virtio_has_feature(vb...

...\begin_layout Description @@ -7382,9 +7417,15 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If the VIRTIO_BALLOON_F_ +\change_deleted 1531152142 1369761770 +MUST +\change_inserted 1531152142 1369761770 +CAN +\change_unchanged +_TELL_HOST feature is set, the guest may not use these requested pages until + that descriptor in the deflateq has been used by the...

...15 @@ The driver constructs an array of addresses of memory pages it has previously >> \end_layout >> >> \begin_layout Enumerate >> -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not >> - use these requested pages until that descriptor in the deflateq has been >> - used by the device. >> +If the VIRTIO_BALLOON_F_ >> +\change_deleted 1531152142 1369761770 >> +MUST >> +\change_inserted 1531152142 1369761770 >> +CAN >> +\change_unchanged >> +_TELL_HOST feature is set, the guest may not use these reque...

Here is the series, split in two patches, with small edits and new commit messages. Paolo Bonzini (2): virtio-balloon spec: rewrite description of VIRTIO_BALLOON_F_MUST_TELL_HOST virtio-balloon spec: reintroduce "silent deflation" feature virtio-spec.lyx | 238 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 233 insertions(+), 5 deletions(-) --

...7 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -465,6 +465,7 @@ static int init_vqs(struct virtio_balloon *vb) vq_callback_t *callbacks[VIRTIO_BALLOON_VQ_MAX]; const char *names[VIRTIO_BALLOON_VQ_MAX]; int err; + unsigned nvqs; /* * Inflateq and deflateq are used unconditionally. The names[] @@ -475,20 +476,24 @@ static int init_vqs(struct virtio_balloon *vb) names[VIRTIO_BALLOON_VQ_INFLATE] = "inflate"; callbacks[VIRTIO_BALLOON_VQ_DEFLATE] = balloon_ack; names[VIRTIO_BALLOON_VQ_DEFLATE] = "deflate"; + nvqs = VIRTIO_BALLOO...

...7 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -465,6 +465,7 @@ static int init_vqs(struct virtio_balloon *vb) vq_callback_t *callbacks[VIRTIO_BALLOON_VQ_MAX]; const char *names[VIRTIO_BALLOON_VQ_MAX]; int err; + unsigned nvqs; /* * Inflateq and deflateq are used unconditionally. The names[] @@ -475,20 +476,24 @@ static int init_vqs(struct virtio_balloon *vb) names[VIRTIO_BALLOON_VQ_INFLATE] = "inflate"; callbacks[VIRTIO_BALLOON_VQ_DEFLATE] = balloon_ack; names[VIRTIO_BALLOON_VQ_DEFLATE] = "deflate"; + nvqs = VIRTIO_BALLOO...

...has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is -\change_inserted 1986246365 1347188540 -negotiated -\change_deleted 1986246365 1347188542 -set -\change_unchanged -, the guest may not use these requested pages until that descriptor in the - deflateq has been used by the device. +If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is negotiatedset, the guest + may not use these requested pages until that descriptor in the deflateq + has been used by the device. \end_layout \begin_layout Enumerate

...has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is -\change_inserted 1986246365 1347188540 -negotiated -\change_deleted 1986246365 1347188542 -set -\change_unchanged -, the guest may not use these requested pages until that descriptor in the - deflateq has been used by the device. +If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is negotiatedset, the guest + may not use these requested pages until that descriptor in the deflateq + has been used by the device. \end_layout \begin_layout Enumerate

...t;inflate", "deflate", "stats" }; >> - int err, nvqs; >> + struct virtqueue **vqs; >> + vq_callback_t **callbacks; >> + const char **names; >> + struct scatterlist sg; >> + int i, nvqs, err = -ENOMEM; >> + >> + /* Inflateq and deflateq are used unconditionally */ >> + nvqs = 2; >> + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) >> + nvqs++; >> + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_VQ)) >> + nvqs++; >> + >> + /* Allocate space for find_vqs par...

...st char * const names[] = { "inflate", "deflate", "stats" }; > - int err, nvqs; > + struct virtqueue **vqs; > + vq_callback_t **callbacks; > + const char **names; > + struct scatterlist sg; > + int i, nvqs, err = -ENOMEM; > + > + /* Inflateq and deflateq are used unconditionally */ > + nvqs = 2; > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) > + nvqs++; > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_VQ)) > + nvqs++; > + > + /* Allocate space for find_vqs parameters */ > + vqs = kcal...

...st char * const names[] = { "inflate", "deflate", "stats" }; > - int err, nvqs; > + struct virtqueue **vqs; > + vq_callback_t **callbacks; > + const char **names; > + struct scatterlist sg; > + int i, nvqs, err = -ENOMEM; > + > + /* Inflateq and deflateq are used unconditionally */ > + nvqs = 2; > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_STATS_VQ)) > + nvqs++; > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_VQ)) > + nvqs++; > + > + /* Allocate space for find_vqs parameters */ > + vqs = kcal...

...\end_layout \end_deeper @@ -7342,9 +7394,27 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If +\change_inserted 1531152142 1347025663 +the VIRTIO_BALLOON_F_\SpecialChar \- +GUEST_\SpecialChar \- +TELLS_\SpecialChar \- +HOST feature is set, and +\change_unchanged +the VIRTIO_BALLOON_F_ +\change_deleted 1531152142 1347021706 +MUST_TELL_HOST +\change_insert...

...\end_layout \end_deeper @@ -7342,9 +7394,27 @@ The driver constructs an array of addresses of memory pages it has previously \end_layout \begin_layout Enumerate -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not - use these requested pages until that descriptor in the deflateq has been - used by the device. +If +\change_inserted 1531152142 1347025663 +the VIRTIO_BALLOON_F_\SpecialChar \- +GUEST_\SpecialChar \- +TELLS_\SpecialChar \- +HOST feature is set, and +\change_unchanged +the VIRTIO_BALLOON_F_ +\change_deleted 1531152142 1347021706 +MUST_TELL_HOST +\change_insert...

...ts an array of addresses of memory pages it has previously > >> \end_layout > >> > >> \begin_layout Enumerate > >> -If the VIRTIO_BALLOON_F_MUST_TELL_HOST feature is set, the guest may not > >> - use these requested pages until that descriptor in the deflateq has been > >> - used by the device. > >> +If the VIRTIO_BALLOON_F_ > >> +\change_deleted 1531152142 1369761770 > >> +MUST > >> +\change_inserted 1531152142 1369761770 > >> +CAN > >> +\change_unchanged > >> +_TELL_HOST feature i...