search for: def_speed

...> --- a/drm/nouveau/include/nvkm/subdev/pci.h > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > @@ -26,8 +26,9 @@ struct nvkm_pci { > } agp; > > struct { > - enum nvkm_pcie_speed speed; > - u8 width; > + enum nvkm_pcie_speed cur_speed; > + enum nvkm_pcie_speed def_speed; > + u8 cur_width; > } pcie; > > bool msi; > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > index ee2431a7..d9fb5a83 100644 > --- a/drm/nouveau/nvkm/subdev/pci/base.c > +++ b/drm/nouveau/nvkm/subdev/pci/base.c > @@ -90,6 +90,...

.../nvkm/subdev/pci.h index 1fdf3098..b23793a2 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -26,8 +26,9 @@ struct nvkm_pci { } agp; struct { - enum nvkm_pcie_speed speed; - u8 width; + enum nvkm_pcie_speed cur_speed; + enum nvkm_pcie_speed def_speed; + u8 cur_width; } pcie; bool msi; diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c index ee2431a7..d9fb5a83 100644 --- a/drm/nouveau/nvkm/subdev/pci/base.c +++ b/drm/nouveau/nvkm/subdev/pci/base.c @@ -90,6 +90,8 @@ nvkm_pci_fini(struct nvkm_subdev *subdev...

...ev/pci.h > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > } agp; > > > > struct { > > - enum nvkm_pcie_speed speed; > > - u8 width; > > + enum nvkm_pcie_speed cur_speed; > > + enum nvkm_pcie_speed def_speed; > > + u8 cur_width; > > } pcie; > > > > bool msi; > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > > index ee2431a7..d9fb5a83 100644 > > --- a/drm/nouveau/nvkm/subdev/pci/base.c > > ++...

.../nvkm/subdev/pci.h index 1fdf3098..b23793a2 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -26,8 +26,9 @@ struct nvkm_pci { } agp; struct { - enum nvkm_pcie_speed speed; - u8 width; + enum nvkm_pcie_speed cur_speed; + enum nvkm_pcie_speed def_speed; + u8 cur_width; } pcie; bool msi; diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c index ee2431a7..b6ebee6f 100644 --- a/drm/nouveau/nvkm/subdev/pci/base.c +++ b/drm/nouveau/nvkm/subdev/pci/base.c @@ -100,6 +100,8 @@ nvkm_pci_preinit(struct nvkm_subdev *s...

...@ struct nvkm_pci { > > > } agp; > > > > > > struct { > > > - enum nvkm_pcie_speed speed; > > > - u8 width; > > > + enum nvkm_pcie_speed cur_speed; > > > + enum nvkm_pcie_speed def_speed; > > > + u8 cur_width; > > > } pcie; > > > > > > bool msi; > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > > > index ee2431a7..d9fb5a83 100644 > > > --- a/drm/nouveau/...

While investigating the runpm issues on my GP107 I noticed that something inside devinit makes runpm break. If Nouveau loads up to the point right before doing devinit, runpm works without any issues, if devinit is ran, not anymore. Out of curiousity I even tried to "bisect" devinit by not running it on vbios provided signed PMU image, but on the devinit parser we have inside Nouveau.

...t; > > > > > > > struct { > > > > > - enum nvkm_pcie_speed speed; > > > > > - u8 width; > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > + enum nvkm_pcie_speed def_speed; > > > > > + u8 cur_width; > > > > > } pcie; > > > > > > > > > > bool msi; > > > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > > > > > index...

Signed-off-by: Karol Herbst <kherbst at redhat.com> Reviewed-by: Lyude Paul <lyude at redhat.com> --- drm/nouveau/nvkm/subdev/pci/gk104.c | 8 ++++---- drm/nouveau/nvkm/subdev/pci/gp100.c | 10 ++++++++++ drm/nouveau/nvkm/subdev/pci/priv.h | 5 +++++ 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/pci/gk104.c

...> } agp; > > > > > > > > struct { > > > > - enum nvkm_pcie_speed speed; > > > > - u8 width; > > > > + enum nvkm_pcie_speed cur_speed; > > > > + enum nvkm_pcie_speed def_speed; > > > > + u8 cur_width; > > > > } pcie; > > > > > > > > bool msi; > > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c > > > > index ee2431a7..d9fb5a83 100644 &gt...

CCing linux-pci and Bjorn Helgaas. Maybe we could get better insights on how a reasonable fix would look like. Anyway, to me this entire issue looks like something which has to be fixed on a PCI level instead of inside a driver, so it makes sense to ask the pci folks if they have any better suggestions. Original cover letter: While investigating the runpm issues on my GP107 I noticed that

...t; > > > struct { > > > > > > - enum nvkm_pcie_speed speed; > > > > > > - u8 width; > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > + u8 cur_width; > > > > > > } pcie; > > > > > > > > > > > > bool msi; > > > > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvkm/subdev/pci/base.c >...

.../nouveau/nvkm/subdev/pci/pcie.c index 727b5d6a..00c07fd8 100644 --- a/drm/nouveau/nvkm/subdev/pci/pcie.c +++ b/drm/nouveau/nvkm/subdev/pci/pcie.c @@ -118,6 +118,14 @@ nvkm_pcie_init(struct nvkm_pci *pci) return 0; } +int +nvkm_pcie_fini(struct nvkm_pci *pci) +{ + if (!IS_ERR_VALUE(pci->pcie.def_speed)) + return nvkm_pcie_set_link(pci, pci->pcie.def_speed, 16); + return 0; +} + int nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width) { diff --git a/drm/nouveau/nvkm/subdev/pci/priv.h b/drm/nouveau/nvkm/subdev/pci/priv.h index dc3ae3cd..e7744671 100644 --- a/drm/no...

...struct { > > > > > > > - enum nvkm_pcie_speed speed; > > > > > > > - u8 width; > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > + u8 cur_width; > > > > > > > } pcie; > > > > > > > > > > > > > > bool msi; > > > > > > > diff --git a/drm/nouveau/nvkm/subdev/pci/base.c b/drm/nouveau/nvk...

...t; > > > - enum nvkm_pcie_speed speed; > > > > > > > > > - u8 width; > > > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > > > + u8 cur_width; > > > > > > > > > } pcie; > > > > > > > > > > > > > > > > > > bool msi; > > > > > > > > > diff --git a/dr...

...enum nvkm_pcie_speed speed; > > > > > > > > > > > - u8 width; > > > > > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > > > > > + u8 cur_width; > > > > > > > > > > > } pcie; > > > > > > > > > > > > > > > > > > > > > > bool msi; > > > >...

First three patches are removing ACPI workarounds which should have never landed. The last four are adding a workaround to nouveau which seem to help quite a lot with the RTD3 issues with Nouveau, so let's discuss and get wider testing of those and see if there is any fallout or laptops where the issues don't get fixed. Karol Herbst (7): Revert "ACPI / OSI: Add OEM _OSI string to

...t; > > > > > > - enum nvkm_pcie_speed speed; > > > > > > > > - u8 width; > > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > > + u8 cur_width; > > > > > > > > } pcie; > > > > > > > > > > > > > > > > bool msi; > > > > > > > > diff --git a/drm/nouveau/nvkm/subdev/pci...

...t; - enum nvkm_pcie_speed speed; > > > > > > > > > > - u8 width; > > > > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > > > > + u8 cur_width; > > > > > > > > > > } pcie; > > > > > > > > > > > > > > > > > > > > bool msi; > > > > > > > >...

...e_speed speed; > > > > > > > > > > > > - u8 width; > > > > > > > > > > > > + enum nvkm_pcie_speed cur_speed; > > > > > > > > > > > > + enum nvkm_pcie_speed def_speed; > > > > > > > > > > > > + u8 cur_width; > > > > > > > > > > > > } pcie; > > > > > > > > > > > > > > > > > > > > > > > > bool msi;...