search for: dcb314

...netfilter/iptables Version: unspecified Hardware: x86_64 OS: All Status: NEW Severity: enhancement Priority: P5 Component: ip_tables (kernel) Assignee: netfilter-buglog at lists.netfilter.org Reporter: dcb314 at hotmail.com xtables-eb.c:533:65: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op] Source code is if (optind + 1 >= argc || (argv[optind][0] == '-' && (argv[optind][1] < '0' || argv[optind][1] > '9')) ||...

...: Fix kernel oplocks when uid(file) != uid(process). * BUG 8989: Send correct responses to NT Transact Secondary when no data and no params for the Trans2 calls are set. * BUG 9034: Fix typo in set_re_uid() call when USE_SETRESUID selected in configure. o David Binderman <dcb314 at hotmail.com> * BUG 9062: rpcclient: Fix bad call to data_blob_const. o G?nther Deschner <gd at samba.org> * BUG 9026: Fix migrating printers while upgrading from 3.5.x. o David Disseldorp <ddiss at samba.org> * BUG 8719: Printing fails in function cups_job_subm...

...: Fix kernel oplocks when uid(file) != uid(process). * BUG 8989: Send correct responses to NT Transact Secondary when no data and no params for the Trans2 calls are set. * BUG 9034: Fix typo in set_re_uid() call when USE_SETRESUID selected in configure. o David Binderman <dcb314 at hotmail.com> * BUG 9062: rpcclient: Fix bad call to data_blob_const. o G?nther Deschner <gd at samba.org> * BUG 9026: Fix migrating printers while upgrading from 3.5.x. o David Disseldorp <ddiss at samba.org> * BUG 8719: Printing fails in function cups_job_subm...

A user reported a bug where we do sizeof(*ptr * count) instead of sizeof(*ptr) * count. Fix this. Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/send.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index ff40f1c..7c8964b 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -4587,8 +4587,8 @@ l...

Hello there, I just ran the sourceforge tool cppcheck over the source code of the new Linux kernel 2.6.32.4 It said 1. [./btrfs/free-space-cache.c:600]: (style) Redundant condition. It is safe to deallocate a NULL pointer The source code is                 if (info->bitmap)                         kfree(info->bitmap); I agree with cppcheck. Suggest delete the if test. 2.

...ent allinfo' show the snapshot list. o Andrew Bartlett <abartlet at samba.org> * BUG 9066: "Domain Users" incorrectly added as additional group on domain members. * BUG 9067: Use correct RID for "Domain Guests" primary group. o David Binderman <dcb314 at hotmail.com> * BUG 9065: Fix bad call to memcpy source3/registry/regfio.c. o David Disseldorp <ddiss at samba.org> * BUG 9123: Fix lprng job tracking errors. o Salvador I. Gonzalez <sgonzalez at codejunkie.net> * BUG 9088: Fix smbclient/tarmode panic when conne...

...ent allinfo' show the snapshot list. o Andrew Bartlett <abartlet at samba.org> * BUG 9066: "Domain Users" incorrectly added as additional group on domain members. * BUG 9067: Use correct RID for "Domain Guests" primary group. o David Binderman <dcb314 at hotmail.com> * BUG 9065: Fix bad call to memcpy source3/registry/regfio.c. o David Disseldorp <ddiss at samba.org> * BUG 9123: Fix lprng job tracking errors. o Salvador I. Gonzalez <sgonzalez at codejunkie.net> * BUG 9088: Fix smbclient/tarmode panic when conne...

Hello there, Offending source code is ????? if(? ( BattVoltage> 129 ) || ( BattVoltage < 144 ) ) Maybe swap || for && would be better. This problem I found by using cppcheck. It said [rhino.c:190]: (warning) Logical disjunction always evaluates to true: BattVoltage> 129 || BattVoltage < 144. Regards David Binderman

Hello there, drivers/gpu/drm/nouveau/nvkm/engine/dma/usernv04.c:124:18: warning: this statement may fall through [-Wimplicit-fallthrough=] Source code is switch (dmaobj->base.access) { case NV_MEM_ACCESS_RO: dmaobj->flags0 |= 0x00004000; break; case NV_MEM_ACCESS_WO: dmaobj->flags0 |= 0x00008000; case NV_MEM_ACCESS_RW: dmaobj->flags2

Hello there, [linux-4.13/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c:93]: (warning) Opposite inner 'if' condition leads to a dead code block. Source code is if (target != duty) { u16 bump_period = fan->bios.bump_period; u16 slow_down_period = fan->bios.slow_down_period; u64 delay; if (duty > target) delay = slow_down_period;

Hello there, linux-5.3-rc3/drivers/gpu/drm/nouveau/nouveau_svm.c:763]: (style) Array index 'i' is used before limits check. Source code is for (i = 0; buffer->fault[i] && i < buffer->entries; i++) Maybe better code: for (i = 0; (i < buffer->entries) && buffer->fault[i]; i++) Regards David Binderman

Hello there, dovecot-2.2.33/src/lib/str-find.c:86]: (warning) Calling 'sizeof' on 'sizeof' Source code is ctx = p_malloc(pool, MALLOC_ADD(sizeof(struct str_find_context), MALLOC_MULTIPLY(sizeof(ctx->goodtab[0]), key_len))); Regards David Binderman

Hello there, I just ran the static analysis checker "cppcheck" over the source code of icecast version 2.3.3 Amongst many other things, it said [log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25. Source code is ??? if (log_id < 0 && log_id>= LOG_MAXLOGS) ??????? return; Suggest replace && with ||.

Hello there, dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:130]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((ret = doveadm_print_istream(input) < 0)) Maybe better code if ((ret = doveadm_print_istream(input)) < 0) Some duplicates: [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:220]: (style) Suspicious