netfilter buglog - May 2017 - [Bug 1149] New: xtables-eb.c:533: bad test ?

https://bugzilla.netfilter.org/show_bug.cgi?id=1149

            Bug ID: 1149
           Summary: xtables-eb.c:533: bad test ?
           Product: netfilter/iptables
           Version: unspecified
          Hardware: x86_64
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ip_tables (kernel)
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: dcb314 at hotmail.com

xtables-eb.c:533:65: warning: logical 'and' of mutually exclusive tests
is
always false [-Wlogical-op]

Source code is

    if (optind + 1 >= argc || (argv[optind][0] == '-' &&
(argv[optind][1] < '0'
|| argv[optind][1] > '9')) ||
        (argv[optind + 1][0] == '-' && (argv[optind + 1][1] <
'0'  &&
argv[optind + 1][1] > '9')))

Maybe better code

    if (optind + 1 >= argc 
        || (argv[optind][0] == '-' 
            && (argv[optind][1] < '0' || argv[optind][1] >
'9'))
        || (argv[optind + 1][0] == '-' 
            && (argv[optind + 1][1] < '0'  || argv[optind +
1][1] > '9')))

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170519/f8f28afb/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1149

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pablo at netfilter.org
             Status|NEW                         |ASSIGNED

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Would you send us a patch? Are you familiar with git?

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170601/2cf2d23b/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1149

--- Comment #2 from dcb314 at hotmail.com ---
(In reply to Pablo Neira Ayuso from comment #1)
> Would you send us a patch? Are you familiar with git?
No thanks and no.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20170602/3a917f13/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1149

--- Comment #3 from dcb314 at hotmail.com ---
Still broken a year later in version iptables-1.6.2.

Bit pointless reporting bugs if they don't get fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180615/9e9f2a5b/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1149

Florian Westphal <fw at strlen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at strlen.de
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Florian Westphal <fw at strlen.de> ---
I've pushed a patch to remove this code; it was inherited from ebtables
itself
so it never worked/was never used.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180615/e0f26634/attachment.html>