Displaying 3 results from an estimated 3 matches for "cxx_supports_".
Did you mean:
c_supports_
2020 Sep 22
2
Unifying CMake variable names used in checks across subprojects
...lly unnecessary and could be easily improved by
unifying CMake variable names used in checks across subprojects to benefit
from caching.
I've looked at naming conventions used across all subprojects and I'm
proposing the following:
C_SUPPORTS_${mangled_name}_FLAG for check_c_compiler_flag
CXX_SUPPORTS_${mangled_name}_FLAG for check_cxx_compiler_flag
HAVE_${mangled_name} for check_library_exists
Note: It'd be more consistent for check_library_exists to
use HAS_${mangled_name}_LIB but that's going to cause more churn in LLVM so
that's something to consider.
This change should be mostl...
2020 Sep 22
2
Unifying CMake variable names used in checks across subprojects
...be easily improved by unifying CMake variable names used in checks across subprojects to benefit from caching.
>
> I've looked at naming conventions used across all subprojects and I'm proposing the following:
>
> C_SUPPORTS_${mangled_name}_FLAG for check_c_compiler_flag
> CXX_SUPPORTS_${mangled_name}_FLAG for check_cxx_compiler_flag
> HAVE_${mangled_name} for check_library_exists
IMO, these issues are a manifestation of the fact that we basically have (at least) 4 times the same overall logic, once for each runtime project: compiler-rt, libunwind, libcxxabi, libcxx.
At the e...
2020 Sep 25
2
Unifying CMake variable names used in checks across subprojects
...by unifying CMake variable names used in checks across subprojects to benefit from caching.
>>
>> I've looked at naming conventions used across all subprojects and I'm proposing the following:
>>
>> C_SUPPORTS_${mangled_name}_FLAG for check_c_compiler_flag
>> CXX_SUPPORTS_${mangled_name}_FLAG for check_cxx_compiler_flag
>> HAVE_${mangled_name} for check_library_exists
>
> IMO, these issues are a manifestation of the fact that we basically have (at least) 4 times the same overall logic, once for each runtime project: compiler-rt, libunwind, libcxxabi, lib...