search for: curlinfo_content_length_download

Use CURLINFO_CONTENT_LENGTH_DOWNLOAD_T for curl_easy_getinfo() (added in curl 7.55.0) to get the length of a remote file, instead of the old CURLINFO_CONTENT_LENGTH_DOWNLOAD. This way the size is already a 64-bit integer value, as opposed to a double (the old information). --- plugins/curl/curl.c | 23 +++++++++++++++++++++++ 1 file...

...is C, an implicit conversion > works just as well. Present since the initial commit, but not present in the qemu block/curl.c driver which is where most of this code was derived from, so I suspect I simply added it "because reasons". But even more to the point, why on earth does the CURLINFO_CONTENT_LENGTH_DOWNLOAD API return a double! Well it seems as if they replaced that API with: https://curl.haxx.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD_T.html which is what we really ought to use instead. This was added in Curl 7.55.0, released 2 and a half years ago, so I think we ought to use that instead. Ad...

...works just as well. > > Present since the initial commit, but not present in the qemu > block/curl.c driver which is where most of this code was derived from, > so I suspect I simply added it "because reasons". > > But even more to the point, why on earth does the > CURLINFO_CONTENT_LENGTH_DOWNLOAD API return a double! Well it seems > as if they replaced that API with: > > https://curl.haxx.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD_T.html > > which is what we really ought to use instead. This was added in Curl > 7.55.0, released 2 and a half years ago, so I think we...

...> Present since the initial commit, but not present in the qemu > > block/curl.c driver which is where most of this code was derived from, > > so I suspect I simply added it "because reasons". > > > > But even more to the point, why on earth does the > > CURLINFO_CONTENT_LENGTH_DOWNLOAD API return a double! Well it seems > > as if they replaced that API with: > > > > https://curl.haxx.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD_T.html > > > > which is what we really ought to use instead. This was added in Curl > > 7.55.0, released 2 and a...

Actual variable holding content length is int64_t, but it was assigned by explicit cast to size_t. On 32-bit systems it's a lossy conversion, so it was replaced by casting to int64_t instead. Signed-off-by: Adrian Ambro?ewicz <adrian.ambrozewicz at linux.intel.com> --- plugins/curl/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/curl/curl.c

...ETRANSFER_TIME Version has CURLINFO_SIZE_UPLOAD Version has CURLINFO_SIZE_DOWNLOAD Version has CURLINFO_SPEED_DOWNLOAD Version has CURLINFO_SPEED_UPLOAD Version has CURLINFO_HEADER_SIZE Version has CURLINFO_REQUEST_SIZE Version has CURLINFO_SSL_VERIFYRESULT Version has CURLINFO_FILETIME Version has CURLINFO_CONTENT_LENGTH_DOWNLOAD Version has CURLINFO_CONTENT_LENGTH_UPLOAD Version has CURLINFO_STARTTRANSFER_TIME Version has CURLINFO_CONTENT_TYPE Version has CURLINFO_REDIRECT_TIME Version has CURLINFO_REDIRECT_COUNT Version has CURLINFO_PRIVATE Version has CURLINFO_HTTP_CONNECTCODE Version has CURLINFO_HTTPAUTH_AVAIL Version...