Displaying 6 results from an estimated 6 matches for "curlinfo_content_length_download_t".
2020 Jan 08
1
[nbdkit PATCH] curl: use CURLINFO_CONTENT_LENGTH_DOWNLOAD_T when available
Use CURLINFO_CONTENT_LENGTH_DOWNLOAD_T for curl_easy_getinfo() (added in
curl 7.55.0) to get the length of a remote file, instead of the old
CURLINFO_CONTENT_LENGTH_DOWNLOAD. This way the size is already a 64-bit
integer value, as opposed to a double (the old information).
---
plugins/curl/curl.c | 23 +++++++++++++++++++++++
1 file ch...
2020 Jan 09
2
Re: [PATCH] Fix lossy conversion of Content-Length
...r which is where most of this code was derived from,
so I suspect I simply added it "because reasons".
But even more to the point, why on earth does the
CURLINFO_CONTENT_LENGTH_DOWNLOAD API return a double! Well it seems
as if they replaced that API with:
https://curl.haxx.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD_T.html
which is what we really ought to use instead. This was added in Curl
7.55.0, released 2 and a half years ago, so I think we ought to use
that instead. Adrian could you write a patch to change over to that
API?
Rich.
> > nbdkit_debug ("content length: %" PRIi64, h->ex...
2020 Jan 09
0
Re: [PATCH] Fix lossy conversion of Content-Length
...was derived from,
> so I suspect I simply added it "because reasons".
>
> But even more to the point, why on earth does the
> CURLINFO_CONTENT_LENGTH_DOWNLOAD API return a double! Well it seems
> as if they replaced that API with:
>
> https://curl.haxx.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD_T.html
>
> which is what we really ought to use instead. This was added in Curl
> 7.55.0, released 2 and a half years ago, so I think we ought to use
> that instead. Adrian could you write a patch to change over to that
> API?
>
> Rich.
I see that you've already ACK-ed su...
2020 Jan 09
2
Re: [PATCH] Fix lossy conversion of Content-Length
...spect I simply added it "because reasons".
> >
> > But even more to the point, why on earth does the
> > CURLINFO_CONTENT_LENGTH_DOWNLOAD API return a double! Well it seems
> > as if they replaced that API with:
> >
> > https://curl.haxx.se/libcurl/c/CURLINFO_CONTENT_LENGTH_DOWNLOAD_T.html
> >
> > which is what we really ought to use instead. This was added in Curl
> > 7.55.0, released 2 and a half years ago, so I think we ought to use
> > that instead. Adrian could you write a patch to change over to that
> > API?
> >
> > Rich.
>...
2020 Jan 07
3
[PATCH] Fix lossy conversion of Content-Length
Actual variable holding content length is int64_t, but it was assigned
by explicit cast to size_t. On 32-bit systems it's a lossy conversion,
so it was replaced by casting to int64_t instead.
Signed-off-by: Adrian Ambro?ewicz <adrian.ambrozewicz at linux.intel.com>
---
plugins/curl/curl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/curl/curl.c
2020 Feb 27
0
ANNOUNCE: nbdkit 1.18 - high performance NBD server
...ter the client makes a connection but before any NBD negotiation or
TLS authentication is done. It can be used for early whitelisting or
rate limiting of connections, and in particular is used by the new
nbdkit-ip-filter(1).
Bug fixes
In nbdkit-curl-plugin(1), "CURLINFO_CONTENT_LENGTH_DOWNLOAD_T" is used
(if available) so that file sizes up to 63 bits should now work on all
platforms (Pino Toscano and Adrian Ambrożewicz).
nbdkit is now compatible with OCaml 4.10.
nbdkit-memory-plugin(1) now supports "size=0" (Eric Blake).
Documentation...