search for: css_reboot_notifier

...f (!cpu_addr) > + return; > + memset(cpu_addr, 0, size); Hm, normally I'd do the memset during alloc not during free - but maybe this makes more sense here with your usecase in mind. > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > unregister_reboot_notifier(&css_reboot_notifier); > goto out_unregister; > } > + cio_dma_pool_init(); This is too late for early devices (ccw console!).

...f (!cpu_addr) > + return; > + memset(cpu_addr, 0, size); Hm, normally I'd do the memset during alloc not during free - but maybe this makes more sense here with your usecase in mind. > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > unregister_reboot_notifier(&css_reboot_notifier); > goto out_unregister; > } > + cio_dma_pool_init(); This is too late for early devices (ccw console!).

...2019 23:22:10 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > unregister_reboot_notifier(&css_reboot_notifier); > > > goto out_unregister; > > > } > > > + cio_dma_pool_init(); > > > > This is too late for early devices (ccw console!). > > You have already raised concern about this last time (thanks). I think, > I've addressed this issue: tje...

...2019 23:22:10 +0200 Halil Pasic <pasic at linux.ibm.com> wrote: > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > unregister_reboot_notifier(&css_reboot_notifier); > > > goto out_unregister; > > > } > > > + cio_dma_pool_init(); > > > > This is too late for early devices (ccw console!). > > You have already raised concern about this last time (thanks). I think, > I've addressed this issue: tje...

...amp;css->mutex); > css->cssid = chsc_get_cssid(nr); (...) > @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) > if (ret) > goto out_unregister; > ret = register_pm_notifier(&css_power_notifier); > - if (ret) { > - unregister_reboot_notifier(&css_reboot_notifier); > - goto out_unregister; > - } > + if (ret) > + goto out_unregister_rn; > + ret = cio_dma_pool_init(); > + if (ret) > + goto out_unregister_rn; Don't you also need to unregister the pm notifier on failure here? Other than that, I noticed only cosmetic issues; seems r...

...amp;css->mutex); > css->cssid = chsc_get_cssid(nr); (...) > @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) > if (ret) > goto out_unregister; > ret = register_pm_notifier(&css_power_notifier); > - if (ret) { > - unregister_reboot_notifier(&css_reboot_notifier); > - goto out_unregister; > - } > + if (ret) > + goto out_unregister_rn; > + ret = cio_dma_pool_init(); > + if (ret) > + goto out_unregister_rn; Don't you also need to unregister the pm notifier on failure here? Other than that, I noticed only cosmetic issues; seems r...

...m> wrote: > >> @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) > >> if (ret) > >> goto out_unregister; > >> ret = register_pm_notifier(&css_power_notifier); > >> - if (ret) { > >> - unregister_reboot_notifier(&css_reboot_notifier); > >> - goto out_unregister; > >> - } > >> + if (ret) > >> + goto out_unregister_rn; > >> + ret = cio_dma_pool_init(); > >> + if (ret) > >> + goto out_unregister_rn; > > > > Don't you also need to unregister the p...

...chsc_get_cssid(nr); > > (...) > >> @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) >> if (ret) >> goto out_unregister; >> ret = register_pm_notifier(&css_power_notifier); >> - if (ret) { >> - unregister_reboot_notifier(&css_reboot_notifier); >> - goto out_unregister; >> - } >> + if (ret) >> + goto out_unregister_rn; >> + ret = cio_dma_pool_init(); >> + if (ret) >> + goto out_unregister_rn; > > Don't you also need to unregister the pm notifier on failure here? Mmh, that was the...

...ing, we can setup our channel subsystem. * The struct subchannel's are created during probing. @@ -1059,16 +1168,19 @@ static int __init css_bus_init(void) if (ret) goto out_unregister; ret = register_pm_notifier(&css_power_notifier); - if (ret) { - unregister_reboot_notifier(&css_reboot_notifier); - goto out_unregister; - } + if (ret) + goto out_unregister_rn; + ret = cio_dma_pool_init(); + if (ret) + goto out_unregister_rn; css_init_done = 1; /* Enable default isc for I/O subchannels. */ isc_register(IO_SCH_ISC); return 0; +out_unregister_rn: + unregister_reboot_notifier(&a...

...ing, we can setup our channel subsystem. * The struct subchannel's are created during probing. @@ -1059,16 +1177,21 @@ static int __init css_bus_init(void) if (ret) goto out_unregister; ret = register_pm_notifier(&css_power_notifier); - if (ret) { - unregister_reboot_notifier(&css_reboot_notifier); - goto out_unregister; - } + if (ret) + goto out_unregister_rn; + ret = cio_dma_pool_init(); + if (ret) + goto out_unregister_pmn; css_init_done = 1; /* Enable default isc for I/O subchannels. */ isc_register(IO_SCH_ISC); return 0; +out_unregister_pmn: + unregister_pm_notifier(&amp...

...ing, we can setup our channel subsystem. * The struct subchannel's are created during probing. @@ -1059,16 +1179,21 @@ static int __init css_bus_init(void) if (ret) goto out_unregister; ret = register_pm_notifier(&css_power_notifier); - if (ret) { - unregister_reboot_notifier(&css_reboot_notifier); - goto out_unregister; - } + if (ret) + goto out_unregister_rn; + ret = cio_dma_pool_init(); + if (ret) + goto out_unregister_pmn; css_init_done = 1; /* Enable default isc for I/O subchannels. */ isc_register(IO_SCH_ISC); return 0; +out_unregister_pmn: + unregister_pm_notifier(&amp...

...te: > > > > > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > > > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > > goto out_unregister; > > > > > } > > > > > + cio_dma_pool_init(); > > > > > > > > This is too late for early devices (ccw console!). > > > > > > You have already raised concern about...

...te: > > > > > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > > > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > > goto out_unregister; > > > > > } > > > > > + cio_dma_pool_init(); > > > > > > > > This is too late for early devices (ccw console!). > > > > > > You have already raised concern about...

...s more sense here with your usecase in mind. I allocate the backing as zeroed, and zero the memory before putting it back to the pool. So the stuff in the pool is always zeroed. > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > unregister_reboot_notifier(&css_reboot_notifier); > > goto out_unregister; > > } > > + cio_dma_pool_init(); > > This is too late for early devices (ccw console!). You have already raised concern about this last time (thanks). I think, I've addressed this issue: tje cio_dma_pool is only used by the airq stuff....

...c <pasic at linux.ibm.com> wrote: > > > On Wed, 8 May 2019 15:18:10 +0200 (CEST) > > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > goto out_unregister; > > > > } > > > > + cio_dma_pool_init(); > > > > > > This is too late for early devices (ccw console!). > > > > You have already raised concern about this last time (thanks). I think, >...

...y 2019 15:18:10 +0200 (CEST) > > > > > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > > > > > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > > > > goto out_unregister; > > > > > > > } > > > > > > > + cio_dma_pool_init(); > > > > > > > > > > > > This is too late for early devices (ccw console!). > > >...

...y 2019 15:18:10 +0200 (CEST) > > > > > Sebastian Ott <sebott at linux.ibm.com> wrote: > > > > > > > > > > > @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) > > > > > > > unregister_reboot_notifier(&css_reboot_notifier); > > > > > > > goto out_unregister; > > > > > > > } > > > > > > > + cio_dma_pool_init(); > > > > > > > > > > > > This is too late for early devices (ccw console!). > > >...

...d long) cpu_addr, size); > +} > + > /* > * Now that the driver core is running, we can setup our channel subsystem. > * The struct subchannel's are created during probing. > @@ -1063,6 +1119,7 @@ static int __init css_bus_init(void) > unregister_reboot_notifier(&css_reboot_notifier); > goto out_unregister; > } > + cio_dma_pool_init(); > css_init_done = 1; > > /* Enable default isc for I/O subchannels. */

...t size) +{ + cio_gp_dma_free(cio_dma_pool, cpu_addr, size); +} + /* * Now that the driver core is running, we can setup our channel subsystem. * The struct subchannel's are created during probing. @@ -1063,6 +1172,7 @@ static int __init css_bus_init(void) unregister_reboot_notifier(&css_reboot_notifier); goto out_unregister; } + cio_dma_pool_init(); css_init_done = 1; /* Enable default isc for I/O subchannels. */ -- 2.13.4

...t size) +{ + cio_gp_dma_free(cio_dma_pool, cpu_addr, size); +} + /* * Now that the driver core is running, we can setup our channel subsystem. * The struct subchannel's are created during probing. @@ -1063,6 +1163,7 @@ static int __init css_bus_init(void) unregister_reboot_notifier(&css_reboot_notifier); goto out_unregister; } + cio_dma_pool_init(); css_init_done = 1; /* Enable default isc for I/O subchannels. */ -- 2.16.4