search for: cooper3

...ay operations based on an expression which yielded singleton pointers. The problem is actually that the externs were typed incorrectly. Correct the extern declaration to prevent straying into undefined behaviour, and relying on the lenience of GCC to work. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> CC: Keir Fraser <keir@xen.org> CC: Jan Beulich <JBeulich@suse.com> --- xen/common/kernel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index b8707d9..e785edb 100644 --- a/xen/common/kernel.c +++ b...

...memory guards, and I believe that all the stack traces look correct. However, I would greatly appreciate a second opinion on the boundary conditions. The 4th patch is included for anyone wishing to easily test the series; It is not intended for committing. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> CC: Keir Fraser <keir@xen.org> CC: Jan Beulich <JBeulich@suse.com> CC: Tim Deegan <tim@xen.org>

On 15/07/2019 19:17, Nadav Amit wrote: >> On Jul 15, 2019, at 8:16 AM, Andrew Cooper <andrew.cooper3 at citrix.com> wrote: >> >> There is a lot of infrastructure for functionality which is used >> exclusively in __{save,restore}_processor_state() on the suspend/resume >> path. >> >> cr8 is an alias of APIC_TASKPRI, and APIC_TASKPRI is saved/restored by >&g...

On 15/07/2019 19:17, Nadav Amit wrote: >> On Jul 15, 2019, at 8:16 AM, Andrew Cooper <andrew.cooper3 at citrix.com> wrote: >> >> There is a lot of infrastructure for functionality which is used >> exclusively in __{save,restore}_processor_state() on the suspend/resume >> path. >> >> cr8 is an alias of APIC_TASKPRI, and APIC_TASKPRI is saved/restored by >&g...

Hi All, I have a windows 7 as my domU and some windows based drivers are not fully functional (like: touchpad-driver etc ) because they are SMBus based. I was looking at a way to passthrough the SMBus at 00:1f.03 on south bridge ( 00:1f.0), I was debugging at pt-graphics.c and understand that it is detecting the south bridge and passing it through but the other functions for the same dev-id are

The DMI checks that force the use of the bigsmp APIC driver are for systems that are no longer supported by Xen (32-bit x86). Signed-off-by: Matt Wilson <msw@amazon.com> Cc: Keir Fraser <keir@xen.org> Cc: Jan Beulich <jbeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> --- xen/arch/x86/genapic/bigsmp.c | 30 +----------------------------- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/xen/arch/x86/genapic/bigsmp.c b/xen/arch/x86/genapic/bigsmp.c index 96b23d6..491a916 100644 --- a/xen/arch/x86/genapic/bigsmp.c +++ b/xen/arch/x86...

This patch is based on one which has been in XenServer for a very long. To keep the trend of documentation going, it also corrects the new command line document. -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

...he VMENTER happens, an immediate VMEXIT happens as a result of the queued NMI. We have seen hundreds of iterations of this VMEXIT/VMENTER loop before the HVM guest resumes normal operation. Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> -- Changes since v2 * Switch from ''int $2'' to do_nmi() * Reworked commit message to more clearly explain the problem diff -r 2489c2926698 -r d7ea938044ac xen/arch/x86/hvm/vmx/vmx.c --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2269,6 +226...

...ion targeted for testing: xen 145ae98bfab8280744ad5e800cc036e1c84c0486 baseline version: xen 5fc2176d9b3c5988c041fa5926fdd2da2ad560b9 ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper <andrew.cooper3@citrix.com> Daniel De Graaf <dgdegra@tycho.nsa.gov> Ian Campbell <ian.campbell@citrix.com> Jan Beulich <jbeulich@suse.com> Tim Deegan <tim@xen.org> ------------------------------------------------------------ jobs: build-amd64...

...seen by running dmidecode in any applicable HVM domain. The second regression found its way into the public ABI, making it harder to fix. However, I believe (and have argued) that the correct fix is to change the ABI. I would appreciate thoughts/comments. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> CC: Keir Fraser <keir@xen.org> CC: Jan Beulich <JBeulich@suse.com> CC: Ian Campbell <Ian.Campbell@citrix.com> CC: Ian Jackson <Ian.Jackson@eu.citrix.com> CC: Ross Philipson <ross.philipson@citrix.com> -- 1.7.10.4

Also, rename to MOVE_CLEANUP_VECTOR to be in line with the other IPI names. This requires bumping LAST_HIPRIORITY_VECTOR, but does mean that the range FIRST-LAST_HIPRIORITY_VECTORs are free once again. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> diff -r 0268e7380953 -r c7884dbb6f7d xen/arch/x86/apic.c --- a/xen/arch/x86/apic.c Mon Sep 05 15:10:28 2011 +0100 +++ b/xen/arch/x86/apic.c Wed Sep 07 16:00:55 2011 +0100 @@ -90,7 +90,7 @@ bool_t __read_mostly directed_eoi_enable * through the ICC by us (IPIs) */ __asm__("...

This caused particularly poor performance when booting a server in uniprocessor mode for debugging reasons, and had 4 dom0 vcpus competing for 1pcpus worth of time. -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

These two fixes are the final two outstanding issues in tools/firmware. They are both quite minor. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> -- 1.7.10.4

..., introduce a new type of vector map called per-device-global. This uses per-device vector maps in the IOMMU, but uses a single used_vector map for the core IRQ logic. This patch is intended to be removed as soon as the per-device logic is fixed correctly. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- This patch specifically does not introduce a command line argument for this mode to avoid needing to carry it forever more for compatibility reasons. Unfortunately, the per-device logic is going to be very complicated to fix. Under the current irq architecture, by the time you...

...b()s as a result of patch 1 Patch 4 removes __ia64__ defines from the x86 arch tree Patch 3 is related to patch 4 and changes the VIOAPIC to emulate version 0x20 as a performance gain. It preceeds Patch 4 so as to be more clear about the functional change. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

This issue came up when debugging pcpu linked list corruption (patches for that issue to follow). -- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> -- 1.7.10.4

Hello, A friend of mine was having weird ocasional crashes on migration, and I took a look at the problem The VM is a very stripped down ubuntu 12.04 environment (3.2.0 kernel) with a total of 96MB of RAM, but this appears to be a generic driver problem still present in upstream. The symptoms were that on about 5% of migrations, one or more block devices would fail to come back on resume. The

...ontext switch. Furthermore, 64bit Windows writes to this MSR on every thread context switch, so interception causes a substantial performance hit. From: Paul Durrant <paul.durrant@citrix.com> Signed-off-by: Paul Durrant <paul.durrant@citrix.com> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> CC: Keir Fraser <keir@xen.org> CC: Jan Beulich <JBeulich@suse.com> CC: Tim Deegan <tim@xen.org> CC: Jun Nakajima <jun.nakajima@intel.com> CC: Eddie Dong <eddie.dong@intel.com> --- xen/arch/x86/hvm/vmx/vmcs.c | 1 + 1 file changed, 1 insertion(+) dif...

To allow xenguest consumers to also make use of the extra protection added as a result of xsa-25. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> diff -r 5af4f2ab06f3 -r daec50a41570 tools/libxc/xenguest.h --- a/tools/libxc/xenguest.h +++ b/tools/libxc/xenguest.h @@ -177,6 +177,13 @@ int xc_dom_linux_build(xc_interface *xch unsigned int console_evtchn, unsigned long *console_mfn); +#ifndef XC_HAVE_DECOMP...