search for: controlq

...river case, > > the ctrl-vq can be special as well. > > > > Then maybe it's better to introduce vhost-mdev-net on top? > > Looking at the other type of virtio device: > > - console have two control virtqueues when multiqueue port is enabled > > - SCSI has controlq + eventq > > - GPU has controlq > > - Crypto device has one controlq > > - Socket has eventq > > ... Thanks for the list! It looks dirty to define specific commands and types in vhost UAPI for each of them in the future. It's definitely much better to find an approa...

On Tue, Oct 29, 2019 at 06:51:32PM +0800, Jason Wang wrote: > On 2019/10/29 ??6:17, Tiwei Bie wrote: > > This patch adds the network control vq support in vhost-mdev. > > A vhost-mdev specific op is introduced to allow parent drivers > > to handle the network control commands come from userspace. > > Probably work for userspace driver but not kernel driver. Exactly.

On Tue, Oct 29, 2019 at 06:51:32PM +0800, Jason Wang wrote: > On 2019/10/29 ??6:17, Tiwei Bie wrote: > > This patch adds the network control vq support in vhost-mdev. > > A vhost-mdev specific op is introduced to allow parent drivers > > to handle the network control commands come from userspace. > > Probably work for userspace driver but not kernel driver. Exactly.

...> I got your point now. In virtio-mdev kernel driver case, > the ctrl-vq can be special as well. > Then maybe it's better to introduce vhost-mdev-net on top? Looking at the other type of virtio device: - console have two control virtqueues when multiqueue port is enabled - SCSI has controlq + eventq - GPU has controlq - Crypto device has one controlq - Socket has eventq ... Thanks

...441 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,42 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...441 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,42 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,46 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,46 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,46 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,46 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...pu/drm/virtio/virtgpu_fence.c b/drivers/gpu/drm/virtio/virtgpu_fence.c index 23353521f903..00c742a441bf 100644 --- a/drivers/gpu/drm/virtio/virtgpu_fence.c +++ b/drivers/gpu/drm/virtio/virtgpu_fence.c @@ -36,11 +36,6 @@ static const char *virtio_get_timeline_name(struct dma_fence *f) return "controlq"; } -static bool virtio_enable_signaling(struct dma_fence *f) -{ - return true; -} - static bool virtio_signaled(struct dma_fence *f) { struct virtio_gpu_fence *fence = to_virtio_fence(f); @@ -67,9 +62,7 @@ static void virtio_timeline_value_str(struct dma_fence *f, char *str, int size)...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,46 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,46 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,42 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...41 "Cornelia Huck" cornelia.huck at de.ibm.com \author 1531152142 "Paolo Bonzini,,," +\author 1986246365 "Michael S. Tsirkin" \end_header \begin_body @@ -4170,9 +4171,42 @@ ID 1 \end_layout \begin_layout Description -Virtqueues 0:receiveq. - 1:transmitq. - 2:controlq +Virtqueues 0:receiveq +\change_inserted 1986246365 1352742829 +0 +\change_unchanged +. + 1:transmitq +\change_inserted 1986246365 1352742832 +0 +\change_deleted 1986246365 1352742947 +. + +\change_inserted 1986246365 1352742952 +. + .... + 2N +\begin_inset Foot +status open + +\begin_layout Plain...

...\begin_layout Description -Virtqueues 0:receiveq. +Virtqueues +\change_inserted 2090695081 1340693104 + +\end_layout + +\begin_deeper +\begin_layout Description + +\change_inserted 2090695081 1340693118 +When VIRTIO_NET_F_MULTIQUEUE is not set: +\change_unchanged +0:receiveq. 1:transmitq. 2:controlq \begin_inset Foot -status open +status collapsed \begin_layout Plain Layout Only if VIRTIO_NET_F_CTRL_VQ set @@ -3867,9 +3879,60 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 2090695081 1340693122 + \end_layout \begin_layout Description + +\change_inserted 209069508...

...\begin_layout Description -Virtqueues 0:receiveq. +Virtqueues +\change_inserted 2090695081 1340693104 + +\end_layout + +\begin_deeper +\begin_layout Description + +\change_inserted 2090695081 1340693118 +When VIRTIO_NET_F_MULTIQUEUE is not set: +\change_unchanged +0:receiveq. 1:transmitq. 2:controlq \begin_inset Foot -status open +status collapsed \begin_layout Plain Layout Only if VIRTIO_NET_F_CTRL_VQ set @@ -3867,9 +3879,60 @@ Only if VIRTIO_NET_F_CTRL_VQ set \end_inset +\change_inserted 2090695081 1340693122 + \end_layout \begin_layout Description + +\change_inserted 209069508...

...itive to > writes from the producer.) > > I have two quick comments on your patch -- > 1) I think you need to kfree vq->avail when deleting the virtqueue. > > 2) Should we avoid allocating a cache for virtqueues that are not > performance critical? (ex: virtio-scsi eventq/controlq, virtio-net > controlq) > > Should I post comments in reply to the original patch email (given that it > is ~2 months old)? > > Thanks! > -- vs; >

...====== > Appendix K: VM Sockets Device > > The virtio VM sockets device is a virtio transport device for VM Sockets. VM > Sockets allows communication between virtual machines and the hypervisor. > > Configuration: > > Subsystem Device ID 13 > > Virtqueues: > 0:controlq; 1:receiveq0; 2:transmitq0 ... 2N+1:receivqN; 2N+2:transmitqN controlq is "defined but not used", is there something in mind for it? if not, does it make sense keeping it here? we can always re-add it to the end just like in virtio-net. > Feature bits: > Currently, no feature...

...tests w/ polling are not as sensitive to writes from the producer.) I have two quick comments on your patch -- 1) I think you need to kfree vq->avail when deleting the virtqueue. 2) Should we avoid allocating a cache for virtqueues that are not performance critical? (ex: virtio-scsi eventq/controlq, virtio-net controlq) Should I post comments in reply to the original patch email (given that it is ~2 months old)? Thanks! -- vs;