search for: config_agp

...rm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -635,7 +635,7 @@ nouveau_bo_wr32(struct nouveau_bo *nvbo, unsigned index, u32 val) > static struct ttm_tt * > nouveau_ttm_tt_create(struct ttm_buffer_object *bo, uint32_t page_flags) > { > -#if IS_ENABLED(CONFIG_AGP) > +#if IS_ENABLED(CONFIG_DRM_TTM_AGP) > struct nouveau_drm *drm = nouveau_bdev(bo->bdev); > > if (drm->agp.bridge) { > @@ -1448,7 +1448,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) > /* System memory */ > return 0; >...

...f5c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -635,7 +635,7 @@ nouveau_bo_wr32(struct nouveau_bo *nvbo, unsigned index, u32 val) static struct ttm_tt * nouveau_ttm_tt_create(struct ttm_buffer_object *bo, uint32_t page_flags) { -#if IS_ENABLED(CONFIG_AGP) +#if IS_ENABLED(CONFIG_DRM_TTM_AGP) struct nouveau_drm *drm = nouveau_bdev(bo->bdev); if (drm->agp.bridge) { @@ -1448,7 +1448,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) /* System memory */ return 0; case TTM_PL_TT: -#if IS_ENABLED(CONFI...

Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in functionality since drivers will just fallback to the driver specific PCI GART. For now just deprecate the code and don't enable the AGP GART in TTM even when general AGP support is available. Please comment, Christian.

...rome Glisse <glisse at freedesktop.org> > - */ > - > -#include <linux/pci.h> > - > -#include <drm/drm_agpsupport.h> > -#include <drm/drm_device.h> > -#include <drm/radeon_drm.h> > - > -#include "radeon.h" > - > -#if IS_ENABLED(CONFIG_AGP) > - > -struct radeon_agpmode_quirk { > - u32 hostbridge_vendor; > - u32 hostbridge_device; > - u32 chip_vendor; > - u32 chip_device; > - u32 subsys_vendor; > - u32 subsys_device; > - u32 default_mode; > -}; > - > -static struct radeon_agpmode_quirk radeon_agpmod...

Hi guys, Well let's face it AGP is a total headache to maintain and dead for at least 10+ years. We have a lot of x86 specific stuff in the architecture independent graphics memory management to get the caching right, abusing the DMA API on multiple occasions, need to distinct between AGP and driver specific page tables etc etc... So the idea here is to just go ahead and remove the support

...SOFTWARE. - * - * Authors: - * Dave Airlie - * Jerome Glisse <glisse at freedesktop.org> - */ - -#include <linux/pci.h> - -#include <drm/drm_agpsupport.h> -#include <drm/drm_device.h> -#include <drm/radeon_drm.h> - -#include "radeon.h" - -#if IS_ENABLED(CONFIG_AGP) - -struct radeon_agpmode_quirk { - u32 hostbridge_vendor; - u32 hostbridge_device; - u32 chip_vendor; - u32 chip_device; - u32 subsys_vendor; - u32 subsys_device; - u32 default_mode; -}; - -static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = { - /* Intel E7505 Memory Controller Hub /...

...rome Glisse <glisse at freedesktop.org> > - */ > - > -#include <linux/pci.h> > - > -#include <drm/drm_agpsupport.h> > -#include <drm/drm_device.h> > -#include <drm/radeon_drm.h> > - > -#include "radeon.h" > - > -#if IS_ENABLED(CONFIG_AGP) > - > -struct radeon_agpmode_quirk { > - u32 hostbridge_vendor; > - u32 hostbridge_device; > - u32 chip_vendor; > - u32 chip_device; > - u32 subsys_vendor; > - u32 subsys_device; > - u32 default_mode; > -}; > - > -static...

...* Objects matching this condition have been marked as force_coherent, - * so use the DMA API for them. - */ - if (!nvxx_device(&drm->device)->func->cpu_coherent && - ttm->caching_state == tt_uncached) - return ttm_dma_populate(ttm_dma, dev->dev); - #if IS_ENABLED(CONFIG_AGP) if (drm->agp.bridge) { return ttm_agp_tt_populate(ttm); @@ -1557,16 +1516,6 @@ nouveau_ttm_tt_unpopulate(struct ttm_tt *ttm) dev = drm->dev; pdev = device->dev; - /* - * Objects matching this condition have been marked as force_coherent, - * so use the DMA API for them. - */...

op 11-11-13 16:31, Jerry Cooperstein schreef: > Hi: > > commit bd9c5a2016307164c419c5e24a46921c10e620a0 > > (drm/nouveau: require contiguous bo for framebuffer) > produces about 2000 lines of > > nouveau E[ DRM] framebuffer requires contiguous bo > > on system boot and more on shutdown, but I don't see other > negative effects. I tried deploying a trivial

https://bugs.freedesktop.org/show_bug.cgi?id=53402 Bug #: 53402 Summary: nouveau_bo.c:463:3: error: implicit declaration of function 'ttm_agp_tt_create' Classification: Unclassified Product: xorg Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity:

...ersions do you use? >> >> ~Maarten >> >> > > I'm just using vanilla 3.12 kernel. Been using the nouveau driver > for a long time, no problems until this printout due to the > contiguous check. Not using any of the "nvidia" related modules etc. > CONFIG_AGP is set. Sorry I meant userspace, libdrm, mesa, xserver-xorg-video-nouveau? Using Xorg, mir or wayland?

...fragmented vram. > > What driver versions do you use? > > ~Maarten > > I'm just using vanilla 3.12 kernel. Been using the nouveau driver for a long time, no problems until this printout due to the contiguous check. Not using any of the "nvidia" related modules etc. CONFIG_AGP is set. lsmod | grep nouveau nouveau 895494 2 ttm 67720 1 nouveau drm_kms_helper 38367 1 nouveau drm 258311 4 nouveau,ttm,drm_kms_helper i2c_algo_bit 5122 1 nouveau mxm_wmi 1769 1 nouveau wmi...

...FIG_LEGACY_PTY_COUNT=256 CONFIG_IPMI_HANDLER=y CONFIG_IPMI_PANIC_EVENT=y CONFIG_IPMI_PANIC_STRING=y CONFIG_IPMI_DEVICE_INTERFACE=y CONFIG_IPMI_SI=y CONFIG_IPMI_WATCHDOG=y CONFIG_IPMI_POWEROFF=y CONFIG_WATCHDOG=y CONFIG_SOFT_WATCHDOG=y CONFIG_I8XX_TCO=y CONFIG_HW_RANDOM=y CONFIG_NVRAM=y CONFIG_RTC=y CONFIG_AGP=y CONFIG_AGP_INTEL=y CONFIG_AGP_INTEL_MCH=y CONFIG_DRM=y CONFIG_DRM_RADEON=y CONFIG_RAW_DRIVER=y CONFIG_HPET=y CONFIG_HPET_MMAP=y CONFIG_MAX_RAW_DEVS=256 CONFIG_I2C=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_ALGOBIT=y CONFIG_I2C_ALGOPCF=y CONFIG_I2C_ALGOPCA=y CONFIG_I2C_SENSOR=y CONFIG_SENSORS_LM83=y CONFIG...

...PPABLE)) > return -EINVAL; > + > + mutex_lock(&drm->ttm.io_reserve_mutex); > +retry: > switch (reg->mem_type) { > case TTM_PL_SYSTEM: > /* System memory */ > - return 0; > + ret = 0; > + goto out; > case TTM_PL_TT: > #if IS_ENABLED(CONFIG_AGP) > if (drm->agp.bridge) { > @@ -1469,7 +1523,6 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) > } args; > u64 handle, length; > u32 argc = 0; > - int ret; > > switch (mem->mem.object.oclass) { > c...

...rm->ttm.io_reserve_mutex); > +retry: > switch (reg->mem_type) { > case TTM_PL_SYSTEM: > /* System memory */ > - return 0; > + ret = 0; > + goto out; > case TTM_PL_TT: > #if IS_ENABLED(CONFIG_AGP) > if (drm->agp.bridge) { > @@ -1469,7 +1523,6 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) > } args; > u64 handle, length; > u32 argc = 0; > -...

Hi guys, I've already send this out in September last year, but only got a response from Daniel. Could you guys please test this and tell me what you think about it? Basically I'm trying to remove all driver specific features from TTM which don't need to be inside the framework. Thanks, Christian.

....is_iomem = false; if (!(man->flags & TTM_MEMTYPE_FLAG_MAPPABLE)) return -EINVAL; + + mutex_lock(&drm->ttm.io_reserve_mutex); +retry: switch (reg->mem_type) { case TTM_PL_SYSTEM: /* System memory */ - return 0; + ret = 0; + goto out; case TTM_PL_TT: #if IS_ENABLED(CONFIG_AGP) if (drm->agp.bridge) { @@ -1469,7 +1523,6 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) } args; u64 handle, length; u32 argc = 0; - int ret; switch (mem->mem.object.oclass) { case NVIF_CLASS_MEM_NV50: @@ -1493,38 +1546,46 @@ nou...

...eg->num_pages << PAGE_SHIFT; - reg->bus.base = 0; reg->bus.is_iomem = false; + mutex_lock(&drm->ttm.io_reserve_mutex); +retry: switch (reg->mem_type) { case TTM_PL_SYSTEM: /* System memory */ - return 0; + ret = 0; + goto out; case TTM_PL_TT: #if IS_ENABLED(CONFIG_AGP) if (drm->agp.bridge) { @@ -1043,9 +1098,12 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_resource *reg) reg->bus.is_iomem = !drm->agp.cma; } #endif - if (drm->client.mem->oclass < NVIF_CLASS_MEM_NV50 || !mem->kind) + if (drm->client.mem-&...

...LAG_MAPPABLE)) > return -EINVAL; > + > + mutex_lock(&drm->ttm.io_reserve_mutex); > +retry: > switch (reg->mem_type) { > case TTM_PL_SYSTEM: > /* System memory */ > - return 0; > + ret = 0; > + goto out; > case TTM_PL_TT: > #if IS_ENABLED(CONFIG_AGP) > if (drm->agp.bridge) { > @@ -1468,7 +1522,6 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) > } args; > u64 handle, length; > u32 argc = 0; > - int ret; > > switch (mem->mem.object.oclass) { > case NVI...

....is_iomem = false; if (!(man->flags & TTM_MEMTYPE_FLAG_MAPPABLE)) return -EINVAL; + + mutex_lock(&drm->ttm.io_reserve_mutex); +retry: switch (reg->mem_type) { case TTM_PL_SYSTEM: /* System memory */ - return 0; + ret = 0; + goto out; case TTM_PL_TT: #if IS_ENABLED(CONFIG_AGP) if (drm->agp.bridge) { @@ -1468,7 +1522,6 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg) } args; u64 handle, length; u32 argc = 0; - int ret; switch (mem->mem.object.oclass) { case NVIF_CLASS_MEM_NV50: @@ -1492,38 +1545,45 @@ nou...