Displaying 2 results from an estimated 2 matches for "compute_silk_rate_for_hybrid".
2019 Sep 12
2
NaN sanity check not present in tree.
Hi, I'm still Yves.
This other fix
<https://chromium-review.googlesource.com/c/chromium/src/+/1061499/> never
made it to opus repository.
It seems safe and sane enough to be applied to opus master branch.
What do you think?
--
Warm regards,
Yves
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
2019 Sep 23
0
NaN sanity check not present in tree.
...his patch fixes? If so, do you have a way to
reproduce the problem?
While technically your patch would be safe, the simple fact that it
would trigger would mean a bug elsewhere. Note that HB_gain is
essentially 1 - exp(-celt_rate/1024.) where celt_rate is supposed to
always be non-negative because compute_silk_rate_for_hybrid() should
never give SILK more bits than there are in total. That means HB_gain
should be bounded between 0 and 1 and should definitely never be NaN.
So either the patch does nothing (in which case we don't need it), or it
does something and there's something much scarier going on than NaNs...