search for: compare_str

...ctions.c 2002/04/11 06:22:04 1.1 --- avl_functions.c 2002/04/11 06:23:35 *************** *** 307,313 **** } snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port); ! snprintf(s2, "%s:%d", dir2->host, dir2->port); return compare_strings (s1, s2, param); } --- 307,313 ---- } snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port); ! snprintf(s2, BUFSIZE, "%s:%d", dir2->host, dir2->port); return compare_strings (s1, s2, param); ------ Dave Hayes - Consultant -...

...ctions.c 2002/04/11 06:22:04 1.1 --- avl_functions.c 2002/04/11 06:23:35 *************** *** 307,313 **** } snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port); ! snprintf(s2, "%s:%d", dir2->host, dir2->port); return compare_strings (s1, s2, param); } --- 307,313 ---- } snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port); ! snprintf(s2, BUFSIZE, "%s:%d", dir2->host, dir2->port); return compare_strings (s1, s2, param); } *** main.c 2002/04/11 06...

...ctions.c 2002/04/11 06:22:04 1.1 --- avl_functions.c 2002/04/11 06:23:35 *************** *** 307,313 **** } snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port); ! snprintf(s2, "%s:%d", dir2->host, dir2->port); return compare_strings (s1, s2, param); } --- 307,313 ---- } snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port); ! snprintf(s2, BUFSIZE, "%s:%d", dir2->host, dir2->port); return compare_strings (s1, s2, param); } *** main.c 2002/04/11 06...

Partition number was being passed to guestfs___check_for_filesystem_on based on an index in list_partition. However, this ignores the possibility of multiple block devices. This change makes guestfs___check_for_filesystem_on examine the passed-in device directly to determine if it is a whole device, or what its partition number is. --- src/guestfs-internal.h | 2 +- src/inspect-fs.c | 45

This is the (incomplete) patch which reimplements inspection APIs in the daemon. All ‘XXX’s in this patch indicate areas which are not yet implemented or need further work. Rich.

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I

This depends on the patch series "[PATCH 00/27] Reimplement many daemon APIs in OCaml." (https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html) v8 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html v9: - I split up the mega-patch into a more reviewable series of smaller, incremental patches. There are some other changes vs v8, but

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html No actual change here, but I rebased and retested. Also this series now does not depend on any other patch series since everything else needed is upstream. Rich.

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid