Icecast dev - Aug 2004 - Some nits in icecast 1.3.12

I tried admin rehash for the first time since upgrading to 1.3.12 today. The
rehash took at least 30 seconds [If not longer -- I didn't time it very
closely] and icecast slowly snuck up to 99% CPU usage. I tried issuing the
'alias' command just to try and get a response from the console and that
never responded. [I waited about two minutes]

I had the same experience both of my servers, one RedHat 7.2 and the other
FreeBSD 4.2-RELEASE. Restarting icecast seemed to fix the problem, but being
able to add aliases to the config and rehash was a really nice feature to
have. Did this break between 1.3.10 and 1.3.12? I had 1.3.11 somewhere in
there as well but I'm not sure I used rehash from the console while I was
running 1.3.11...

Thanks,

bds

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

Attached are nits I found in 1.3.12. That first patch there 
looks more like a bug than a nit. 
------
Dave Hayes - Consultant - Altadena CA, USA - dave@jetcafe.org
>>> The opinions expressed above are entirely my own <<<
Before criticizing people, walk a mile in their shoes. Then
when you do criticize them, you will be a mile away and have
their shoes.

*** avl_functions.c     2002/04/11 06:22:04     1.1
--- avl_functions.c     2002/04/11 06:23:35
***************
*** 307,313 ****
        }
  
        snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port);
!       snprintf(s2, "%s:%d", dir2->host, dir2->port);
  
        return compare_strings (s1, s2, param);
  }
--- 307,313 ----
        }
  
        snprintf(s1, BUFSIZE, "%s:%d", dir1->host, dir1->port);
!       snprintf(s2, BUFSIZE, "%s:%d", dir2->host, dir2->port);
  
        return compare_strings (s1, s2, param);
  }
*** main.c      2002/04/11 06:23:49     1.1
--- main.c      2002/04/11 06:25:07
***************
*** 544,550 ****
        directory_server_t *ds;
        int i;
        avl_traverser trav = {0};
!       static main_shutting_down = 0;
        
        thread_library_lock ();
                if (!main_shutting_down)
--- 544,550 ----
        directory_server_t *ds;
        int i;
        avl_traverser trav = {0};
!       static int main_shutting_down = 0;
        
        thread_library_lock ();
                if (!main_shutting_down)

<p><p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.