search for: chroot_

...t ?name () = Chroot.create (Sysroot.sysroot ()) ?name this way it can be used like: let chroot = create_chroot ~name:(sprintf "file: %s" path) in > + > + let statbuf = Chroot.f chroot lstat path in Hm is chroot needed for this? The current C implementation does not use CHROOT_IN/OUT, and it does not even resolve symlinks, so it should be safe. -- Pino Toscano

On Wed, Jul 19, 2017 at 03:14:48PM +0200, Pino Toscano wrote: > > + > > + let statbuf = Chroot.f chroot lstat path in > > Hm is chroot needed for this? The current C implementation does not > use CHROOT_IN/OUT, and it does not even resolve symlinks, so it should > be safe. The implementation is different, but I think it's equivalent and safe. The ‘Chroot’ module is a significant enhancement over the C CHROOT_* hacks and over the cases where the C code should be doing a chroot but doesn'...

The more I look at this patch, the less I like it. I would summarise why I think it's wrong here, but it's better if you look at the message I posted on the gnulib mailing list here first: http://lists.gnu.org/archive/html/bug-gnulib/2009-11/msg00434.html Directly accessing errno on Windows is wrong: you won't see the true reasons for an error by doing that. However depending on