search for: celt_pitch_xcorr

...with NE10 */ }; -#endif +#endif /* HAVE_ARM_NE10 */ # if defined(FIXED_POINT) + +#if defined(OPUS_ARM_MAY_HAVE_NEON) || defined(OPUS_ARM_MAY_HAVE_EDSP) + +#if !defined(OPUS_ARM_PRESUME_NEON) && (!defined(OPUS_ARM_PRESUME_EDSP) || defined(OPUS_ARM_MAY_HAVE_NEON)) + opus_val32 (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, const opus_val16 *, opus_val32 *, int , int) = { celt_pitch_xcorr_c, /* ARMv4 */ @@ -104,8 +109,23 @@ opus_val32 (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, MAY_HAVE_MEDIA(celt_pitch_xcorr), /* Media */ M...

...iling error. Thanks, Linfeng Zhang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170720/661d96b5/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Fix-celt_pitch_xcorr-ARM-jump-table-compiling-error.patch Type: text/x-patch Size: 1538 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20170720/661d96b5/attachment.bin>

...ization for performance. >> >> Would prefer something like opusdec that can be executed on command >> line. > > > The easiest thing to use is probably opus_demo (opusdec does a bunch of extra things, plus for interactive use we care about both the encoder and decoder, and celt_pitch_xcorr gets used vastly more by the encoder than the decoder... I think the decoder only uses it for PLC). > > Something like > ./opus_demo restricted-lowdelay 48000 2 96000 comp48-stereo.sw /dev/null > > comp48-stereo.sw can be found here: https://people.xiph.org/~tterribe/opus/comp48-ster...

...>> > >> Would prefer something like opusdec that can be executed on command > >> line. > > > > > > The easiest thing to use is probably opus_demo (opusdec does a bunch of extra things, plus for interactive use we care about both the encoder and decoder, and celt_pitch_xcorr gets used vastly more by the encoder than the decoder... I think the decoder only uses it for PLC). > > > > Something like > > ./opus_demo restricted-lowdelay 48000 2 96000 comp48-stereo.sw /dev/null > > > > comp48-stereo.sw can be found here: https://people.xiph.org/~...

...mp; \ > + ((defined(OPUS_ARM_MAY_HAVE_NEON) && !defined(OPUS_ARM_PRESUME_NEON)) || \ > + (defined(OPUS_ARM_MAY_HAVE_MEDIA) && !defined(OPUS_ARM_PRESUME_MEDIA)) || \ > + (defined(OPUS_ARM_MAY_HAVE_EDSP) && !defined(OPUS_ARM_PRESUME_EDSP))) > opus_val32 (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, > const opus_val16 *, opus_val32 *, int , int) = { Maybe I'm missing something, but... > -/*Is run-time CPU detection enabled on this platform?*/ > -# if defined(OPUS_HAVE_RTCD) && (defined(OPUS_ARM_ASM) \ > - || (defined(...

Hi, all, Does Opus need celt_pitch_xcorr' s fixed point version for ARM aarch64 architecture? If yes, which version does Opus prefer: assembly or instrinsics? Thanks, Zhongwei -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please...

...fer something like opusdec that can be executed on command >>> >> line. >>> > >>> > >>> > The easiest thing to use is probably opus_demo (opusdec does a bunch of extra things, plus for interactive use we care about both the encoder and decoder, and celt_pitch_xcorr gets used vastly more by the encoder than the decoder... I think the decoder only uses it for PLC). >>> > >>> > Something like >>> > ./opus_demo restricted-lowdelay 48000 2 96000 comp48-stereo.sw /dev/null >>> > >>> > comp48-stereo.sw can...

...t;> Would prefer something like opusdec that can be executed on command >> >> line. >> > >> > >> > The easiest thing to use is probably opus_demo (opusdec does a bunch of extra things, plus for interactive use we care about both the encoder and decoder, and celt_pitch_xcorr gets used vastly more by the encoder than the decoder... I think the decoder only uses it for PLC). >> > >> > Something like >> > ./opus_demo restricted-lowdelay 48000 2 96000 comp48-stereo.sw /dev/null >> > >> > comp48-stereo.sw can be found here: https...

...eedback from engineers working on NE10 [1] that it would be better to use NE10 [1] for FFT optimizations for opus use cases. However, these FFT patches are currently in review and haven't been integrated into NE10 yet. While the FFT functions in NE10 are getting baked, I wanted to optimize the celt_pitch_xcorr (floating point only) and use it to introduce ARM NEON intrinsics into libopus project. This will also lay the foundation when FFT routines in NE10 become available. I would like to know the following as I DID NOT fully use-case test this celt_pitch_xcorr optimization. Did only unit tests. a. Si...

...e to validate this optimization for performance. > > Would prefer something like opusdec that can be executed on command > line. The easiest thing to use is probably opus_demo (opusdec does a bunch of extra things, plus for interactive use we care about both the encoder and decoder, and celt_pitch_xcorr gets used vastly more by the encoder than the decoder... I think the decoder only uses it for PLC). Something like ./opus_demo restricted-lowdelay 48000 2 96000 comp48-stereo.sw /dev/null comp48-stereo.sw can be found here: https://people.xiph.org/~tterribe/opus/comp48-stereo.sw celt_pitch_xco...

...y command line.. Otherwise, the patch for RFCv2 is identical. Regards, Vish On 7 December 2014 at 02:08, --no-chain-reply-to --thread ./* <viswanath.puttagunta at linaro.org> wrote: > From: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> > > Hi, > > Optimizes celt_pitch_xcorr for floating point. > > Changes from RFCv1: > - Rebased on top of commit > aad281878: Fix celt_pitch_xcorr_c signature. > which got rid of ugly code around CELT_PITCH_XCORR_IMPL > passing of "arch" parameter. > - Unified with --enable-intrinsics used by x86 >...

...manual/html_node/Per_002dObject-Flags.html which specifically advocates against per object flags. I can follow your feedback if you still think per-object flag is the right thing to do for libopus. Please let me know either way. > > $(SSE_OBJ): CFLAGS += -msse4.1 > >> +void (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, >> + const opus_val16 *, opus_val32 *, int , int, int) = { >> + celt_pitch_xcorr_c, /* ARMv4 */ >> + celt_pitch_xcorr_c, /* EDSP */ >> + celt_pitch_xcorr_c, /* Media...

Zhongwei Yao wrote: > Hi, all, > > Does Opus need celt_pitch_xcorr? s fixed point version for ARM aarch64 > architecture? If yes, which version does Opus prefer: assembly or > instrinsics? It would be nice to have one. I don't have a lot of experience with aarch64 (I still haven't been able to obtain a dev board), so I don't really know how in...

Optimize celt_pitch_xcorr function (for floating point) using ARM NEON intrinsics for SoCs that have NEON VFP unit. As initial step, targeting ARMv7 NEON (VFP3+) based SoCs. To enable this optimization, use --enable-arm-neon-intrinsics configure option. This flag is not enabled by default. Compile time and runtime checks...

...separate library. It brings with it lots of complications (to name one: wouldn't the .pc files need to be updated?). Please use the same mechanism that the SSE intrinsics use to add CFLAGS to the compilation of specific object files, e.g., $(SSE_OBJ): CFLAGS += -msse4.1 > +void (*const CELT_PITCH_XCORR_IMPL[OPUS_ARCHMASK+1])(const opus_val16 *, > + const opus_val16 *, opus_val32 *, int , int, int) = { > + celt_pitch_xcorr_c, /* ARMv4 */ > + celt_pitch_xcorr_c, /* EDSP */ > + celt_pitch_xcorr_c, /* Media */ > +#if defined(OPUS_ARM_NEON_INTR) > + celt_...

Optimize celt_pitch_xcorr function (for fixed point). Even though same code in theory should work for ARMv7 as well, turning this on only for aarch64 at the moment since there is a fixed point asm implementation for ARMv7 neon. Signed-off-by: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> --- celt/arm/cel...

From: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more in-lin...

Optimize celt_pitch_xcorr function (for fixed point). Even though same code in theory should work for ARMv7 as well, turning this on only for aarch64 at the moment since there is a fixed point asm implementation for ARMv7 neon. Signed-off-by: Viswanath Puttagunta <viswanath.puttagunta at linaro.org> --- celt/arm/cel...

>> > Also is there plans to make the NEON optimisations on ARMv7 run time >> > detectable like they have in cairo/pixman? For generic distributions >> > it would nice to be able to be able to enable them as they offer >> > decent performance improvements but have the code fall back on devices >> > that don't support NEON. >> Yep, adding

Hi Timothy, I responded to your feedback before I started on RFCv3.. and took your silence as approval :).. I guess that email got lost in your inbox sea some where.. so re-posting the responses. So, this time, I will wait for your ack before I proceed to RFCv4.. Although.. after all these reviews.. I may just submit it as PATCHv1.. since the patch is almost there and there are no major