search for: br_input

On Thu, May 18, 2023 at 07:08:47PM +0300, Nikolay Aleksandrov wrote: > On 18/05/2023 14:33, Ido Schimmel wrote: > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > > index fc17b9fd93e6..d8ab5890cbe6 100644 > > --- a/net/bridge/br_input.c > > +++ b/net/bridge/br_input.c > > @@ -334,6 +334,7 @@ static rx_handler_result_t br_handle_frame(struct sk_buff **pskb) > > return RX_HANDLER_CONSUMED; > >...

This hook is protected with the RCU, so simple if (br_should_route_hook) br_should_route_hook(...) is not enough on some architectures. Use the rcu_dereference/rcu_assign_pointer in this case. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index 3cedd4e..b42b192 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c @@ -122,6 +122,7 @@ static inline int is_link_local(const unsigned char *dest) struct sk_buff *br_handle_frame(struct net_bridge_port *p, struct sk_buff *skb) { const unsigned char *d...

On Fri, 19 May 2023 16:51:48 +0300 Ido Schimmel wrote: > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > index fc17b9fd93e6..274e55455b15 100644 > --- a/net/bridge/br_input.c > +++ b/net/bridge/br_input.c > @@ -46,6 +46,8 @@ static int br_pass_frame_up(struct sk_buff *skb) > */ > br_switchdev_frame_unmark(skb); > > + skb->...

On Fri, May 19, 2023 at 02:52:18PM -0700, Jakub Kicinski wrote: > On Fri, 19 May 2023 16:51:48 +0300 Ido Schimmel wrote: > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > > index fc17b9fd93e6..274e55455b15 100644 > > --- a/net/bridge/br_input.c > > +++ b/net/bridge/br_input.c > > @@ -46,6 +46,8 @@ static int br_pass_frame_up(struct sk_buff *skb) > > */ > > br_switchdev_frame_unmark(skb)...

...bridge: Add a flag to control unicast packet flood. include/uapi/linux/if_link.h | 2 ++ net/bridge/br_device.c | 8 ++++---- net/bridge/br_fdb.c | 17 ++++++++++++++--- net/bridge/br_forward.c | 14 +++++++++----- net/bridge/br_if.c | 2 +- net/bridge/br_input.c | 9 ++++++--- net/bridge/br_netlink.c | 10 +++++++++- net/bridge/br_private.h | 7 +++++-- net/bridge/br_sysfs_if.c | 4 ++++ 9 files changed, 54 insertions(+), 19 deletions(-) -- 1.7.7.6

On Tue, 2023-05-23 at 11:10 +0300, Ido Schimmel wrote: > On Fri, May 19, 2023 at 02:52:18PM -0700, Jakub Kicinski wrote: > > On Fri, 19 May 2023 16:51:48 +0300 Ido Schimmel wrote: > > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > > > index fc17b9fd93e6..274e55455b15 100644 > > > --- a/net/bridge/br_input.c > > > +++ b/net/bridge/br_input.c > > > @@ -46,6 +46,8 @@ static int br_pass_frame_up(struct sk_buff *skb) > > > */ > > >...

...ing of the bridge forwarding table by frames that have been dropped by filtering. This prevents spoofed source addresses on hostile side of bridge from causing packet leakage, a small but possible security risk. Signed-off-by: Stephen Hemminger <shemminger@osdl.org> Index: bridge/net/bridge/br_input.c =================================================================== --- bridge.orig/net/bridge/br_input.c +++ bridge/net/bridge/br_input.c @@ -54,6 +54,9 @@ int br_handle_frame_finish(struct sk_buf struct net_bridge_fdb_entry *dst; int passedup = 0; + /* insert into forwarding database afte...

...004-07-28 15:30:04 -07:00 @@ -149,7 +149,7 @@ br->lock = SPIN_LOCK_UNLOCKED; INIT_LIST_HEAD(&br->port_list); - br->hash_lock = RW_LOCK_UNLOCKED; + br->hash_lock = SPIN_LOCK_UNLOCKED; br->bridge_id.prio[0] = 0x80; br->bridge_id.prio[1] = 0x00; diff -Nru a/net/bridge/br_input.c b/net/bridge/br_input.c --- a/net/bridge/br_input.c 2004-07-28 15:30:04 -07:00 +++ b/net/bridge/br_input.c 2004-07-28 15:30:04 -07:00 @@ -83,19 +83,17 @@ goto out; } - dst = br_fdb_get(br, dest); + dst = __br_fdb_get(br, dest); if (dst != NULL && dst->is_local) { if (!passe...

...on-vepa_seminar-20090514d.pdf Signed-off-by: Paul Congdon <paul.congdon at hp.com> Signed-off-by: Anna Fischer <anna.fischer at hp.com> --- net/bridge/br_fdb.c | 22 ++++++++++++++ net/bridge/br_forward.c | 24 ++++++++++++++- net/bridge/br_if.c | 3 ++ net/bridge/br_input.c | 9 ++++++ net/bridge/br_private.h | 12 ++++++++ net/bridge/br_sysfs_br.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ net/bridge/br_sysfs_if.c | 17 +++++++++++ 7 files changed, 154 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index...

...on-vepa_seminar-20090514d.pdf Signed-off-by: Paul Congdon <paul.congdon at hp.com> Signed-off-by: Anna Fischer <anna.fischer at hp.com> --- net/bridge/br_fdb.c | 22 ++++++++++++++ net/bridge/br_forward.c | 24 ++++++++++++++- net/bridge/br_if.c | 3 ++ net/bridge/br_input.c | 9 ++++++ net/bridge/br_private.h | 12 ++++++++ net/bridge/br_sysfs_br.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ net/bridge/br_sysfs_if.c | 17 +++++++++++ 7 files changed, 154 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index...

...on-vepa_seminar-20090514d.pdf Signed-off-by: Paul Congdon <paul.congdon at hp.com> Signed-off-by: Anna Fischer <anna.fischer at hp.com> --- net/bridge/br_fdb.c | 22 ++++++++++++++ net/bridge/br_forward.c | 24 ++++++++++++++- net/bridge/br_if.c | 3 ++ net/bridge/br_input.c | 9 ++++++ net/bridge/br_private.h | 12 ++++++++ net/bridge/br_sysfs_br.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ net/bridge/br_sysfs_if.c | 17 +++++++++++ 7 files changed, 154 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index...

...the deactivation of the snooping to be protocol specific by using separate timers for the snooped IGMP and MLD queries as well as separate timers for our internal IGMP and MLD queriers. Signed-off-by: Linus Lüssing <linus.luessing@web.de> --- net/bridge/br_device.c | 2 +- net/bridge/br_input.c | 2 +- net/bridge/br_mdb.c | 14 +- net/bridge/br_multicast.c | 338 +++++++++++++++++++++++++++++++++++---------- net/bridge/br_private.h | 47 +++++-- 5 files changed, 313 insertions(+), 90 deletions(-) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 693...

...r this patch, i need to know the original src and dst mac addresses of the packet incoming to the bridge. As i work on a brouter (some packets are bridged, some are routed based on ebtable rules), packets that are routed have their mac addresses modified by the IP stack). I put a software probe in br_input.c::br_handle_frame( ), but there, the dst mac address is already replaced by the bridge local mac address. My question is: where must i put the probe to get the original src and dst mac addresses? At the driver level? In the bridge, but where? Thx in advance. PS: please CC to louis.croisezATgmail...

...ere is my setup: PC1 (10.0.0.1) ===== BR1 --------- BR2 ===== PC2 (10.0.0.10) After analysis, i determined that these packets were lost because one of the two bridges was in BR_STATE_DISABLED state when the lost packet arrived. In fact, the packet is thrown by the bridge because, in br_input.c::br_handle_frame(), state==BR_STATE_DISABLED which force the code to jump to the err: tag at the end of this function. The state is set to this value while an event is received inside br_notify.c::br_device_event(), which do a br_stp_disable_port(). After putting some printk in br_notify.c, i rem...

...| 24 +-- net/bridge/br_device.c | 13 +- net/bridge/br_fdb.c | 254 +++++++++++++++---- net/bridge/br_forward.c | 131 ++++++++++ net/bridge/br_if.c | 347 ++++++++++++++++++++++++- net/bridge/br_input.c | 69 +++++- net/bridge/br_multicast.c | 71 ++++-- net/bridge/br_netlink.c | 242 +++++++++++++++-- net/bridge/br_private.h | 101 +++++++- net/core/rtnetlink.c | 111 +++++++-...

...rt Xu <herbert at gondor.apana.org.au> Cc: Stephen Hemminger <stephen at networkplumber.org> Cc: "David S. Miller" <davem at davemloft.net> Cc: Adam Baker <linux at baker-net.org.uk> Signed-off-by: Cong Wang <amwang at redhat.com> --- diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index 828e2bc..c706619 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c @@ -99,9 +99,11 @@ int br_handle_frame_finish(struct sk_buff *skb) else if (is_multicast_ether_addr(dest)) { mdst = br_mdb_get(br, skb, vid); if (mdst || BR_INPUT_SKB_CB_MROUTERS_...

Hi, I am configuring some servers in a high availability setup. The servers are connected to two switches with two LAN cards in each server. The two switches are connected directly to each other. The servers are configured to bridge eth0 and eth1 with spanning tree. Usually this makes sure eth1 is disabled, unless something happens to eth0. This way I can have one IP address on each server. Now

...dge/Makefile | 2 + net/bridge/br_device.c | 7 +- net/bridge/br_fdb.c | 258 ++++++++++++--- net/bridge/br_forward.c | 9 + net/bridge/br_if.c | 4 +- net/bridge/br_input.c | 28 ++- net/bridge/br_multicast.c | 69 +++-- net/bridge/br_netlink.c | 242 +++++++++++++-- net/bridge/br_private.h | 175 ++++++++++- net/bridge/br_sysfs_br.c | 21 ++ net/brid...

...| 10 + include/linux/skbuff.h | 4 + include/net/flow_dissector.h | 2 + include/uapi/linux/pkt_cls.h | 2 + net/bridge/br_device.c | 1 + net/bridge/br_forward.c | 3 + net/bridge/br_input.c | 1 + net/core/flow_dissector.c | 3 + net/sched/cls_flower.c | 14 +- .../testing/selftests/net/forwarding/Makefile | 1 + .../net/forwarding/tc_flower_l2_miss.sh | 343 ++++++++++++++++++ 17 files changed, 418 inse...

...| 10 + include/linux/skbuff.h | 4 + include/net/flow_dissector.h | 2 + include/uapi/linux/pkt_cls.h | 2 + net/bridge/br_device.c | 1 + net/bridge/br_forward.c | 3 + net/bridge/br_input.c | 1 + net/core/flow_dissector.c | 3 + net/sched/cls_flower.c | 14 +- .../testing/selftests/net/forwarding/Makefile | 1 + .../net/forwarding/tc_flower_l2_miss.sh | 343 ++++++++++++++++++ 17 files changed, 418 inse...