search for: bodewit

...though I'm going to be spread a little thin for the next three months. After 12 years of this code being in place I doubt I'll be able to cover every imaginable usecase scenario by myself though. But thanks for replying. Was starting to think I was screaming into the void. ;-) - Richard Bodewits On 09/21/2016 03:42 AM, Paul Murrell wrote: > Hi > > Is the correct patch to remove the setting of the gettingEvent flag or > would it be better to flip the TRUE/FALSE setting (set to TRUE before > handling then reset to FALSE after handling) ? > > Also, for this patch and...

...vior in existing scripts. Is this something that should be left alone to minimize disruption? Or should this be fixed (if it is indeed unintended) for the sake of protecting people from infinite recursions? I've included a small patch as attachment that removes the offending lines. - Richard Bodewits -------------- next part -------------- Index: src/main/gevents.c =================================================================== --- src/main/gevents.c (revision 71293) +++ src/main/gevents.c (working copy) @@ -211,8 +211,6 @@ int i; SEXP handler, bvec, sx, sy, temp, result; -...

..., I've also included a minor patch for the help file to at least indicate support for 'prompt = NA'. Apologies if I'm doing this all wrong, or if I'm missing obvious reasons why these patches are unacceptable. As I said, first timer here and new to R in general. ;-) - Richard Bodewits -------------- next part -------------- Index: src/main/gevents.c =================================================================== --- src/main/gevents.c (revision 71269) +++ src/main/gevents.c (working copy) @@ -135,7 +135,7 @@ checkArity(op, args); prompt = CAR(args); - if (!is...

...one difficulty will be with testing the patches. I have no testing code for this, so would need at least a test or two from you (ideally someone would also have some regression tests, beyond ?getGraphicsEvent, to ensure continuity of previous behaviour). Paul On 18/09/2016 3:29 a.m., Richard Bodewits wrote: > Hey all. > > As in general it's a bad idea to allow an event handler to generate an > event, and as comments in the code seem to suggest this isn't the > intention either, I was wondering about recursion in getGraphicsEvent(). > In main/gevents.c, both doMouseEve...

Hi The current status is that I am keen for people to contribute some testing code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) There were also some getGraphicsEvent() changes/fixes suggested by Richard Bodewits (cc'ed), for which I am also seeking test code. Paul On 13/11/16 09:00, frederik at ofb.net wrote: > Hi Paul, > > Just checking in to see what the status is. > > From my perspective it seems logical to split off X11 into a separate > package, so development can proceed at a...

...Murrell wrote: >> Hi >> >> The current status is that I am keen for people to contribute some testing >> code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) >> >> There were also some getGraphicsEvent() changes/fixes suggested by Richard >> Bodewits (cc'ed), for which I am also seeking test code. >> >> Paul >> >> On 13/11/16 09:00, frederik at ofb.net wrote: >>> Hi Paul, >>> >>> Just checking in to see what the status is. >>> >>> From my perspective it seems logical to s...

...Murrell wrote: >> Hi >> >> The current status is that I am keen for people to contribute some testing >> code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) >> >> There were also some getGraphicsEvent() changes/fixes suggested by Richard >> Bodewits (cc'ed), for which I am also seeking test code. >> >> Paul >> >> On 13/11/16 09:00, frederik at ofb.net wrote: >>> Hi Paul, >>> >>> Just checking in to see what the status is. >>> >>> From my perspective it seems logical to s...

...>>> The current status is that I am keen for people to contribute some testing >>>> code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) >>>> >>>> There were also some getGraphicsEvent() changes/fixes suggested by Richard >>>> Bodewits (cc'ed), for which I am also seeking test code. >>>> >>>> Paul >>>> >>>> On 13/11/16 09:00, frederik at ofb.net wrote: >>>>> Hi Paul, >>>>> >>>>> Just checking in to see what the status is. >>&gt...

...ying the recursion fix, would require some sort of stack-aware alternative to gettingEvent's current single boolean implementation. So short version; this patch builds on my do_getGraphicsEvent() recursion patch, and will fix getGraphicsEvent() choking on setTimeLimit() timing out. - Richard Bodewits -------------- next part -------------- Index: src/main/engine.c =================================================================== --- src/main/engine.c (revision 71293) +++ src/main/engine.c (working copy) @@ -3043,6 +3043,7 @@ gd = GEgetDevice(devNum); gd->recordGraphics = TRUE;...

...at 08:55:20AM +1300, Paul Murrell wrote: > Hi > > The current status is that I am keen for people to contribute some testing > code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) > > There were also some getGraphicsEvent() changes/fixes suggested by Richard > Bodewits (cc'ed), for which I am also seeking test code. > > Paul > > On 13/11/16 09:00, frederik at ofb.net wrote: > > Hi Paul, > > > > Just checking in to see what the status is. > > > > From my perspective it seems logical to split off X11 into a separat...

...at 08:55:20AM +1300, Paul Murrell wrote: > Hi > > The current status is that I am keen for people to contribute some testing > code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) > > There were also some getGraphicsEvent() changes/fixes suggested by Richard > Bodewits (cc'ed), for which I am also seeking test code. > > Paul > > On 13/11/16 09:00, frederik at ofb.net wrote: > > Hi Paul, > > > > Just checking in to see what the status is. > > > > From my perspective it seems logical to split off X11 into a separat...

...gt; > > > The current status is that I am keen for people to contribute some testing > > > code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) > > > > > > There were also some getGraphicsEvent() changes/fixes suggested by Richard > > > Bodewits (cc'ed), for which I am also seeking test code. > > > > > > Paul > > > > > > On 13/11/16 09:00, frederik at ofb.net wrote: > > > > Hi Paul, > > > > > > > > Just checking in to see what the status is. > > > >...

...rent status is that I am keen for people to contribute some testing > >>>> code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) > >>>> > >>>> There were also some getGraphicsEvent() changes/fixes suggested by Richard > >>>> Bodewits (cc'ed), for which I am also seeking test code. > >>>> > >>>> Paul > >>>> > >>>> On 13/11/16 09:00, frederik at ofb.net wrote: > >>>>> Hi Paul, > >>>>> > >>>>> Just checking in to...

...gt; > > > The current status is that I am keen for people to contribute some testing > > > code (see https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16951) > > > > > > There were also some getGraphicsEvent() changes/fixes suggested by Richard > > > Bodewits (cc'ed), for which I am also seeking test code. > > > > > > Paul > > > > > > On 13/11/16 09:00, frederik at ofb.net wrote: > > > > Hi Paul, > > > > > > > > Just checking in to see what the status is. > > > >...

Hi Taking a look at those patches is now on my todo list, so I may be in touch with both of you at some point to request some testing. Paul On 26/07/16 07:17, frederik at ofb.net wrote: > Dear Daniel Greenidge, > > To enable getGraphicsEvent on Cairo, you have two patches to choose > from: > > https://bugs.r-project.org/bugzilla/show_bug.cgi?id=14364 >