search for: blueflash

...s() Product: Portable OpenSSH Version: 7.9p1 Hardware: All OS: Mac OS X Status: NEW Severity: trivial Priority: P5 Component: ssh Assignee: unassigned-bugs at mindrot.org Reporter: markus at blueflash.cc During initialization there a memory leak occurs in ssh_set_newkeys(). During startup ssh_set_newkeys() is called twice, once with MODE_OUT and once with MODE_IN. Accordingly the ccp pointer points to state->send_context and state->receive_context At this time state->newkeys[mode...

...et Product: Portable OpenSSH Version: 7.9p1 Hardware: All OS: Windows 10 Status: NEW Severity: normal Priority: P5 Component: ssh Assignee: unassigned-bugs at mindrot.org Reporter: markus at blueflash.cc Created attachment 3254 --> https://bugzilla.mindrot.org/attachment.cgi?id=3254&action=edit free 'supported mechs' through gss_release_oid_set() call Attached is a small patch that should be applied before the 8.0 release. It fixes a problem with a recent patch (authored by m...

While looking for leaks I came across two old packet APIs which are easy to remove. I'm sending patches for each separately. First, there is the packet_set_connection(int fd_in, int fd_out) function in opacket.c The function relies on a behavior in ssh_packet_set_connection() where, when it is passed a NULL pointer, it will implicitely allocate a struct ssh and return it after then set

In sshconnect.c there are two global variables for server_version_string client_version_string. These are used just in a few functions and can easily be passed as parameters. Also, there is a strange construct, where their memory is allocated to the global pointers, then copies of these pointers are assigned to the kex structure. The kex_free finally frees them via cleanup of the kex