thr3ads.net - openssh bugs - [Bug 2982] New: gssapi_cleanup: supported mechs should be freed via gss_release_oid

If this information is useful, please help other people find it:
Share via:

bugzilla-daemon at bugzilla.mindrot.org

2019-Mar-15 09:37 UTC

[Bug 2982] New: gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

            Bug ID: 2982
           Summary: gssapi_cleanup: supported mechs should be freed via
                    gss_release_oid_set
           Product: Portable OpenSSH
           Version: 7.9p1
          Hardware: All
                OS: Windows 10
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: markus at blueflash.cc

Created attachment 3254
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3254&action=edit
free 'supported mechs' through gss_release_oid_set() call

Attached is a small patch that should be applied before the 8.0
release.

It fixes a problem with a recent patch (authored by me), where
gssapi_cleanup was introduced and gssapi resources are freed.

It turns out that the supported_mechs should not be just freed but
instead freed through gss_release_oid_set.

The error is probably irrelevant in the *ix/bsd environments, but
turned out to be an error under Windows if a dynamic lib (gssapi.dll)
from MIT Kerbereros is used.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Apr-23 09:05 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

--- Comment #1 from Markus <markus at blueflash.cc> ---
Created attachment 3269
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3269&action=edit
better version


It turns out that the mechs should not only be freed via
gss_release_oid_set.

I also found that that it would be better to do this at the end of the
userauth2() function because gss_cleanup is called multiple times when
more than one method is reported/tried.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Jul-12 03:55 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #3269|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #3269|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Jul-12 04:05 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3254|0                           |1
        is obsolete|                            |
   Attachment #3269|0                           |1
        is obsolete|                            |

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Created attachment 3299
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3299&action=edit
use existing cleanup mechanism

I think we should reuse the existing cleanup mechanism here. I don't
have a working krb/gssapi installation ATM so I can't really test this
though.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Jul-12 04:05 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2988


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2988
[Bug 2988] Tracking bug for 8.1 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Jul-12 07:30 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

--- Comment #3 from Markus <markus at blueflash.cc> ---
> I think we should reuse the existing cleanup mechanism here. I don't
> have a working krb/gssapi installation ATM so I can't really test
> this though.
I have debugged this and found that in some circumstances,
gssapi_cleanup() is called multiple times (see comment1).

If the gssapi system reports multiple mechs it goes through the cycle
init/cleanup for each mech.  

So the supported-mechs-list is on sort of a higher level than a single
gssapi auth attempt.

Hence, releasing the mechs-list itself should not be done in the
gssapi_cleanup function but at the very end of authentication.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Jul-12 07:32 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

--- Comment #4 from Markus <markus at blueflash.cc> ---

(If you are not comfortable with this change, please go back to the old
behavior (I think in 7.8 before gssapi_cleanup was introducted) and let
the supported-mechs list leak instead.)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Oct-09 04:06 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3079


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3079
[Bug 3079] Tracking bug for 8.2 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Oct-09 04:07 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Retarget these bugs to 8.2 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2019-Oct-09 04:08 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2988                        |


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2988
[Bug 2988] Tracking bug for 8.1 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2020-Feb-04 00:44 UTC

head link

[Bug 2982] gssapi_cleanup: supported mechs should be freed via gss_release_oid_set

https://bugzilla.mindrot.org/show_bug.cgi?id=2982

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3117

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Prepare for 8.2 release; retarget bugs


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3117
[Bug 3117] Tracking bug for 8.2 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

bugzilla-daemon at bugzilla.mindrot.org

2020-Feb-04 00:45 UTC

head link