search for: bhumirks

On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > From: Bhumika Goyal <bhumirks at gmail.com> > > Declare virtio_config_ops structure as const as it is only stored in the > config field of a virtio_device structure. This field is of type const, so > virtio_config_ops structures having this property can be declared const. > Done using Coccinelle: > > @...

On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > From: Bhumika Goyal <bhumirks at gmail.com> > > Declare virtio_config_ops structure as const as it is only stored in the > config field of a virtio_device structure. This field is of type const, so > virtio_config_ops structures having this property can be declared const. > Done using Coccinelle: > > @...

On Mon, Jan 16, 2017 at 08:58:34PM +0530, Bhumika Goyal wrote: > On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > >> From: Bhumika Goyal <bhumirks at gmail.com> > >> > >> Declare virtio_config_ops structure as const as it is only stored in the > >> config field of a virtio_device structure. This field is of type const, so > >> virtio_config_ops structures having this property can be declared const. >...

On Mon, Jan 16, 2017 at 08:58:34PM +0530, Bhumika Goyal wrote: > On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > >> From: Bhumika Goyal <bhumirks at gmail.com> > >> > >> Declare virtio_config_ops structure as const as it is only stored in the > >> config field of a virtio_device structure. This field is of type const, so > >> virtio_config_ops structures having this property can be declared const. >...

From: Bhumika Goyal <bhumirks at gmail.com> Declare virtio_config_ops structure as const as it is only stored in the config field of a virtio_device structure. This field is of type const, so virtio_config_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optional_qualifier@ iden...

On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: >> From: Bhumika Goyal <bhumirks at gmail.com> >> >> Declare virtio_config_ops structure as const as it is only stored in the >> config field of a virtio_device structure. This field is of type const, so >> virtio_config_ops structures having this property can be declared const. >> Done using Cocci...

Michael, the following patches have all been posted in the past. I've collected them on top of your vhost branch -- please let me know whether this works for you. The following changes since commit 6bdf1e0efb04a1716373646cb6f35b73addca492: Makefile: drop -D__CHECK_ENDIAN__ from cflags (2016-12-16 00:13:43 +0200) are available in the git repository at:

Michael, the following patches have all been posted in the past. I've collected them on top of your vhost branch -- please let me know whether this works for you. The following changes since commit 6bdf1e0efb04a1716373646cb6f35b73addca492: Makefile: drop -D__CHECK_ENDIAN__ from cflags (2016-12-16 00:13:43 +0200) are available in the git repository at:

...scsi.o text data bss dec hex filename 18063 2985 40 21088 5260 drivers/vhost/scsi.o File size after: drivers/vhost/scsi.o text data bss dec hex filename 18479 2601 40 21120 5280 drivers/vhost/scsi.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 253310c..620366d 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -2087,7 +2087,7 @@ static void vhost_scsi_drop_tport(stru...

...scsi.o text data bss dec hex filename 18063 2985 40 21088 5260 drivers/vhost/scsi.o File size after: drivers/vhost/scsi.o text data bss dec hex filename 18479 2601 40 21120 5280 drivers/vhost/scsi.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 253310c..620366d 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -2087,7 +2087,7 @@ static void vhost_scsi_drop_tport(stru...

...n e1,e2; position ref.p; @@ drm_fb_helper_prepare(e1,e2,&s at p,...) @bad depends on !good1@ position ref.p; identifier match.s; @@ s at p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct drm_fb_helper_funcs s; Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c index 046e28b..15d18fd 100644 --- a/drivers/gpu/drm/virtio/virtgpu_fb.c +++ b/drivers/gpu/drm/virti...

...n e1,e2; position ref.p; @@ drm_fb_helper_prepare(e1,e2,&s at p,...) @bad depends on !good1@ position ref.p; identifier match.s; @@ s at p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct drm_fb_helper_funcs s; Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c index 046e28b..15d18fd 100644 --- a/drivers/gpu/drm/virtio/virtgpu_fb.c +++ b/drivers/gpu/drm/virti...

...i at p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct virtio_config_ops i; File size before and after applying the patch remains the same. text data bss dec hex filename 9235 296 32928 42459 a5db drivers/s390/virtio/virtio_ccw.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/s390/virtio/virtio_ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 639ed4e..6508bf4 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/virtio/virtio_ccw.c...

...i at p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct virtio_config_ops i; File size before and after applying the patch remains the same. text data bss dec hex filename 9235 296 32928 42459 a5db drivers/s390/virtio/virtio_ccw.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/s390/virtio/virtio_ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 639ed4e..6508bf4 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/virtio/virtio_ccw.c...

...to prove? > These numbers show that adding const has decreased the size of the data segment and increased the size of the text segment, suggesting that the changed code has been compiled and the const annotation has had an effect. Thanks, Bhumika > >> Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> >> --- >> drivers/vhost/scsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c >> index 253310c..620366d 100644 >> --- a/drivers/vhost/scsi.c >> +++ b/drivers/vh...

...to prove? > These numbers show that adding const has decreased the size of the data segment and increased the size of the text segment, suggesting that the changed code has been compiled and the const annotation has had an effect. Thanks, Bhumika > >> Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> >> --- >> drivers/vhost/scsi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c >> index 253310c..620366d 100644 >> --- a/drivers/vhost/scsi.c >> +++ b/drivers/vh...

...ec hex filename > 18063 2985 40 21088 5260 drivers/vhost/scsi.o > > File size after: drivers/vhost/scsi.o > text data bss dec hex filename > 18479 2601 40 21120 5280 drivers/vhost/scsi.o > > Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 253310c..620366d 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -2087,7 +20...

...2985 40 21088 5260 drivers/vhost/scsi.o > > File size after: drivers/vhost/scsi.o > text data bss dec hex filename > 18479 2601 40 21120 5280 drivers/vhost/scsi.o What are these numbers trying to prove? > Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 253310c..620366d 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -2087,7 +208...

...ed the size of the text segment, suggesting > that the changed code has been compiled and the const annotation has > had an effect. > > Thanks, > Bhumika I wonder why there's a net increase in memory consumption though. > > > >> Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> > >> --- > >> drivers/vhost/scsi.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > >> index 253310c..620366d 100644 > >> --- a/drivers/vho...