search for: bhumika

On Mon, Jan 16, 2017 at 08:58:34PM +0530, Bhumika Goyal wrote: > On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > >> From: Bhumika Goyal <bhumirks at gmail.com> > >> > >> Declare virtio_config_ops struc...

On Mon, Jan 16, 2017 at 08:58:34PM +0530, Bhumika Goyal wrote: > On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > >> From: Bhumika Goyal <bhumirks at gmail.com> > >> > >> Declare virtio_config_ops struc...

On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > From: Bhumika Goyal <bhumirks at gmail.com> > > Declare virtio_config_ops structure as const as it is only stored in the > config field of a virtio_device structure. This field is of type const, so > virtio_config_ops structures having this property can be declared const. > Done using Cocci...

On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: > From: Bhumika Goyal <bhumirks at gmail.com> > > Declare virtio_config_ops structure as const as it is only stored in the > config field of a virtio_device structure. This field is of type const, so > virtio_config_ops structures having this property can be declared const. > Done using Cocci...

On Tue, Jan 10, 2017 at 10:41 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: >> Declare target_core_fabric_ops strucrues as const as they are only >> passed as an argument to the functions target_register_template and >> target_unregister_template. The arguments are of type const struct >> target_core_fabric_ops *, so target_core_fabric_...

On Tue, Jan 10, 2017 at 10:41 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: >> Declare target_core_fabric_ops strucrues as const as they are only >> passed as an argument to the functions target_register_template and >> target_unregister_template. The arguments are of type const struct >> target_core_fabric_ops *, so target_core_fabric_...

...re: drivers/vhost/scsi.o text data bss dec hex filename 18063 2985 40 21088 5260 drivers/vhost/scsi.o File size after: drivers/vhost/scsi.o text data bss dec hex filename 18479 2601 40 21120 5280 drivers/vhost/scsi.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 253310c..620366d 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -2087,7 +2087,7 @@ static void vhost_s...

...re: drivers/vhost/scsi.o text data bss dec hex filename 18063 2985 40 21088 5260 drivers/vhost/scsi.o File size after: drivers/vhost/scsi.o text data bss dec hex filename 18479 2601 40 21120 5280 drivers/vhost/scsi.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 253310c..620366d 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -2087,7 +2087,7 @@ static void vhost_s...

On Tue, Jan 10, 2017 at 06:11:25PM +0530, Bhumika Goyal wrote: > On Tue, Jan 10, 2017 at 10:41 AM, Michael S. Tsirkin <mst at redhat.com> wrote: > > On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: > >> Declare target_core_fabric_ops strucrues as const as they are only > >> passed as an argument to th...

On Mon, Jan 16, 2017 at 7:59 PM, Michael S. Tsirkin <mst at redhat.com> wrote: > On Mon, Jan 16, 2017 at 03:04:33PM +0100, Cornelia Huck wrote: >> From: Bhumika Goyal <bhumirks at gmail.com> >> >> Declare virtio_config_ops structure as const as it is only stored in the >> config field of a virtio_device structure. This field is of type const, so >> virtio_config_ops structures having this property can be declared const. >&g...

...match.s; expression e1,e2; position ref.p; @@ drm_fb_helper_prepare(e1,e2,&s at p,...) @bad depends on !good1@ position ref.p; identifier match.s; @@ s at p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct drm_fb_helper_funcs s; Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c index 046e28b..15d18fd 100644 --- a/drivers/gpu/drm/virtio/virtgpu_fb.c +++ b/dr...

...match.s; expression e1,e2; position ref.p; @@ drm_fb_helper_prepare(e1,e2,&s at p,...) @bad depends on !good1@ position ref.p; identifier match.s; @@ s at p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct drm_fb_helper_funcs s; Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c index 046e28b..15d18fd 100644 --- a/drivers/gpu/drm/virtio/virtgpu_fb.c +++ b/dr...

...entifier r1.i; @@ i at p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct virtio_config_ops i; File size before and after applying the patch remains the same. text data bss dec hex filename 9235 296 32928 42459 a5db drivers/s390/virtio/virtio_ccw.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/s390/virtio/virtio_ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 639ed4e..6508bf4 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/v...

...entifier r1.i; @@ i at p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct virtio_config_ops i; File size before and after applying the patch remains the same. text data bss dec hex filename 9235 296 32928 42459 a5db drivers/s390/virtio/virtio_ccw.o Signed-off-by: Bhumika Goyal <bhumirks at gmail.com> --- drivers/s390/virtio/virtio_ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 639ed4e..6508bf4 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/v...

...virtio: constify virtio_config_ops structures (2017-01-16 12:26:07 +0100) ---------------------------------------------------------------- - ringtest fixes to make it work on s390 - support new READ_STATUS command - minor cleanups ---------------------------------------------------------------- Bhumika Goyal (1): virtio/s390: virtio: constify virtio_config_ops structures Colin Ian King (1): virtio/s390: add missing \n to end of dev_err message Halil Pasic (2): tools/virtio/ringtest: fix run-on-all.sh for offline cpus tools/virtio/ringtest: tweaks for s390 Pierre Morel (1): virtio/s39...

...virtio: constify virtio_config_ops structures (2017-01-16 12:26:07 +0100) ---------------------------------------------------------------- - ringtest fixes to make it work on s390 - support new READ_STATUS command - minor cleanups ---------------------------------------------------------------- Bhumika Goyal (1): virtio/s390: virtio: constify virtio_config_ops structures Colin Ian King (1): virtio/s390: add missing \n to end of dev_err message Halil Pasic (2): tools/virtio/ringtest: fix run-on-all.sh for offline cpus tools/virtio/ringtest: tweaks for s390 Pierre Morel (1): virtio/s39...

On 2017?01?09? 23:21, Bhumika Goyal wrote: > Declare target_core_fabric_ops strucrues as const as they are only > passed as an argument to the functions target_register_template and > target_unregister_template. The arguments are of type const struct > target_core_fabric_ops *, so target_core_fabric_ops structures h...

On Mon, Jan 09, 2017 at 08:51:02PM +0530, Bhumika Goyal wrote: > Declare target_core_fabric_ops strucrues as const as they are only > passed as an argument to the functions target_register_template and > target_unregister_template. The arguments are of type const struct > target_core_fabric_ops *, so target_core_fabric_ops structures...

From: Bhumika Goyal <bhumirks at gmail.com> Declare virtio_config_ops structure as const as it is only stored in the config field of a virtio_device structure. This field is of type const, so virtio_config_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optio...

...23:46:34 +0200) ---------------------------------------------------------------- virtio, vhost: fixes, cleanups Random fixes and cleanups that accumulated over the time. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Bhumika Goyal (2): vhost: scsi: constify target_core_fabric_ops structures virtio/s390: virtio: constify virtio_config_ops structures Colin Ian King (1): virtio/s390: add missing \n to end of dev_err message Dan Carpenter (1): vhost/scsi: silence uninitialized variable warning G....