search for: bhelgaas

From: Bjorn Helgaas <bhelgaas at google.com> The "virtio_mmio.device=" command line argument allows a user to specify the size, address, and IRQ of a virtio device. Previously the only requirement for the IRQ was that it be an unsigned integer. Zero is an unsigned integer but an invalid IRQ number, and after a85...

From: Bjorn Helgaas <bhelgaas at google.com> The "virtio_mmio.device=" command line argument allows a user to specify the size, address, and IRQ of a virtio device. Previously the only requirement for the IRQ was that it be an unsigned integer. Zero is an unsigned integer but an invalid IRQ number, and after a85...

From: Bjorn Helgaas <bhelgaas at google.com> Commit 3a6536c51d5d ("drm/nouveau: Intercept ACPI_VIDEO_NOTIFY_PROBE") added a definition of ACPI_VIDEO_NOTIFY_PROBE because <acpi/video.h> didn't supply one. Later, commit eff4a751cce5 ("ACPI / video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h&quo...

...4! Rusty: User perms >= group perms >= other perms? Joe: CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2? Side effect of stricter permissions means removing the unnecessary S_IFREG from drivers/pci/slot.c. Suggested-by: Joe Perches <joe at perches.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c index 7dd62fa9d0bd..396c200b9ddb 100644 --- a/drivers/pci/slot.c +++ b/drivers/pci/slot.c @@ -116,11 +11...

...4! Rusty: User perms >= group perms >= other perms? Joe: CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2? Side effect of stricter permissions means removing the unnecessary S_IFREG from drivers/pci/slot.c. Suggested-by: Joe Perches <joe at perches.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c index 7dd62fa9d0bd..396c200b9ddb 100644 --- a/drivers/pci/slot.c +++ b/drivers/pci/slot.c @@ -116,11 +11...

...which properly resets the GPU bus and all device functions under it, including both the GPU and the HDA controller. Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") Cc: Lukas Wunner <lukas at wunner.de> Cc: Daniel Drake <drake at endlessm.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Aaron Plattner <aplattner at nvidia.com> Cc: Peter Wu <peter at lekensteyn.nl> Cc: Ilia Mirkin <imirkin at alum.mit.edu> Cc: Karol Herbst <kherbst at redhat.com> Cc: Maik Freudenberg <hhfeuer at gmx.de> Cc: linux-pci at vger.kernel.org Signed-off-...

Users kept complaining about those messages and it's a little spammy on prime systems so turn it into a debug print. Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Lukas Wunner <lukas at wunner.de> Cc: linux-pci at vger.kernel.org Cc: nouveau at lists.freedesktop.org Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/pci/quirks.c | 2 +- 1 file...

Bjorn Helgaas <bhelgaas at google.com> writes: > On Sun, Sep 06, 2015 at 06:32:35PM +0300, Michael S. Tsirkin wrote: >> On some hypervisors, virtio devices tend to generate spurious interrupts >> when switching between MSI and non-MSI mode. Normally, either MSI or >> non-MSI is used and all is we...

Bjorn Helgaas <bhelgaas at google.com> writes: > On Sun, Sep 06, 2015 at 06:32:35PM +0300, Michael S. Tsirkin wrote: >> On some hypervisors, virtio devices tend to generate spurious interrupts >> when switching between MSI and non-MSI mode. Normally, either MSI or >> non-MSI is used and all is we...

On 2020/7/2 ??6:10, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas at google.com> > > The "virtio_mmio.device=" command line argument allows a user to specify > the size, address, and IRQ of a virtio device. Previously the only > requirement for the IRQ was that it be an unsigned integer. > > Zero is an unsigned integer but an inval...

pci core now disables msi on probe automatically, drop this from device-specific code. Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: linux-pci at vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index e894eb2..806bb2c...

pci core now disables msi on probe automatically, drop this from device-specific code. Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: linux-pci at vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index e894eb2..806bb2c...

...tates. > > v2: convert to pci_dev quirk > put a proper technical explanation of the issue as a in-code comment > v3: disable it only for certain combinations of intel and nvidia hardware > > Signed-off-by: Karol Herbst <kherbst at redhat.com> > Cc: Bjorn Helgaas <bhelgaas at google.com> > Cc: Lyude Paul <lyude at redhat.com> > Cc: Rafael J. Wysocki <rjw at rjwysocki.net> > Cc: Mika Westerberg <mika.westerberg at intel.com> > Cc: linux-pci at vger.kernel.org > Cc: linux-pm at vger.kernel.org > Cc: dri-devel at lists.freedesktop....

...nal change Cc: Jaroslav Kysela <perex at perex.cz> Cc: Takashi Iwai <tiwai at suse.com> Cc: Fred Oh <fred.oh at linux.intel.com> Cc: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com> Cc: Kai Vehmanen <kai.vehmanen at linux.intel.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Signed-off-by: Sui Jingfeng <suijingfeng at loongson.cn> --- sound/pci/hda/hda_intel.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index a21b61ad08d1..811a149584f2 100644 --- a/s...

...Us from D3cold into higher device states. v2: convert to pci_dev quirk put a proper technical explanation of the issue as a in-code comment v3: disable it only for certain combinations of intel and nvidia hardware Signed-off-by: Karol Herbst <kherbst at redhat.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Lyude Paul <lyude at redhat.com> Cc: Rafael J. Wysocki <rjw at rjwysocki.net> Cc: Mika Westerberg <mika.westerberg at intel.com> Cc: linux-pci at vger.kernel.org Cc: linux-pm at vger.kernel.org Cc: dri-devel at lists.freedesktop.org Cc: nouveau at lists.freed...

...t; > > put a proper technical explanation of the issue as a in-code comment > > > v3: disable it only for certain combinations of intel and nvidia hardware > > > > > > Signed-off-by: Karol Herbst <kherbst at redhat.com> > > > Cc: Bjorn Helgaas <bhelgaas at google.com> > > > Cc: Lyude Paul <lyude at redhat.com> > > > Cc: Rafael J. Wysocki <rjw at rjwysocki.net> > > > Cc: Mika Westerberg <mika.westerberg at intel.com> > > > Cc: linux-pci at vger.kernel.org > > > Cc: linux-pm at vger.k...

...ler after runtime suspend? Maybe this should be a pci_info_once() sort of thing? I think there's some value in knowing that we're changing the BIOS configuration outside the purview of a driver, since I assume BIOS had some reason for hiding the HDA controller. > Cc: Bjorn Helgaas <bhelgaas at google.com> > Cc: Lukas Wunner <lukas at wunner.de> > Cc: linux-pci at vger.kernel.org > Cc: nouveau at lists.freedesktop.org > Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") > Signed-off-by: Karol Herbst <kherbst at redhat.com> > --- >...

...er bit. As it's not clear how common this kind of bug is, this patch simply adds a quirk, to be set by devices that wish to skip disabling msi on shutdown, relying on bus master instead. We set this quirk in virtio core. Reported-by: Fam Zheng <famz at redhat.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> Cc: Ulrich Obergfell <uobergfe at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Eric W. Biederman" <ebiederm at xmission.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com&gt...

...er bit. As it's not clear how common this kind of bug is, this patch simply adds a quirk, to be set by devices that wish to skip disabling msi on shutdown, relying on bus master instead. We set this quirk in virtio core. Reported-by: Fam Zheng <famz at redhat.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Yinghai Lu <yhlu.kernel.send at gmail.com> Cc: Ulrich Obergfell <uobergfe at redhat.com> Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Eric W. Biederman" <ebiederm at xmission.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com&gt...

...p perms >= other perms? > Joe: CLASS_ATTR, DEVICE_ATTR, SENSOR_ATTR and SENSOR_ATTR_2? > > Side effect of stricter permissions means removing the unnecessary > S_IFREG from drivers/pci/slot.c. > > Suggested-by: Joe Perches <joe at perches.com> > Cc: Bjorn Helgaas <bhelgaas at google.com> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Acked-by: Bjorn Helgaas <bhelgaas at google.com> for drivers/pci/slot.c It looks like fs/ocfs2/cluster/sys.c and fs/ocfs2/stackglue.c also u...