Michael S. Tsirkin
2015-Mar-29 15:04 UTC
[PATCH v5 06/10] virtio_pci: drop msi_off on probe
pci core now disables msi on probe automatically, drop this from device-specific code. Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: linux-pci at vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio_pci_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index e894eb2..806bb2c 100644 --- a/drivers/virtio/virtio_pci_common.c +++ b/drivers/virtio/virtio_pci_common.c @@ -501,9 +501,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, INIT_LIST_HEAD(&vp_dev->virtqueues); spin_lock_init(&vp_dev->lock); - /* Disable MSI/MSIX to bring device to a known good state. */ - pci_msi_off(pci_dev); - /* enable the device */ rc = pci_enable_device(pci_dev); if (rc) -- MST
On Sun, 03/29 17:04, Michael S. Tsirkin wrote:> pci core now disables msi on probe automatically, > drop this from device-specific code. > > Cc: Bjorn Helgaas <bhelgaas at google.com> > Cc: linux-pci at vger.kernel.org > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > drivers/virtio/virtio_pci_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c > index e894eb2..806bb2c 100644 > --- a/drivers/virtio/virtio_pci_common.c > +++ b/drivers/virtio/virtio_pci_common.c > @@ -501,9 +501,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, > INIT_LIST_HEAD(&vp_dev->virtqueues); > spin_lock_init(&vp_dev->lock); > > - /* Disable MSI/MSIX to bring device to a known good state. */ > - pci_msi_off(pci_dev); > - > /* enable the device */ > rc = pci_enable_device(pci_dev); > if (rc) > -- > MST >Reviewed-by: Fam Zheng <famz at redhat.com>