search for: asteborg

...ake from the tar on Linux (out of the git repo) I am parsing the package_version file from the tarball if it exists so it should maintain the version info. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 11:38 To: Marcus Asteborg; opus at xiph.org Subject: Re: [opus] CMake support for Opus proposal (in addition to Autotools) Thanks, it applies now. I think you'd also want to add some (all?) of these files to EXTRA_DIST in Makefile.am, otherwise your cmake files won't be included in release tarballs, which are gener...

Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus ________________________________ From: Ralph Giles <giles at thaumas.net> Sent: Thursday, June 11, 2020 19:31 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Speaking of needing more complete ci feedback, the intrin0.h patch broke the appveyor build: > Microsoft (R) Build Engine version 14.0.25420.1 > [...] > :\projects\opus\celt\ecintrin...

Hi all, With some downtime it's time for some CMake fixes. Most critically is the SSE fixes to avoid crashes that is described in 154 and 132 in github. Patch 5 should address this and also adding APPROX-FLOAT option. Hopefully this can give some gains for those of us running on Windows servers.j I went through the pull request and picked out a few that will ease up integration for

Hi, Thanks for the quick feedback I have changed the name to avoid conflict. Attached is the updated patch. //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Tuesday, April 2, 2019 00:07 To: Marcus Asteborg; opus at xiph.org Subject: Re: [opus] CMake support for Opus proposal (in addition to Autotools) Hi Marcus, There seems to be a conflict between the autotools-created config.h.in and the same file added by your patch. Any way you can use use a different name? Cheers, Jean-Marc On 04/02...

3, no good catch attached is an updated patch //Marcus ________________________________ From: Jean-Marc Valin <jmvalin at jmvalin.ca> Sent: Thursday, June 11, 2020 10:49 To: Marcus Asteborg <xnorpx at outlook.com>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches On 2020-06-08 01:39, Marcus Asteborg wrote: > 1. Build test for cmake and run the test in gitlab-ci. OK, merged. > 2. Disable the message box on Windows on abort that cause test hang...

...;t know how to do that in cmake, but it would be good to default to a "release" build with optimizations. Can you have a patch to do that? Also, is there a way to manually add flags to the compiler (like setting CFLAGS with autotools)? Cheers, Jean-Marc On 04/02/2019 07:15 PM, Marcus Asteborg wrote: > Right that I had completely missed, I have added the files and verified > that it builds with CMake from the tar on Linux (out of the git repo) > > I am parsing the package_version file from the tarball if it exists so > it should maintain the version info. > > //Mar...

Did the patch 5 split / AVX fix work get merged at all, I didn't see any more mails about it? Thanks! On Tue, 14 Jan 2020 at 21:34, Marcus Asteborg <xnorpx at outlook.com> wrote: > Awesome thanks! Good comments. > > Please apply patch 1-4 and I prepare another iteration on patch 5 for you > too look at. > > //Marcus > ------------------------------ > *From:* Jean-Marc Valin <jmvalin at jmvalin.ca> > *Sen...

Hi, Here are 3 suggested patches. 1. Build test for cmake and run the test in gitlab-ci. 2. Disable the message box on Windows on abort that cause test hangs in CI. 3. Build time improvement by removing unnecessary includes of stdio.h in production code and change to a lighter header intrin.h -> intrin0.h (windows only). Attached screenshot of measurement but it resulted in 14%

Verified that intrin0.h was available in 1910, by building it locally on VS2017 version 15.0 MSVC++ 14.1 _MSC_VER == 1910 (Visual Studio 2017 version 15.0) https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B //Marcus ________________________________ From: Marcus Asteborg <xnorpx at outlook.com> Sent: Thursday, June 11, 2020 20:15 To: Ralph Giles <giles at thaumas.net>; opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Misc patches Sorry about that, let me check the correct version for the intrin0.h include guard. //Marcus _________________...

...ed in release tarballs, which are generate using "make dist". To test, you should try running run "make dist" to generate a tarball yourself. From there, you try building the contents with your cmake files and see if it works. Cheers, Jean-Marc On 04/02/2019 11:26 AM, Marcus Asteborg wrote: > Hi, > > Thanks for the quick feedback I have changed the name to avoid conflict. > > Attached is the updated patch. > > //Marcus > ------------------------------------------------------------------------ > *From:* Jean-Marc Valin <jmvalin at jmvalin.ca>...

Hi, Here is a patch to add build instructions for CMake to the README. * I tried to follow the previous automake style instructions as closely as possible but added instructions for Windows. * Noted that it is still experimental //Marcus -------------- next part -------------- An HTML attachment was scrubbed... URL:

Hi, Here is a proposal for adding CMake in addition of Autotools. See the attached patch for changes or the pull request here: https://github.com/xiph/opus/pull/100 The CMake scripts are parsing the filelist from Autotools, so only one file list needs to be maintained. With this change the checked in Visual Studio solution can be removed and no longer need to be maintained and updated when

...by creating an account on GitHub. github.com That way we can ensure the patch work as expected and doesn't break any exciting behavior. Best Regards Marcus ________________________________ From: Simon Jackson <simon.jackson at sonocent.com> Sent: Tuesday, April 14, 2020 02:12 To: Marcus Asteborg <xnorpx at outlook.com> Cc: opus at xiph.org <opus at xiph.org> Subject: Re: [opus] Opus CMake build support for Apple frameworks Hi Marcus, When building shared libraries for macOS / iOS /tvOS, by default `.dylib` shared libraries will be generated. With this patch `BUILD_FRAMEWORK`...

>>> Marcus Asteborg <xnorpx at outlook.com> schrieb am 24.06.2020 um 19:59 in Nachricht <8175_1593021574_5EF39486_8175_1287_1_DB3PR0602MB378816E9B5FC531496C4CE9FDF950 at D 3PR0602MB3788.eurprd06.prod.outlook.com>: > > ________________________________ > From: Mark Harris <mark.hsj at gmail.com...

________________________________ From: Mark Harris <mark.hsj at gmail.com> Sent: Wednesday, June 24, 2020 00:09 To: Marcus Asteborg <xnorpx at outlook.com> Cc: opus at xiph.org <opus at xiph.org> Subject: Re: Add CMake build instructions to README > Hi Marcus, > Currently the build instructions start with simple instructions for > building from the release tarball, and then provide more complex > alter...

...Make - If CMAKE_BUILD_TYPE is empty and CFlags are set then only use CFlags. If None are set then use CMAKE_BUILD_TYPE by Release by default. github.com //Marcus ________________________________ From: Cristian Adam <cristian.adam at gmail.com> Sent: Thursday, April 11, 2019 00:30 To: Marcus Asteborg Cc: Mark Harris; opus at xiph.org Subject: Re: [opus] Opus cmake build On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com<mailto:xnorpx at outlook.com>> wrote: Hi Mark, Thanks for the feedback. By default CMake is building the static library in debug, to get other...

On Wed, Apr 10, 2019 at 5:30 PM Marcus Asteborg <xnorpx at outlook.com> wrote: > Hi Mark, > > Thanks for the feedback. > > By default CMake is building the static library in debug, to get other > things one has to explicit turn it on. > > Hi, By default CMake uses the "empty" build, which is used in comb...

Hi Simon, CMake 3.14 add support for crosscompiling iOS, tvOS and watchOS https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos Can you clarify what your patch does? //Marcus cmake-toolchains(7) — CMake 3.14.7 Documentation<https://cmake.org/cmake/help/v3.14/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos> The

I tried the new cmake-based build system to build Opus on Linux and macOS. I'm not familiar with cmake but based on instructions I found online I used it as follows: - mkdir build - cd build - cmake -DCMAKE_INSTALL_PREFIX:PATH=<install-path> .. - make - ctest - make install Although the "make" command completed, it reported that optimizations were disabled:

...erns, comments or questions regarding the change please comment in the pull request, reply to this thread or send me an e-mail. Builds and tests: https://xnorpx.visualstudio.com/opus%20build/_build/results?buildId=135 Related Issue: https://github.com/xiph/opus/issues/85 Best Regards Marcus Asteborg -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20181205/f3fc84d9/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: opus_cmake.patch Type: application/octe...