search for: acl_check

Hello, I'm unable to connect to upsd from anywhere except localhost and the debugging output is a bit weird. It looks like acl_check doesn't match even against 0/0. Here's my ACL on upsd.conf: ACL all 0.0.0.0/0 ACL localhost 127.0.0.1/32 ACL lan 10.0.0.0/255.0.0.0 ACCEPT localhost lan REJECT all Here's the output from upsd -DDDD for a request from localhost: acl_check: localhost: match 1 ACL [localhost] matches,...

...ocalhost polling ups: UPS@localhost get_var: UPS@localhost / status Poll UPS [UPS@localhost] failed - Variable not supported by UPS do_notify: ntype 0x0005 (COMMBAD) Communications with UPS UPS@localhost lost ... At this point, upsd reports an error: ... Pinging UPS [UPS] Got PONG from UPS [UPS] acl_check: localhost: match 1 ACL [localhost] matches, action=1 Connection from 127.0.0.1 acl_check: localhost: match 1 ACL [localhost] matches, action=1 write: [destfd=6] [len=3] [OK ] acl_check: localhost: match 1 ACL [localhost] matches, action=1 write: [destfd=6] [len=3] [OK ] acl_check: localhost: match...

...upgraded to the latest stable NUT, but the problem persists. With upsd debugging on I get: [root@cgydc002 sbin]# ./upsd -u nut -DDD -f Network UPS Tools upsd 2.0.4 /var/state/ups is world readable Connected to UPS [SmartUPS1400]: apcsmart-ttyS1 Synchronizing...UPS [SmartUPS1400]: dump is done done acl_check: localhost: match 1 ACL [localhost] matches, action=1 Connection from 127.0.0.1 acl_check: localhost: match 1 ACL [localhost] matches, action=1 write: [destfd=6] [len=33] [VAR SmartUPS1400 ups.status "OL" ] Host 127.0.0.1 disconnected (read failure) acl_check: localhost: match 1 ACL [loca...

...] [ERR DATA-STALE] sstate_dead: driver for UPS [ups1] says data is stale Broadcast Message from radar at negrocreek.dnsalias.net (no tty) at 7:57 UTC... Communications with UPS ups1 at localhost lost sstate_dead: driver for UPS [ups1] says data is stale UPS [ups1] data is no longer stale acl_check: localhost: match 1 ACL [localhost] matches, action=1 write: [destfd=7] [len=30] [VAR ups1 ups.status "OL CHRG"] Broadcast Message from radar at negrocreek.dnsalias.net (no tty) at 7:57 UTC... Communications with UPS ups1 at localhost established acl_check: localhost: match 1 A...

...t sockaddr_in*)ip_addr)->sin_addr.s_addr & htonl(prefix)) == ((struct sockaddr_in*)net_addr)->sin_addr.s_addr); > @@ -72,8 +73,31 @@ > return(0); > } > } > +#endif > > /* see if <addr> matches the acl <aclname> */ > +#ifndef HAVE_IPV6 > +int acl_check(const char *aclname, const struct sockaddr_in *addr) > +{ > + struct acl_t *tmp; > + int aclchk, addrchk; > + > + tmp = acl_head; > + while (tmp != NULL) { > + if (!strcmp(tmp->name, aclname)) { > + aclchk = tmp->addr & tmp->mask; > + addrchk = ntohl(add...

...ip6->s6_addr32[0] == 0)) > + return(1); > + else > + return(0); > + } > + default: > + fatal_with_errno("mask_cmp: Unknown address family"); > + return(0); > + } > +} > > /* see if <addr> matches the acl <aclname> */ > -int acl_check(const char *aclname, const struct sockaddr_in *addr) > +int acl_check(const char *aclname, const struct sockaddr_storage *addr) > { > struct acl_t *tmp; > - int aclchk, addrchk; > > tmp = acl_head; > while (tmp != NULL) { > - if (!strcmp(tmp->name, aclname)) { &...

...utput of "upsd -DDDDD" when starting "upsc apc@localhost > ups.status" (and stopping after 20-30 sec with an ctrl+c) Ah, you have a problem with 'upsc' rather than with 'upscmd' like you stated before. That changes things. > Connection from 127.0.0.1 > acl_check: localhost: match 1 > ACL [localhost] matches, action=1 > write: [destfd=6] [len=24] [VAR apc ups.status "OL"] This looks (almost) good, apparently upsd got a request to send the value of 'ups.status' and decoded this properly. It sends [VAR apc ups.status "OL"] i...