search for: a02e8964eaf9

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Willem de Bruijn <willemb at google.com> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com> --- v2: * change the fix-tag --- dri...

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Willem de Bruijn <willemb at google.com> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com> --- v2: * change the fix-tag --- dri...

...; > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > > I am a bit confused by this tag. Did this change bring about > disabling checksum when LRO is disabled? I am not sure > I follow how ... Hi Michael It's not right fix tag. The commit a02e8964eaf9 ("virtio-net: ethtool configurable LRO"), disable the csum, when we disable the LRO > > Cc: Michael S. Tsirkin <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Cc: Willem de Bruijn <willemb at google.com> > > Signed-off-by: Ton...

...; > > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") > > I am a bit confused by this tag. Did this change bring about > disabling checksum when LRO is disabled? I am not sure > I follow how ... Hi Michael It's not right fix tag. The commit a02e8964eaf9 ("virtio-net: ethtool configurable LRO"), disable the csum, when we disable the LRO > > Cc: Michael S. Tsirkin <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Cc: Willem de Bruijn <willemb at google.com> > > Signed-off-by: Ton...

...;xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > Cc: Michael S. Tsirkin <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Cc: Willem de Bruijn <willemb at google.com> > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com&g...

...;xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when disable the LRO, the > > virtio-net csum is disable too. That drops the forwarding performance. > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > Cc: Michael S. Tsirkin <mst at redhat.com> > > Cc: Jason Wang <jasowang at redhat.com> > > Cc: Willem de Bruijn <willemb at google.com> > > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com&g...

...t; > > Open vSwitch and Linux bridge will disable LRO of the interface > > > > when this interface added to them. Now when disable the LRO, the > > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > > Cc: Jason Wang <jasowang at redhat.com> > > > > Cc: Willem de Bruijn <willemb at google.com> > > > > Signed-off-by: Tonghao...

...ue is > missing. This should be OK for any future feature that is added, as > presumably all of them would require control virtqueue support to notify > the endpoint that offload etc. should begin. > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > Cc: stable at vger.kernel.org [4.20+] > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Cc: David S. Miller <davem at davemloft.net> > Cc: kernel-team at android.com > Cc:...

...ue is > missing. This should be OK for any future feature that is added, as > presumably all of them would require control virtqueue support to notify > the endpoint that offload etc. should begin. > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > Cc: stable at vger.kernel.org [4.20+] > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Cc: David S. Miller <davem at davemloft.net> > Cc: kernel-team at android.com > Cc:...

...that is added, as > > > presumably all of them would require control virtqueue support to notify > > > the endpoint that offload etc. should begin. > > > > > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > > Cc: stable at vger.kernel.org [4.20+] > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > Cc: Jason Wang <jasowang at redhat.com> > > > Cc: David S. Miller <davem at davemloft.net> >...

...that is added, as > > > presumably all of them would require control virtqueue support to notify > > > the endpoint that offload etc. should begin. > > > > > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > > Cc: stable at vger.kernel.org [4.20+] > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > Cc: Jason Wang <jasowang at redhat.com> > > > Cc: David S. Miller <davem at davemloft.net> >...

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason

From: Tonghao Zhang <xiangxia.m.yue at gmail.com> Open vSwitch and Linux bridge will disable LRO of the interface when this interface added to them. Now when disable the LRO, the virtio-net csum is disable too. That drops the forwarding performance. Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Jason

...f them would require control virtqueue support to notify > > > > > the endpoint that offload etc. should begin. > > > > > > > > > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > > > > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > > > > Cc: stable at vger.kernel.org [4.20+] > > > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > > > Cc: Jason Wang <jasowang at redhat.com> > > > > > Cc: David S. Mi...

...f them would require control virtqueue support to notify > > > > > the endpoint that offload etc. should begin. > > > > > > > > > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > > > > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > > > > Cc: stable at vger.kernel.org [4.20+] > > > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > > > Cc: Jason Wang <jasowang at redhat.com> > > > > > Cc: David S. Mi...

...rformance. > > Fixes: e59ff2c49ae1 ("virtio-net: disable guest csum during XDP set") Patch looks fine to me, but wrong commit here? That commit disables csum on purpose when enabling xdp with ndp_bpf. This patch refines disabling LRO with ndo_set_features. The relevant commit is a02e8964eaf9 ("virtio-net: ethtool configurable LRO"). If this is a fix, it should target [PATCH net] separately from the second patch in the patchset, which is a new feature and targets [PATCH net-next]. They can arguably target net-next together, but then it should not have a fixes tag. > Cc: M...

...1 ("virtio-net: disable guest csum during XDP set") > > > > I am a bit confused by this tag. Did this change bring about > > disabling checksum when LRO is disabled? I am not sure > > I follow how ... > Hi Michael > It's not right fix tag. > The commit a02e8964eaf9 ("virtio-net: ethtool configurable LRO"), > disable the csum, when we disable the LRO OK then, pls send a correct Fixes tag when you repost this ... > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > Cc: Jason Wang <jasowang at redhat.com> > >...

...> From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > Open vSwitch and Linux bridge will disable LRO of the interface > when this interface added to them. Now when disable the LRO, the > virtio-net csum is disable too. That drops the forwarding performance. > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Cc: Willem de Bruijn <willemb at google.com> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com> > --- > v2:...

...t; > > > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > > when this interface added to them. Now when disable the LRO, the > > > virtio-net csum is disable too. That drops the forwarding performance. > > > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > > Cc: Michael S. Tsirkin <mst at redhat.com> > > > Cc: Jason Wang <jasowang at redhat.com> > > > Cc: Willem de Bruijn <willemb at google.com> > > > Signed-off-by: Tonghao Zhang <xiangxia....

...isable the LRO, the > virtio-net csum is disable too. That drops the forwarding performance. I had focused on the code previously. The s/w checksum verification cost is significant in a VM with traffic to local destinations. A bridge does not verify transport layer checksums OTOH? > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Jason Wang <jasowang at redhat.com> > Cc: Willem de Bruijn <willemb at google.com> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com> > --- > v2:...