search for: _wopen

...The only solution I can see is to create wrappers around ::stat, ::open, etc. and use them in the codebase instead of direct calls. Unix implementation would only forward calls to the right function. Windows implementation would convert path from utf8 to utf16 and call the appropriate function (::_wopen instead of ::open and so on). Is this solution acceptable? Here's a patch where I tried this (it has a number of issues but I'd like to hear from someone that this solution makes sense before I try to address them). On Wed, Sep 7, 2011 at 9:39 AM, Eli Friedman <eli.friedman at gmail.co...

On Wed, Sep 7, 2011 at 12:20 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > So what are you exactly saying? Somebody proposed using GetCommandLine > instead of using argv directly. And what about my other points about ::open > and ::stat? Because of the way Windows works, the only fully correct solution is to never touch the native charset, and keep everything in UTF-8/16

...I can see is to create wrappers around ::stat, ::open, > etc. and use them in the codebase instead of direct calls. Unix > implementation would only forward calls to the right function. Windows > implementation would convert path from utf8 to utf16 and call the > appropriate function (::_wopen instead of ::open and so on). Is this > solution acceptable? > Here's a patch where I tried this (it has a number of issues but I'd like to > hear from someone that this solution makes sense before I try to address > them). General nitpick: make sure you're using spaces ins...

...1:02, Aaron Ballman a écrit : >> >> > On Wed, Aug 31, 2011 at 1:17 PM, Eli Friedman <eli.friedman at gmail.com> >> > wrote: >> >> On Wed, Aug 31, 2011 at 10:58 AM, Nikola Smiljanic <popizdeh at gmail.com> >> >> wrote: >> >>> _wopen expects wchar_t* and the only visible function for conversion >> >>> to >> >>> utf16 is ConvertUTF8toUTF32 which converts to unsigned shorts. >> >> >> >> If you're in #ifdef WIN32 code, just use ConvertUTF8toUTF16 and >> >> reint...

Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. I have only one more questions: 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is the...

...On Sep 23, 2011, at 9:57 AM, Nikola Smiljanic wrote: > Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. > > I have only one more questions: > > 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is the...

...AM, Nikola Smiljanic wrote: > >> Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. >> >> I have only one more questions: >> >> 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is the...

...t; >> > >> > On Wed, Aug 31, 2011 at 1:17 PM, Eli Friedman <eli.friedman at gmail.com > > >> > wrote: > >> >> On Wed, Aug 31, 2011 at 10:58 AM, Nikola Smiljanic < popizdeh at gmail.com> > >> >> wrote: > >> >>> _wopen expects wchar_t* and the only visible function for conversion > >> >>> to > >> >>> utf16 is ConvertUTF8toUTF32 which converts to unsigned shorts. > >> >> > >> >> If you're in #ifdef WIN32 code, just use ConvertUTF8toUTF16 and &gt...

On Tue, Sep 20, 2011 at 4:15 PM, Nikola Smiljanic <popizdeh at gmail.com> wrote: > OK since this approach makes sense I'll shoot with my questions :) > 1. Where should get_utf8_argv go and is the name of this function OK? Right > now the function is inside llvm::sys::fs namespace because I need access to > Windows.h, should I leave it there. I don't think it belongs

...2011, at 9:57 AM, Nikola Smiljanic wrote: > > Here's a new patch that fixes all the issues mentioned before. Note that > this isn't final, I didn't want to replace all calls to ::stat so that it's > easier to review. > > I have only one more questions: > > 1. _wopen accepts _stat64i32 instead of stat structure. These two are > exactly the same, the only difference is that stat uses time_t > and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this > depends on one more macro). I check to see that size of these two structures > is...

...ote: >> >>> Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. >>> >>> I have only one more questions: >>> >>> 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is the...

...ic wrote: >> >> Here's a new patch that fixes all the issues mentioned before. Note that >> this isn't final, I didn't want to replace all calls to ::stat so that it's >> easier to review. >> >> I have only one more questions: >> >> 1. _wopen accepts _stat64i32 instead of stat structure. These two are >> exactly the same, the only difference is that stat uses time_t >> and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this >> depends on one more macro). I check to see that size of these two structu...

Hi all, Windows 2000 Ruby 1.8.2 RC9 Is it possible to call File.open on a directory in Windows? I always get Errno::EACCES, even though there are no special settings on the directories I''ve tried and I have full access. Dan

...gt; Here's a new patch that fixes all the issues mentioned before. Note that >>> this isn't final, I didn't want to replace all calls to ::stat so that it's >>> easier to review. >>> >>> I have only one more questions: >>> >>> 1. _wopen accepts _stat64i32 instead of stat structure. These two are >>> exactly the same, the only difference is that stat uses time_t >>> and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this >>> depends on one more macro). I check to see that size of these...

...gt;>> Here's a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. >>>> >>>> I have only one more questions: >>>> >>>> 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is the...

...rief explanation of what I did: - Convert argv to utf8 using current system locale for win32 (this is done as soon as possible inside ExpandArgv). This makes the driver happy since calls to llvm::sys::path::exists succeed. - Change calls to ::open (inside FileSystemStatCache and MemoryBuffer) to ::_wopen on win32 by converting the path to utf16. - In order to do the conversions I had to expose two functions, one of them was already there but wasn't visible, the other one was added by me Known issues: - I should probably use LLVM_ON_WIN32 instead of WIN32 but this macro isn't defined insid...

...ch that fixes all the issues mentioned before. Note that >>>> this isn't final, I didn't want to replace all calls to ::stat so that it's >>>> easier to review. >>>> >>>> I have only one more questions: >>>> >>>> 1. _wopen accepts _stat64i32 instead of stat structure. These two are >>>> exactly the same, the only difference is that stat uses time_t >>>> and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this >>>> depends on one more macro). I check to see that s...

...ic wrote: >> >> Here's a new patch that fixes all the issues mentioned before. Note that >> this isn't final, I didn't want to replace all calls to ::stat so that it's >> easier to review. >> >> I have only one more questions: >> >> 1. _wopen accepts _stat64i32 instead of stat structure. These two are >> exactly the same, the only difference is that stat uses time_t >> and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this >> depends on one more macro). I check to see that size of these two structu...

...'s a new patch that fixes all the issues mentioned before. Note that this isn't final, I didn't want to replace all calls to ::stat so that it's easier to review. >>>>> >>>>> I have only one more questions: >>>>> >>>>> 1. _wopen accepts _stat64i32 instead of stat structure. These two are exactly the same, the only difference is that stat uses time_t and _stat64i32 uses __time64_t (time_t is a typedef for __time64_t but this depends on one more macro). I check to see that size of these two structures is the same, but is the...