Displaying 4 results from an estimated 4 matches for "_move_vols".
2010 Jun 09
1
[PATCH] RHEV: Fix generation of OVF file
.../RHEV.pm
index 0fec988..eac15a9 100644
--- a/lib/Sys/VirtV2V/Target/RHEV.pm
+++ b/lib/Sys/VirtV2V/Target/RHEV.pm
@@ -726,7 +726,7 @@ EOF
dir => $dir,
error => $!)));
- return Sys::VirtV2V::Target::RHEV::Vol->_move_vols();
+ Sys::VirtV2V::Target::RHEV::Vol->_move_vols();
my $vm;
my $ovfpath = $dir.'/'.$vmuuid.'.ovf';
--
1.7.0.1
2010 Jun 08
3
[PATCH 1/3] Fix RHEV cleanup on unclean shutdown
Cleanup was not happening properly if a migration to RHEV was killed
prematurely with a Ctrl-C. Firstly, the SIGINT and SIGQUIT handlers were not
being registered early enough in virt-v2v.pl. Secondly, if Ctrl-C killed the
guestfs qemu process first it would deliver a SIGPIPE to v2v, which caused an
unclean shutdown without cleanup.
Fixes RHBZ#596015
---
v2v/virt-v2v.pl | 17 ++++++++++++++---
2011 Jan 26
1
[PATCH] Replace File::Path's remove_tree
.../Sys/VirtV2V/Connection/RHEVTarget.pm
+++ b/lib/Sys/VirtV2V/Connection/RHEVTarget.pm
@@ -243,7 +243,6 @@ sub DESTROY
package Sys::VirtV2V::Connection::RHEVTarget::Vol;
-use File::Path qw(remove_tree);
use File::Spec::Functions;
use File::Temp qw(tempdir);
use POSIX;
@@ -373,6 +372,41 @@ sub _move_vols
$class->_cleanup();
}
+# We used to use remove_tree from File::Path here. Unfortunately it does
+# something unexpected involving chdir which means it will fail bizarrely if the
+# current directory (not the target directory) is not readable by the current
+# user.
+sub _remove_tree
+{
+...
2010 Sep 21
1
[PREVIEW ONLY] Refactor data transfer code
...return shift->{voluuid};
+}
+
+sub _get_creation
+{
+ return shift->{creation};
+}
- delete($self->{writer});
- delete($self->{written});
+sub _get_rhev_format
+{
+ return shift->{rhev_format};
+}
+
+sub _get_rhev_type
+{
+ return shift->{rhev_type};
}
sub _move_vols
@@ -374,11 +467,11 @@ sub _move_vols
my $class = shift;
foreach my $vol (@vols) {
- rename($vol->{tmpdir}, $vol->{dir})
+ rename($vol->{imagetmpdir}, $vol->{imagedir})
or die(user_message(__x("Unable to move volume from temporary "....