Libguestfs - Jun 2010 - [PATCH] RHEV: Fix generation of OVF file

From: Qixiang Wan <qwan at redhat.com>

Commit 0973765674abd773ad04a99ddfdff8e81693e1ff introduced a regression which
caused the OVF file not to be generated when outputting to RHEV.

Fixes RHBZ#602067
---
 lib/Sys/VirtV2V/Target/RHEV.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm b/lib/Sys/VirtV2V/Target/RHEV.pm
index 0fec988..eac15a9 100644
--- a/lib/Sys/VirtV2V/Target/RHEV.pm
+++ b/lib/Sys/VirtV2V/Target/RHEV.pm
@@ -726,7 +726,7 @@ EOF
                                     dir => $dir,
                                     error => $!)));
 
-        return Sys::VirtV2V::Target::RHEV::Vol->_move_vols();
+        Sys::VirtV2V::Target::RHEV::Vol->_move_vols();
 
         my $vm;
         my $ovfpath = $dir.'/'.$vmuuid.'.ovf';
-- 
1.7.0.1

On Wed, Jun 09, 2010 at 10:08:51AM +0100, Matthew Booth
wrote:
> From: Qixiang Wan <qwan at redhat.com>
> 
> Commit 0973765674abd773ad04a99ddfdff8e81693e1ff introduced a regression
which
> caused the OVF file not to be generated when outputting to RHEV.
> 
> Fixes RHBZ#602067
> ---
>  lib/Sys/VirtV2V/Target/RHEV.pm |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/Sys/VirtV2V/Target/RHEV.pm
b/lib/Sys/VirtV2V/Target/RHEV.pm
> index 0fec988..eac15a9 100644
> --- a/lib/Sys/VirtV2V/Target/RHEV.pm
> +++ b/lib/Sys/VirtV2V/Target/RHEV.pm
> @@ -726,7 +726,7 @@ EOF
>                                      dir => $dir,
>                                      error => $!)));
>  
> -        return Sys::VirtV2V::Target::RHEV::Vol->_move_vols();
> +        Sys::VirtV2V::Target::RHEV::Vol->_move_vols();
>  
>          my $vm;
>          my $ovfpath = $dir.'/'.$vmuuid.'.ovf';
> -- 
> 1.7.0.1
ACK obviously ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html