search for: _drop_

...this entire patch; its pointless, just add a new > >DEFINE_PER_CPU for the para-virt muck. > > Yes, I can certainly merge it to the next one in the series. I break it out > to make each individual patch smaller, more single-purpose and easier to > review. No, don't merge it, _drop_ it. Wrapping things in a struct generates a ton of pointless change. Put the new data in a new DEFINE_PER_CPU and leave the existing code as is. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: n...

...this entire patch; its pointless, just add a new > >DEFINE_PER_CPU for the para-virt muck. > > Yes, I can certainly merge it to the next one in the series. I break it out > to make each individual patch smaller, more single-purpose and easier to > review. No, don't merge it, _drop_ it. Wrapping things in a struct generates a ton of pointless change. Put the new data in a new DEFINE_PER_CPU and leave the existing code as is. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: n...

On Wed, May 07, 2014 at 11:01:36AM -0400, Waiman Long wrote: > /* > + * To have additional features for better virtualization support, it is > + * necessary to store additional data in the queue node structure. So > + * a new queue node structure will have to be defined and used here. > + */ > +struct qnode { > + struct mcs_spinlock mcs; > +}; You can ditch this entire

On Wed, May 07, 2014 at 11:01:36AM -0400, Waiman Long wrote: > /* > + * To have additional features for better virtualization support, it is > + * necessary to store additional data in the queue node structure. So > + * a new queue node structure will have to be defined and used here. > + */ > +struct qnode { > + struct mcs_spinlock mcs; > +}; You can ditch this entire

...ge. - Fix a comment. - Fix TOCTTOU: There is now an inline function generated called <name>_is_permitted_state, and this is called twice, first outside the lock for the quick rejection check, and again inside the lock in case the state changed. I think an improvement would be to _drop_ the first check (outside the lock). This is an error check, so not performance critical since we are definitely going to acquire the lock on the hot path. Rich.

...he instruction referencing code so far. This pretty much fufils the objective of this work: we're able to save a lot more variable locations through the register allocator because we don't have to be so conservative about liveness. Plus, the default behaviour of all optimisations now is to _drop_ a variable location, as opposed to the existing situation where after we leave SSA form, all bets are off. Another question is how much this costs in compile time: a clang-3.4 build using instruction referencing on my otherwise idle machine usually tracks within 2% of a normal build. This is IMO e...

...ng code so far. > > This pretty much fufils the objective of this work: we're able to save a lot > more variable locations through the register allocator because we don't have to > be so conservative about liveness. Plus, the default behaviour of all > optimisations now is to _drop_ a variable location, as opposed to the existing > situation where after we leave SSA form, all bets are off. > > Another question is how much this costs in compile time: a clang-3.4 build > using instruction referencing on my otherwise idle machine usually tracks > within 2% of a nor...