search for: 5ce2aa4

...Remove the device in "shutdown" callback to allow device drivers clean up things. Signed-off-by: Fam Zheng <famz at redhat.com> --- drivers/virtio/virtio.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..12f1f1e 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -269,6 +269,19 @@ static int virtio_dev_remove(struct device *_d) return 0; } +static void virtio_dev_shutdown(struct device *_d) +{ + struct virtio_device *dev = dev_to_virtio(_d); + struct virtio_driver *drv = drv...

...Remove the device in "shutdown" callback to allow device drivers clean up things. Signed-off-by: Fam Zheng <famz at redhat.com> --- drivers/virtio/virtio.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..12f1f1e 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -269,6 +269,19 @@ static int virtio_dev_remove(struct device *_d) return 0; } +static void virtio_dev_shutdown(struct device *_d) +{ + struct virtio_device *dev = dev_to_virtio(_d); + struct virtio_driver *drv = drv...

...t; of the reasons for reboot is device mal-functioning. > How about we just reset devices instead? Something like > the below (untested). > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index 5ce2aa4..0769941 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -269,6 +269,17 @@ static int virtio_dev_remove(struct device *_d) > return 0; > } > > +static void virtio_dev_shutdown(struct device *_d) > +{ > + struct virtio_device *dev = dev_to_...

...t; of the reasons for reboot is device mal-functioning. > How about we just reset devices instead? Something like > the below (untested). > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > index 5ce2aa4..0769941 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -269,6 +269,17 @@ static int virtio_dev_remove(struct device *_d) > return 0; > } > > +static void virtio_dev_shutdown(struct device *_d) > +{ > + struct virtio_device *dev = dev_to_...

...ice support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..5fa67b5 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -280,7 +280,7 @@ static struct bus_type virtio_bus = { bool virtio_device_is_legacy_only(struct virtio_device_id id) { - return id.device == VIRTIO_ID_BALLOON; + return false; } EXPORT_SYMBOL_GPL(virtio_device_is_l...

...ice support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..5fa67b5 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -280,7 +280,7 @@ static struct bus_type virtio_bus = { bool virtio_device_is_legacy_only(struct virtio_device_id id) { - return id.device == VIRTIO_ID_BALLOON; + return false; } EXPORT_SYMBOL_GPL(virtio_device_is_l...

...ill cause more hangs on shutdown: one of the reasons for reboot is device mal-functioning. How about we just reset devices instead? Something like the below (untested). Signed-off-by: Michael S. Tsirkin <mst at redhat.com> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..0769941 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -269,6 +269,17 @@ static int virtio_dev_remove(struct device *_d) return 0; } +static void virtio_dev_shutdown(struct device *_d) +{ + struct virtio_device *dev = dev_to_virtio(_d); + /* + * Reset the device to mak...

...ice support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..5fa67b5 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -280,7 +280,7 @@ static struct bus_type virtio_bus = { bool virtio_device_is_legacy_only(struct virtio_device_id id) { - return id.device == VIRTIO_ID_BALLOON; + return false; } EXPORT_SYMBOL_GPL(virtio_device_is_l...

...ill cause more hangs on shutdown: one of the reasons for reboot is device mal-functioning. How about we just reset devices instead? Something like the below (untested). Signed-off-by: Michael S. Tsirkin <mst at redhat.com> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..0769941 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -269,6 +269,17 @@ static int virtio_dev_remove(struct device *_d) return 0; } +static void virtio_dev_shutdown(struct device *_d) +{ + struct virtio_device *dev = dev_to_virtio(_d); + /* + * Reset the device to mak...

...ice support to balloon driver, so we don't need to black-list it in core anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 5ce2aa4..5fa67b5 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -280,7 +280,7 @@ static struct bus_type virtio_bus = { bool virtio_device_is_legacy_only(struct virtio_device_id id) { - return id.device == VIRTIO_ID_BALLOON; + return false; } EXPORT_SYMBOL_GPL(virtio_device_is_l...

...ice mal-functioning. > > How about we just reset devices instead? Something like > > the below (untested). > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > > index 5ce2aa4..0769941 100644 > > --- a/drivers/virtio/virtio.c > > +++ b/drivers/virtio/virtio.c > > @@ -269,6 +269,17 @@ static int virtio_dev_remove(struct device *_d) > > return 0; > > } > > > > +static void virtio_dev_shutdown(struct device *_d) > > +{ &g...

...ice mal-functioning. > > How about we just reset devices instead? Something like > > the below (untested). > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c > > index 5ce2aa4..0769941 100644 > > --- a/drivers/virtio/virtio.c > > +++ b/drivers/virtio/virtio.c > > @@ -269,6 +269,17 @@ static int virtio_dev_remove(struct device *_d) > > return 0; > > } > > > > +static void virtio_dev_shutdown(struct device *_d) > > +{ &g...

Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely define an incompatible interface with a different ID. But for now, it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. The only issue is with the stats buffer, which has misaligned fields. Seems easy to fix by prepending a 6

Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely define an incompatible interface with a different ID. But for now, it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. The only issue is with the stats buffer, which has misaligned fields. Seems easy to fix by prepending a 6