search for: 298,6

...LLVM_ON_WIN32) ? The only way I can think of this happening is if >> that's erroneously false. This works for me: Index: Makefile.rules =================================================================== --- Makefile.rules (revision 65633) +++ Makefile.rules (working copy) @@ -298,6 +298,8 @@ # Common symbols not allowed in dylib files CXX.Flags += -fno-common C.Flags += -fno-common + else ifeq ($(OS),Cygwin) + # Nothing. Cygwin defaults to PIC and warns when given -fPIC else # Linux and others; pass -fPIC CXX.Flags += -fPIC...

> Could you please rig Makefile.rules or something to print out the value > of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if > that's erroneously false. The configure script sets LLVM_ON_UNIX, not LLVM_ON_WIN32, for Cygwin: case $host in ... *-*-cygwin*) llvm_cv_link_all_option="-Wl,--whole-archive"

...dhat.com> --- include/linux/virtio_config.h | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index ed1e0d5..1e306f7 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -298,13 +298,6 @@ static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val) } \ } while(0) -static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset) -{ - u8 ret; - vdev->config->get(vdev, offset, &ret, sizeof(ret)); - return ret; -} - /*...

...dhat.com> --- include/linux/virtio_config.h | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index ed1e0d5..1e306f7 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -298,13 +298,6 @@ static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val) } \ } while(0) -static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset) -{ - u8 ret; - vdev->config->get(vdev, offset, &ret, sizeof(ret)); - return ret; -} - /*...

...f this happening is if > >> that's erroneously false. > > This works for me: > > Index: Makefile.rules > =================================================================== > --- Makefile.rules (revision 65633) > +++ Makefile.rules (working copy) > @@ -298,6 +298,8 @@ > # Common symbols not allowed in dylib files > CXX.Flags += -fno-common > C.Flags += -fno-common > + else ifeq ($(OS),Cygwin) > + # Nothing. Cygwin defaults to PIC and warns when given -fPIC > else > # Linux and others; pass -f...

Add the package that raised the issue, so it can be used to provide better diagnostic. --- src/librpm-c.c | 15 ++++++++++----- src/librpm.ml | 4 ++-- src/librpm.mli | 2 +- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/librpm-c.c b/src/librpm-c.c index 3bd25a2..75ca4d7 100644 --- a/src/librpm-c.c +++ b/src/librpm-c.c @@ -66,10 +66,15 @@ librpm_handle_closed (void) }

...> that's erroneously false. >> >> This works for me: >> >> Index: Makefile.rules >> =================================================================== >> --- Makefile.rules (revision 65633) >> +++ Makefile.rules (working copy) >> @@ -298,6 +298,8 @@ >> # Common symbols not allowed in dylib files >> CXX.Flags += -fno-common >> C.Flags += -fno-common >> + else ifeq ($(OS),Cygwin) >> + # Nothing. Cygwin defaults to PIC and warns when given -fPIC >> else >>...

...++ inspector/{test-virt-inspector.sh => test-virt-inspector.sh.in} | 2 ++ 3 files changed, 5 insertions(+) rename inspector/{test-virt-inspector.sh => test-virt-inspector.sh.in} (92%) diff --git a/.gitignore b/.gitignore index 152a400..89638f5 100644 --- a/.gitignore +++ b/.gitignore @@ -298,6 +298,7 @@ Makefile.in /haskell/Guestfs.hs /inspector/actual-*.xml /inspector/stamp-virt-inspector.pod +/inspector/test-virt-inspector.sh /inspector/test-xmllint.sh /inspector/virt-inspector /inspector/virt-inspector.1 diff --git a/configure.ac b/configure.ac index da7653e..a8d8127 100644 --...

...at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 6c76f0f..913ca23 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_legacy.c @@ -298,7 +298,6 @@ void virtio_pci_legacy_remove(struct pci_dev *pci_dev) unregister_virtio_device(&vp_dev->vdev); - vp_del_vqs(&vp_dev->vdev); pci_iounmap(pci_dev, vp_dev->ioaddr); pci_release_regions(pci_dev); pci_disable_device(pci_dev); -- 1.7.10.4

...at oracle.com> --- drivers/virtio/virtio_pci_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c index 6c76f0f..913ca23 100644 --- a/drivers/virtio/virtio_pci_legacy.c +++ b/drivers/virtio/virtio_pci_legacy.c @@ -298,7 +298,6 @@ void virtio_pci_legacy_remove(struct pci_dev *pci_dev) unregister_virtio_device(&vp_dev->vdev); - vp_del_vqs(&vp_dev->vdev); pci_iounmap(pci_dev, vp_dev->ioaddr); pci_release_regions(pci_dev); pci_disable_device(pci_dev); -- 1.7.10.4

...ls_ucode_img_r367 *img = ls_ucode_img_r367(_img); const struct acr_r352_ls_func *ls_func = acr->func->ls_func[_img->falcon_id]; - u8 gdesc[ls_func->bl_desc_size]; nvkm_gpuobj_memcpy_to(wpr_blob, pos, &img->wpr_header, sizeof(img->wpr_header)); @@ -298,6 +310,8 @@ acr_r367_ls_write_wpr(struct acr_r352 *acr, struct list_head *imgs, nvkm_done(wpr_blob); + kfree(gdesc); + return 0; } -- 2.17.0 -- Kees Cook Pixel Security

...f) { + printk(KERN_INFO + "Unable to allocate memory for receive buffer\n"); + return -ENOMEM; + } + hv_cb_utils[HV_SHUTDOWN_MSG].channel->onchannel_callback = &shutdown_onchannelcallback; hv_cb_utils[HV_SHUTDOWN_MSG].callback = &shutdown_onchannelcallback; @@ -298,6 +298,10 @@ static void exit_hyperv_utils(void) hv_cb_utils[HV_HEARTBEAT_MSG].channel->onchannel_callback = &chn_cb_negotiate; hv_cb_utils[HV_HEARTBEAT_MSG].callback = &chn_cb_negotiate; + + kfree(shut_txf_buf); + kfree(time_txf_buf); + kfree(hbeat_txf_buf); } module_init(ini...

...f) { + printk(KERN_INFO + "Unable to allocate memory for receive buffer\n"); + return -ENOMEM; + } + hv_cb_utils[HV_SHUTDOWN_MSG].channel->onchannel_callback = &shutdown_onchannelcallback; hv_cb_utils[HV_SHUTDOWN_MSG].callback = &shutdown_onchannelcallback; @@ -298,6 +298,10 @@ static void exit_hyperv_utils(void) hv_cb_utils[HV_HEARTBEAT_MSG].channel->onchannel_callback = &chn_cb_negotiate; hv_cb_utils[HV_HEARTBEAT_MSG].callback = &chn_cb_negotiate; + + kfree(shut_txf_buf); + kfree(time_txf_buf); + kfree(hbeat_txf_buf); } module_init(ini...

...>>> ????????????? cb.private = vq; >>> ????????? } else { >>> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >>> index d7b8df3edffc..9f1a845a9302 100644 >>> --- a/drivers/vhost/vhost.c >>> +++ b/drivers/vhost/vhost.c >>> @@ -298,6 +298,13 @@ static void vhost_vq_meta_reset(struct >>> vhost_dev *d) >>> ????????? __vhost_vq_meta_reset(d->vqs[i]); >>> ? } >>> ? +static void vhost_vring_call_reset(struct vhost_vring_call >>> *call_ctx) >>> +{ >>> +??? call_ctx...

...>>> ????????????? cb.private = vq; >>> ????????? } else { >>> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c >>> index d7b8df3edffc..9f1a845a9302 100644 >>> --- a/drivers/vhost/vhost.c >>> +++ b/drivers/vhost/vhost.c >>> @@ -298,6 +298,13 @@ static void vhost_vq_meta_reset(struct >>> vhost_dev *d) >>> ????????? __vhost_vq_meta_reset(d->vqs[i]); >>> ? } >>> ? +static void vhost_vring_call_reset(struct vhost_vring_call >>> *call_ctx) >>> +{ >>> +??? call_ctx...

...this happening is if >>> that's erroneously false. > > This works for me: > > Index: Makefile.rules > =================================================================== > --- Makefile.rules (revision 65633) > +++ Makefile.rules (working copy) > @@ -298,6 +298,8 @@ > # Common symbols not allowed in dylib files > CXX.Flags += -fno-common > C.Flags += -fno-common > + else ifeq ($(OS),Cygwin) > + # Nothing. Cygwin defaults to PIC and warns when given -fPIC > else > # Linux and others; pa...

...tio_config.h | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > index ed1e0d5..1e306f7 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -298,13 +298,6 @@ static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val) > } \ > } while(0) > > -static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset) > -{ > - u8 ret; > - vdev->config->get(vdev, offset, &ret, s...

Print a better diagnostic for them, so it is more clear which package is detected as present multiple times. --- src/supermin.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/supermin.ml b/src/supermin.ml index f9798f9..71d8b64 100644 --- a/src/supermin.ml +++ b/src/supermin.ml @@ -298,6 +298,8 @@ let () = error "error: %s: %s: %s" fname (Unix.error_message code) param | Failure msg -> (* from failwith/failwithf *) error "failure: %s" msg + | Librpm.Multiple_matches (package, count) -> (* from librpm *) + error &quot...

...tio_blk.c +++ b/drivers/block/virtio_blk.c @@ -289,7 +289,6 @@ out: static void virtblk_remove(struct virtio_device *vdev) { struct virtio_blk *vblk = vdev->priv; - int major = vblk->disk->major; /* Nothing should be pending. */ BUG_ON(!list_empty(&vblk->reqs)); @@ -299,7 +298,6 @@ static void virtblk_remove(struct virtio_device *vdev) blk_cleanup_queue(vblk->disk->queue); put_disk(vblk->disk); - unregister_blkdev(major, "virtblk"); mempool_destroy(vblk->pool); vdev->config->del_vq(vblk->vq); kfree(vblk);

...ow up to Eric's patch - fixes error handling in a similar way. drivers/vhost/vhost.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 7c75dce..666aa36 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -298,6 +298,7 @@ static long vhost_dev_set_owner(struct vhost_dev *dev) return 0; err_cgroup: kthread_stop(worker); + dev->worker = NULL; err_worker: if (dev->mm) mmput(dev->mm); -- 1.7.2.rc0.14.g41c1c