search for: 1fdf3098

While investigating the runpm issues on my GP107 I noticed that something inside devinit makes runpm break. If Nouveau loads up to the point right before doing devinit, runpm works without any issues, if devinit is ran, not anymore. Out of curiousity I even tried to "bisect" devinit by not running it on vbios provided signed PMU image, but on the devinit parser we have inside Nouveau.

...igned-off-by: Karol Herbst <kherbst at redhat.com> --- drm/nouveau/include/nvkm/subdev/pci.h | 1 + drm/nouveau/nvkm/subdev/pci/pcie.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h index 23803cc8..1fdf3098 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -53,4 +53,5 @@ int gp100_pci_new(struct nvkm_device *, int, struct nvkm_pci **); /* pcie functions */ int nvkm_pcie_set_link(struct nvkm_pci *, enum nvkm_pcie_speed, u8 width); +enum nvkm_pcie_spee...

...uveau/nvkm/subdev/pci/base.c | 7 +++++-- drm/nouveau/nvkm/subdev/pci/pcie.c | 15 +++++++++++---- drm/nouveau/nvkm/subdev/pci/priv.h | 1 + 4 files changed, 20 insertions(+), 8 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h index 1fdf3098..b23793a2 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -26,8 +26,9 @@ struct nvkm_pci { } agp; struct { - enum nvkm_pcie_speed speed; - u8 width; + enum nvkm_pcie_speed cur_speed; + enum nvkm_pcie_speed def_speed; + u8 cur_width; } p...

...++-- > drm/nouveau/nvkm/subdev/pci/pcie.c | 24 ++++++++++++++++++++---- > drm/nouveau/nvkm/subdev/pci/priv.h | 2 ++ > 4 files changed, 32 insertions(+), 8 deletions(-) > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > index 1fdf3098..b23793a2 100644 > --- a/drm/nouveau/include/nvkm/subdev/pci.h > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > @@ -26,8 +26,9 @@ struct nvkm_pci { > } agp; > > struct { > - enum nvkm_pcie_speed speed; > - u8 width; > + enum nvkm_pcie_speed cur_speed; > + enum...

...ubdev/pci/base.c | 9 +++++++-- drm/nouveau/nvkm/subdev/pci/pcie.c | 24 ++++++++++++++++++++---- drm/nouveau/nvkm/subdev/pci/priv.h | 2 ++ 4 files changed, 32 insertions(+), 8 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h index 1fdf3098..b23793a2 100644 --- a/drm/nouveau/include/nvkm/subdev/pci.h +++ b/drm/nouveau/include/nvkm/subdev/pci.h @@ -26,8 +26,9 @@ struct nvkm_pci { } agp; struct { - enum nvkm_pcie_speed speed; - u8 width; + enum nvkm_pcie_speed cur_speed; + enum nvkm_pcie_speed def_speed; + u8 cur_width; } p...

CCing linux-pci and Bjorn Helgaas. Maybe we could get better insights on how a reasonable fix would look like. Anyway, to me this entire issue looks like something which has to be fixed on a PCI level instead of inside a driver, so it makes sense to ask the pci folks if they have any better suggestions. Original cover letter: While investigating the runpm issues on my GP107 I noticed that

...vkm/subdev/pci/pcie.c | 24 ++++++++++++++++++++---- > > drm/nouveau/nvkm/subdev/pci/priv.h | 2 ++ > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > index 1fdf3098..b23793a2 100644 > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > } agp; > > > > struct { > > - enum nvkm_pcie_speed speed; > > -...

...| 24 ++++++++++++++++++++---- > > > drm/nouveau/nvkm/subdev/pci/priv.h | 2 ++ > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > index 1fdf3098..b23793a2 100644 > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > } agp; > > > > > > struct { > > > - enum nvkm_p...

...> drm/nouveau/nvkm/subdev/pci/priv.h | 2 ++ > > > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > index 1fdf3098..b23793a2 100644 > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > > } agp; > > > > > > > > >...

...---- > > > > drm/nouveau/nvkm/subdev/pci/priv.h | 2 ++ > > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > index 1fdf3098..b23793a2 100644 > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > } agp; > > > > > > > > struct { > >...

...km/subdev/pci/priv.h | 2 ++ > > > > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > > > } agp; > > > > >...

...| 2 ++ > > > > > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > > > > } agp; >...

...; > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > &gt...

...ged, 32 insertions(+), 8 deletions(-) > > > > > > > > > > > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > > @@ -26,8 +26,9 @@ struct nvkm...

...; > > > > > > 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > > > > > > > &gt...

...; 4 files changed, 32 insertions(+), 8 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > @@ -26,8 +26,9 @@ struct nvkm_pci { > &gt...

...ons(+), 8 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drm/nouveau/include/nvkm/subdev/pci.h b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > > > index 1fdf3098..b23793a2 100644 > > > > > > > > > > > > --- a/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > > > +++ b/drm/nouveau/include/nvkm/subdev/pci.h > > > > > > > > > > > > @@ -26,8 +26,9...