Displaying 6 results from an estimated 6 matches for "1ad6f58ea936".
2020 Feb 20
1
[PATCH] virtio_balloon: Fix build error seen with CONFIG_BALLOON_COMPACTION=n
...//virtio/virtio_balloon.c: In function 'virtballoon_probe':
drivers//virtio/virtio_balloon.c:960:1: error:
label 'out_del_vqs' defined but not used [-Werror=unused-label]
This is seen with CONFIG_BALLOON_COMPACTION=n.
Reported-by: kbuild test robot <lkp at intel.com>
Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
Cc: David Hildenbrand <david at redhat.com>
Cc: Michael S. Tsirkin <mst at redhat.com>
Signed-off-by: Guenter Roeck <linux at roeck-us.net>
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed,...
2020 Feb 16
3
[PATCH] virtio_balloon: Adjust label in virtballoon_probe
...NFIG_BALLOON_COMPACTION is unset:
../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
'out_del_vqs' [-Wunused-label]
out_del_vqs:
^~~~~~~~~~~~
1 warning generated.
Move the label within the preprocessor block since it is only used when
CONFIG_BALLOON_COMPACTION is set.
Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
Link: https://github.com/ClangBuiltLinux/linux/issues/886
Signed-off-by: Nathan Chancellor <natechancellor at gmail.com>
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)...
2020 Feb 16
3
[PATCH] virtio_balloon: Adjust label in virtballoon_probe
...NFIG_BALLOON_COMPACTION is unset:
../drivers/virtio/virtio_balloon.c:963:1: warning: unused label
'out_del_vqs' [-Wunused-label]
out_del_vqs:
^~~~~~~~~~~~
1 warning generated.
Move the label within the preprocessor block since it is only used when
CONFIG_BALLOON_COMPACTION is set.
Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()")
Link: https://github.com/ClangBuiltLinux/linux/issues/886
Signed-off-by: Nathan Chancellor <natechancellor at gmail.com>
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)...
2020 Feb 10
3
[PATCH] virtio_balloon: Fix unused label warning
From: Borislav Petkov <bp at suse.de>
Fix
drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?:
drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label]
963 | out_del_vqs:
| ^~
The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too.
Signed-off-by: Borislav Petkov <bp at suse.de>
Cc: David
2020 Feb 10
3
[PATCH] virtio_balloon: Fix unused label warning
From: Borislav Petkov <bp at suse.de>
Fix
drivers/virtio/virtio_balloon.c: In function ?virtballoon_probe?:
drivers/virtio/virtio_balloon.c:963:1: warning: label ?out_del_vqs? defined but not used [-Wunused-label]
963 | out_del_vqs:
| ^~
The CONFIG_BALLOON_COMPACTION ifdeffery should enclose it too.
Signed-off-by: Borislav Petkov <bp at suse.de>
Cc: David
2020 Feb 16
0
[PATCH] virtio_balloon: Fix unused label warning
...dev->config->del_vqs(vdev);
> +#endif
I noticed the same issue and sent an almost identical patch [1] but I
kept the call to del_vqs outside of the CONFIG_BALLOON_COMPACTION guard
since it seems like that should still be called when that config is
unset, as that was the case before commit 1ad6f58ea936 ("virtio_balloon:
Fix memory leaks on errors in virtballoon_probe()"). Is this patch fully
correct? I am not a virtio expert at all, just noticing from a brief
reading of this function.
[1]: https://lore.kernel.org/lkml/20200216004039.23464-1-natechancellor at gmail.com/
Cheers,
Nathan...