samba - Mar 2018 - 'set_simple_acl' referenced before assignment in classicupgrade

Hi,

I am progressing slowly with the migration from Samba3 to Samba4.

I have escaped the bug 13060, now I get to:

Adding groups
Importing groups
Group already exists sid=S-1-5-21-1360262076-8766554542-0991298654-513,
groupname=Unix Group Users existing_groupname=Domain Users, Ignoring.
Committing 'add groups' transaction to disk
Adding users
Importing users
Committing 'add users' transaction to disk
Adding users to groups
Committing 'add users to groups' transaction to disk
ERROR(<type 'exceptions.UnboundLocalError'>): uncaught exception -
local variable 'set_simple_acl' referenced before assignment
  File
"/usr/local/lib/python2.7/site-packages/samba/netcmd/__init__.py",
line 176, in _run
    return self.run(*args, **kwargs)
  File
"/usr/local/lib/python2.7/site-packages/samba/netcmd/domain.py", line
1589, in run
    useeadb=eadb, dns_backend=dns_backend, use_ntvfs=use_ntvfs)
  File "/usr/local/lib/python2.7/site-packages/samba/upgrade.py", line
854, in upgrade_from_samba3
    result.names.domaindn, result.lp, use_ntvfs)
  File
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
line 1546, in setsysvolacl
    set_simple_acl(file.name, 0755, gid)

Any idea what is happening? Google did not give any help.

Thanks in advance,

Olivier
--

On Thu, 22 Mar 2018 10:50:35 +0700
Olivier via samba <samba at lists.samba.org> wrote:
> Hi,
> 
> I am progressing slowly with the migration from Samba3 to Samba4.
> 
> I have escaped the bug 13060, now I get to:
> 
> Adding groups
> Importing groups
> Group already exists
> sid=S-1-5-21-1360262076-8766554542-0991298654-513, groupname=Unix
> Group Users existing_groupname=Domain Users, Ignoring. Committing
> 'add groups' transaction to disk Adding users Importing users
> Committing 'add users' transaction to disk
> Adding users to groups
> Committing 'add users to groups' transaction to disk
> ERROR(<type 'exceptions.UnboundLocalError'>): uncaught
exception -
> local variable 'set_simple_acl' referenced before assignment File
>
"/usr/local/lib/python2.7/site-packages/samba/netcmd/__init__.py",
> line 176, in _run return self.run(*args, **kwargs) File
> "/usr/local/lib/python2.7/site-packages/samba/netcmd/domain.py",
line
> 1589, in run useeadb=eadb, dns_backend=dns_backend,
> use_ntvfs=use_ntvfs) File
> "/usr/local/lib/python2.7/site-packages/samba/upgrade.py", line
854,
> in upgrade_from_samba3 result.names.domaindn, result.lp, use_ntvfs)
> File
>
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
> line 1546, in setsysvolacl set_simple_acl(file.name, 0755, gid)
> 
> Any idea what is happening? Google did not give any help.
> 
> Thanks in advance,
> 
> Olivier
What OS is this on ?
What version of Samba ?

Rowland

Rowland Penny via samba <samba at lists.samba.org> writes:
> On Thu, 22 Mar 2018 10:50:35 +0700
> Olivier via samba <samba at lists.samba.org> wrote:
>
>> Hi,
>> 
>> I am progressing slowly with the migration from Samba3 to Samba4.
>> 
>> I have escaped the bug 13060, now I get to:
>> 
>> Adding groups
>> Importing groups
>> Group already exists
>> sid=S-1-5-21-1360262076-8766554542-0991298654-513, groupname=Unix
>> Group Users existing_groupname=Domain Users, Ignoring. Committing
>> 'add groups' transaction to disk Adding users Importing users
>> Committing 'add users' transaction to disk
>> Adding users to groups
>> Committing 'add users to groups' transaction to disk
>> ERROR(<type 'exceptions.UnboundLocalError'>): uncaught
exception -
>> local variable 'set_simple_acl' referenced before assignment
File
>>
"/usr/local/lib/python2.7/site-packages/samba/netcmd/__init__.py",
>> line 176, in _run return self.run(*args, **kwargs) File
>>
"/usr/local/lib/python2.7/site-packages/samba/netcmd/domain.py", line
>> 1589, in run useeadb=eadb, dns_backend=dns_backend,
>> use_ntvfs=use_ntvfs) File
>> "/usr/local/lib/python2.7/site-packages/samba/upgrade.py",
line 854,
>> in upgrade_from_samba3 result.names.domaindn, result.lp, use_ntvfs)
>> File
>>
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
>> line 1546, in setsysvolacl set_simple_acl(file.name, 0755, gid)
>> 
>> Any idea what is happening? Google did not give any help.
>> 
>> Thanks in advance,
>> 
>> Olivier
>
> What OS is this on ?
> What version of Samba ?
from FreeBSD 10.3-RELEASE-p17/samba36-3.6.25
to FreeBSD 11.1-RELEASE-p6/samba47-4.7.6 (but I had the same issue with
4.7.3)

Thank you,

Olivier
>
> Rowland
--

Hi,

When trying to upgrade from Samba 3.6.25 on FreeBSD 10.3-RELEASE-p17 to
Samba 4.7.6 on FreeBSD 11.1-RELEASE-p6, I receive an error:

# samba-tool domain classicupgrade --dbdir=/usr/local/etc/samba3/
  --realm=samdom.example.com --dns-backend=BIND9_DLZ
  /usr/local/etc/samba3/smb.conf

[...]
Committing 'add users' transaction to disk
Adding users to groups
Committing 'add users to groups' transaction to disk
Setting password for administrator
Administrator password has been set to password of user 'root'
idmapping sid_to_xid failed for id[0]=S-1-5-32-544: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-32-544: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-32-544: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-32-549: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-32-549: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-18: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-18: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-11: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for id[0]=S-1-5-11: NT_STATUS_NONE_MAPPED
[... the group of idmappin sid_to_xid is repeated several time ...]
idmapping sid_to_xid failed for
id[0]=S-1-5-21-1360262076-3929845164-3653621414-520: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for
id[0]=S-1-5-21-1360262076-3929845164-3653621414-520: NT_STATUS_NONE_MAPPED
idmapping sid_to_xid failed for
id[0]=S-1-5-21-1360262076-3929845164-3653621414-512: NT_STATUS_NONE_MAPPED
ERROR(<class 'passdb.error'>): uncaught exception - Unable to get
id for sid
  File
"/usr/local/lib/python2.7/site-packages/samba/netcmd/__init__.py",
line 176, in _run
    return self.run(*args, **kwargs)
  File
"/usr/local/lib/python2.7/site-packages/samba/netcmd/domain.py", line
1589, in run
    useeadb=eadb, dns_backend=dns_backend, use_ntvfs=use_ntvfs)
  File "/usr/local/lib/python2.7/site-packages/samba/upgrade.py", line
854, in upgrade_from_samba3
    result.names.domaindn, result.lp, use_ntvfs)
  File
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
line 1615, in setsysvolacl
    set_gpos_acl(sysvol, dnsdomain, domainsid, domaindn, samdb, lp, use_ntvfs,
passdb=s4_passdb)
  File
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
line 1514, in set_gpos_acl
    passdb=passdb)
  File
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
line 1477, in set_dir_acl
    setntacl(lp, path, acl, domsid, use_ntvfs=use_ntvfs,
skip_invalid_chown=True, passdb=passdb, service=service)
  File "/usr/local/lib/python2.7/site-packages/samba/ntacls.py", line
112, in setntacl
    (owner_id, owner_type) = passdb.sid_to_id(sd.owner_sid)

I confirmed that I have no SID other than S-1-5-21-xxx, these S-1-5-32,
S-1-5-18, etc. does not exist.

I also confimed that S-1-5-21-1360262076-3929845164-3653621414-520 does
not exist (it may have existed a long time ago).

S-1-5-21-1360262076-3929845164-3653621414-512 is the user "root".

What is my mistake?

Thanks in advance,

Olivier


--

On Wed, 04 Apr 2018 15:13:09 +0700
Olivier via samba <samba at lists.samba.org> wrote:
> Hi,
> 
> When trying to upgrade from Samba 3.6.25 on FreeBSD 10.3-RELEASE-p17
> to Samba 4.7.6 on FreeBSD 11.1-RELEASE-p6, I receive an error:
> 
> # samba-tool domain classicupgrade --dbdir=/usr/local/etc/samba3/
>   --realm=samdom.example.com --dns-backend=BIND9_DLZ
>   /usr/local/etc/samba3/smb.conf
> 
> [...]
> Committing 'add users' transaction to disk
> Adding users to groups
> Committing 'add users to groups' transaction to disk
> Setting password for administrator
> Administrator password has been set to password of user 'root'
> idmapping sid_to_xid failed for id[0]=S-1-5-32-544:
> NT_STATUS_NONE_MAPPED idmapping sid_to_xid failed for
> id[0]=S-1-5-32-544: NT_STATUS_NONE_MAPPED idmapping sid_to_xid failed
> for id[0]=S-1-5-32-544: NT_STATUS_NONE_MAPPED idmapping sid_to_xid
> failed for id[0]=S-1-5-32-549: NT_STATUS_NONE_MAPPED idmapping
> sid_to_xid failed for id[0]=S-1-5-32-549: NT_STATUS_NONE_MAPPED
> idmapping sid_to_xid failed for id[0]=S-1-5-18: NT_STATUS_NONE_MAPPED
> idmapping sid_to_xid failed for id[0]=S-1-5-18: NT_STATUS_NONE_MAPPED
> idmapping sid_to_xid failed for id[0]=S-1-5-11: NT_STATUS_NONE_MAPPED
> idmapping sid_to_xid failed for id[0]=S-1-5-11: NT_STATUS_NONE_MAPPED
> [... the group of idmappin sid_to_xid is repeated several time ...]
> idmapping sid_to_xid failed for
> id[0]=S-1-5-21-1360262076-3929845164-3653621414-520:
> NT_STATUS_NONE_MAPPED idmapping sid_to_xid failed for
> id[0]=S-1-5-21-1360262076-3929845164-3653621414-520:
> NT_STATUS_NONE_MAPPED idmapping sid_to_xid failed for
> id[0]=S-1-5-21-1360262076-3929845164-3653621414-512:
> NT_STATUS_NONE_MAPPED ERROR(<class 'passdb.error'>): uncaught
> exception - Unable to get id for sid File
>
"/usr/local/lib/python2.7/site-packages/samba/netcmd/__init__.py",
> line 176, in _run return self.run(*args, **kwargs) File
> "/usr/local/lib/python2.7/site-packages/samba/netcmd/domain.py",
line
> 1589, in run useeadb=eadb, dns_backend=dns_backend,
> use_ntvfs=use_ntvfs) File
> "/usr/local/lib/python2.7/site-packages/samba/upgrade.py", line
854,
> in upgrade_from_samba3 result.names.domaindn, result.lp, use_ntvfs)
> File
>
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
> line 1615, in setsysvolacl set_gpos_acl(sysvol, dnsdomain, domainsid,
> domaindn, samdb, lp, use_ntvfs, passdb=s4_passdb) File
>
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
> line 1514, in set_gpos_acl passdb=passdb) File
>
"/usr/local/lib/python2.7/site-packages/samba/provision/__init__.py",
> line 1477, in set_dir_acl setntacl(lp, path, acl, domsid,
> use_ntvfs=use_ntvfs, skip_invalid_chown=True, passdb=passdb,
> service=service) File
> "/usr/local/lib/python2.7/site-packages/samba/ntacls.py", line
112,
> in setntacl (owner_id, owner_type) = passdb.sid_to_id(sd.owner_sid)
> 
> I confirmed that I have no SID other than S-1-5-21-xxx, these
> S-1-5-32, S-1-5-18, etc. does not exist.
> 
> I also confimed that S-1-5-21-1360262076-3929845164-3653621414-520
> does not exist (it may have existed a long time ago).
> 
> S-1-5-21-1360262076-3929845164-3653621414-512 is the user "root".
It shouldn't be, the RID '512' is the 'Domain Admins' RID,
try changing
this. I don't think this is your problem though, it is more likely to
be the next in line.

Rowland