scott.lovenberg at gmail.com
2012-Oct-18 17:50 UTC
[Samba] CIFS: Deprecating NFS mounting syntax in mount.cifs
The following patch adds a warning when using NFS mounting syntax (server:/share), instead of the usual UNC syntax (//server/share || \\server\share), that support for NFS style mounts will be removed in version 6.0 of the mount.cifs utility. The reasoning for this is simple. Support for NFS syntax is undocumented and increases maintenance overhead. This came up recently on the cifs-utils list when discussing how to handle mounting a share NFS style using an IPv6 address. Since the ':' character is valid in a POSIX file path or share name it is an ambiguous delimiter. Consider the following valid server share : "dead:beef::1:iSCSIExportedByIQN:storage". Instead of adding complicated code to the parser to support an undocumented feature, we're optin g to remove the feature in the mount utility in version 6.0 if there is no objection.
scott.lovenberg at gmail.com
2012-Oct-18 17:50 UTC
[Samba] [PATCH] Add warning that NFS syntax is deprecated and will be removed in cifs-utils-6.0.
From: Scott Lovenberg <scott.lovenberg at gmail.com> Signed-off-by: Scott Lovenberg <scott.lovenberg at gmail.com> --- mount.cifs.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/mount.cifs.c b/mount.cifs.c index 756fce2..061ce32 100644 --- a/mount.cifs.c +++ b/mount.cifs.c @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info } /* Set up "host" and "share" pointers based on UNC format. */ + /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */ if (strncmp(unc_name, "//", 2) && strncmp(unc_name, "\\\\", 2)) { /* * check for nfs syntax (server:/share/prepath) @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info share++; if (*share == '/') ++share; + fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS " + "shares is deprecated and will be removed in cifs-utils" + "-6.0. Please migrate to UNC syntax."); } else { host = unc_name + 2; hostlen = strcspn(host, "/\\"); -- 1.7.5.4
scott.lovenberg at gmail.com
2012-Oct-18 18:07 UTC
[Samba] CIFS: Deprecating NFS mounting syntax in mount.cifs
This patch adds a warning when using NFS mounting syntax (server:/share), instead of the usual UNC syntax (//server/share || \\server\share), that support for NFS style mounts will be removed in version 6.0 of the mount.cifs utility. The reasoning for this is simple. Support for NFS syntax is undocumented and increases maintenance overhead. This came up recently on the cifs-utils list when discussing how to handle mounting a share NFS style using an IPv6 address. Since the ':' character is valid in a POSIX file path or share name it is an ambiguous delimiter. Consider the following valid server share : "dead:beef::1:iSCSIExportedByIQN:storage". Instead of adding complicated code to the parser to support an undocumented feature, we're optin g to remove the feature in the mount utility in version 6.0 if there is no objection.
Apparently Analagous Threads
- Sync passwords unix/smb with FDS backend?
- ZFS Performance as a function of Disk Slice
- ANNOUNCE: cifs-utils release 4.5 available for download
- ANNOUNCE: cifs-utils release 4.2 available for download
- Anybody got windows 10 working with our classic DC / need to migrate to samba4?