samba - Dec 2009 - [patch] swat status page - add share path support

Hi
I created little patch (against 3.3.9) to swat to support
showing share path for locked files (like smbstatus does).


--- source/web/statuspage.c.orig	2009-12-20 23:40:52.000000000 +0100
+++ source/web/statuspage.c	2009-12-20 23:43:19.000000000 +0100
@@ -123,6 +123,7 @@
 			     void *dummy)
 {
 	char           *utf8_fname;
+	char           *utf8_sharepath;
 	int deny_mode;
 	size_t converted_size;

@@ -172,8 +173,9 @@
 	printf("</td>");

 	push_utf8_allocate(&utf8_fname, fname, &converted_size);
-
printf("<td>%s</td><td>%s</td></tr>\n",
-	       utf8_fname,tstring(talloc_tos(),e->time.tv_sec));
+	push_utf8_allocate(&utf8_sharepath, sharepath, &converted_size);
+
printf("<td>%s</td><td>%s</td><td>%s</td></tr>\n",
+	       utf8_sharepath,utf8_fname,tstring(talloc_tos(),e->time.tv_sec));
 	SAFE_FREE(utf8_fname);
 }

@@ -427,8 +429,8 @@

 	printf("<h3>%s</h3>\n", _("Open Files"));
 	printf("<table border=1>\n");
-
printf("<tr><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th></tr>\n",
-		_("PID"), _("UID"), _("Sharing"),
_("R/W"), _("Oplock"), _("File"),
_("Date"));
+
printf("<tr><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th><th>%s</th></tr>\n",
+		_("PID"), _("UID"), _("Sharing"),
_("R/W"), _("Oplock"), _("Share"),
_("File"), _("Date"));

 	locking_init_readonly();
 	share_mode_forall(print_share_mode, NULL);


-- 
Marcin Gryszkalis, PGP 0x9F183FA3 
jabber jid:mg at fork.pl, gg:2532994
http://the.fork.pl

On Sun, Dec 20, 2009 at 11:51:34PM +0100, Marcin Gryszkalis
wrote:
> I created little patch (against 3.3.9) to swat to support
> showing share path for locked files (like smbstatus does).
Pushed to master, thanks.

Depending on how much you want it in 3.5, you might want to
file a bug report at bugzilla.samba.org, 3.5 is in RC state
and can only get stuff with a proper bug report.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL:
<http://lists.samba.org/pipermail/samba/attachments/20100118/dc52ec15/attachment.pgp>