samba - Mar 2002 - Possible bug in 2.2.3a source/script/installbin.sh (with patch)

Hi all,

the file    samba-2.2.3a/source/script/installbin.sh    has a rather odd
blindspot.


It doesn't honor the  --with-privatedir=  option to ./configure  it just
blindly uses $BASEDIR/private instead.


I think the fix would be:-

	a) move directory creation out of installbin.sh altogehter
	(after all what's the installdirs: target for in the Makefile?)
OR
	b) add an extra parameter to installbin.sh thusly:-

*** source/script/installbin.sh Fri Jan 12 19:28:02 2001
--- source/script/installbin.sh.N       Wed Mar  6 17:28:25 2002
***************
*** 5,10 ****
--- 5,11 ----
  BINDIR=$3
  LIBDIR=$4
  VARDIR=$5
+ PRIVATEDIR=$6
  shift
  shift
  shift
***************
*** 11,17 ****
  shift
  shift

! for d in $BASEDIR $BINDIR $LIBDIR $VARDIR $BASEDIR/private; do
  if [ ! -d $d ]; then
  mkdir $d
  if [ ! -d $d ]; then
--- 12,18 ----
  shift
  shift

! for d in $BASEDIR $BINDIR $LIBDIR $VARDIR $PRIVATEDIR; do
  if [ ! -d $d ]; then
  mkdir $d
  if [ ! -d $d ]; then


	and also modify the Makefile.in to refer to it, thusly:-

*** source/Makefile.in  Sun Feb  3 00:46:05 2002
--- source/Makefile.in.N        Wed Mar  6 17:30:36 2002
***************
*** 661,668 ****
        @$(SHELL) $(srcdir)/script/installbin.sh $(INSTALLPERMS) $(BASEDIR)
$(SBINDIR) $(LIBDIR) $(VARDIR) $(SPROGS)

  installbin: all installdirs
!       @$(SHELL) $(srcdir)/script/installbin.sh $(INSTALLPERMS) $(BASEDIR)
$(SBINDIR) $(LIBDIR) $(VARDIR) $(SPROGS) $(WINBIND_SPROGS)
!       @$(SHELL) $(srcdir)/script/installbin.sh $(INSTALLPERMS) $(BASEDIR)
$(BINDIR) $(LIBDIR) $(VARDIR) $(PROGS) $(WINBIND_PROGS)

  installscripts: installdirs
        @$(SHELL) $(srcdir)/script/installscripts.sh $(INSTALLPERMS) $(BINDIR)
$(SCRIPTS)
--- 661,668 ----
        @$(SHELL) $(srcdir)/script/installbin.sh $(INSTALLPERMS) $(BASEDIR)
$(SBINDIR) $(LIBDIR) $(VARDIR) $(SPROGS)

  installbin: all installdirs
!       @$(SHELL) $(srcdir)/script/installbin.sh $(INSTALLPERMS) $(BASEDIR)
$(SBINDIR) $(LIBDIR) $(VARDIR) $(PRIVATEDIR) $(SPROGS) $(WINBIND_SPROGS)
!       @$(SHELL) $(srcdir)/script/installbin.sh $(INSTALLPERMS) $(BASEDIR)
$(BINDIR) $(LIBDIR) $(VARDIR) $(PRIVATEDIR) $(PROGS) $(WINBIND_PROGS)

  installscripts: installdirs
        @$(SHELL) $(srcdir)/script/installscripts.sh $(INSTALLPERMS) $(BINDIR)
$(SCRIPTS)


Personally I much prefer option a) it seems to make much more sense to
me, and if anyone really wants me to I'll try and figure out the 'diff
-c'for it, but I think the main Samba Team will have a better idea of
what the implications are of moving directory creation out of installbin:
and into one of its dependants (installdirs:)

Or have I missed a huge point somewhere?


                               Mac
          Assistant Systems Adminstrator @nibsc.ac.uk
                        dmccann@nibsc.ac.uk
   Work: +44 1707 654753 x285      Everything else: +44 7956 237670 (anytime)

Mac wrote:
> 
> Hi all,
> 
> the file    samba-2.2.3a/source/script/installbin.sh    has a rather odd
> blindspot.
> 
> It doesn't honor the  --with-privatedir=  option to ./configure  it
just
> blindly uses $BASEDIR/private instead.
> 
> I think the fix would be:-
> 
>         a) move directory creation out of installbin.sh altogehter
>         (after all what's the installdirs: target for in the Makefile?)
> OR
>         b) add an extra parameter to installbin.sh thusly:-
> 
Looks fine, but diff -u is the standard format.  

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet@pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet@samba.org
Student Network Administrator, Hawker College   abartlet@hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net