samba - Feb 2000 - pre2.0.7 KOI8-R bug

Hi all,

There is a small bug at the new Unicode support. I didn't follow the 
consequences of this bug, but this _is_ a bug ;-).
The bug stands on wrong charset name. Instead of KOI8-R (this is 
right) it's called KOI-R (this is wrong).
(I'm afraid the long lines wrap, but it shows the picture)

1. Makefile.in
--- Makefile.in Thu Feb 17 16:00:33 2000
+++ Makefile.in Thu Feb 17 16:01:27 2000
@@ -57,7 +57,7 @@
 CODEPAGEDIR = $(LIBDIR)/codepages
 
 # The current codepage definition list.
-CODEPAGELIST= 437 737 850 852 861 932 866 949 950 936 1251 ISO8859-1 
ISO8859-2 ISO8859-5 ISO8859-7 KOI-R
+CODEPAGELIST= 437 737 850 852 861 932 866 949 950 936 1251 ISO8859-1 
ISO8859-2 ISO8859-5 ISO8859-7 KOI8-R
 
 # where you are going to have the smbrun binary. This defaults to the
 # install directory. This binary is needed for correct printing       
                                    

2. File names in the codepages directory. Since the 
scripts/installcp.sh builds character mapping files on the basis of 
the file name, wrong file name hurts:

source/codepages/CPKOI-R.TXT
  (This is wrong)
source/codepages/CPKOI8-R.TXT
  (This is right)

Perhaps, it requires more carefull investigation, but I didn't find 
anything crucial so far.
--
Best, Sergei.

Sergei Makarov wrote:
> 
> Hi all,
> 
> There is a small bug at the new Unicode support. I didn't follow the
> consequences of this bug, but this _is_ a bug ;-).
> The bug stands on wrong charset name. Instead of KOI8-R (this is
> right) it's called KOI-R (this is wrong).
> (I'm afraid the long lines wrap, but it shows the picture)
Got it - will be fixed for 2.0.7pre2.

Thanks,

	Jeremy Allison,
	Samba Team.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------