samba-bugs at samba.org
2013-Oct-16 09:01 UTC
[Bug 10211] New: Log lines sent to files should not human-readable-ize numbers, ever
https://bugzilla.samba.org/show_bug.cgi?id=10211
Summary: Log lines sent to files should not human-readable-ize
numbers, ever
Product: rsync
Version: 3.1.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: core
AssignedTo: wayned at samba.org
ReportedBy: klausman at schwarzvogel.de
QAContact: rsync-qa at samba.org
Created attachment 9292
--> https://bugzilla.samba.org/attachment.cgi?id=9292
Make end-of-sync log line not use commas if logfile_name!=NULL
There is no reason to do comma separation for numbers if the log lines are sent
to a file. Actually, parsing those log files becomes quite a bit messier if
they are.
Relatedly, the separator for the numbers seems to ignore locale, in Germany,
for example, a million plus 1/10 is written like this: 1.000.000,1 -- not that
I'd want either in my logfiles.
Attached is a patch. Not sure about the line width, but that is easily fixable.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
samba-bugs at samba.org
2013-Oct-27 17:02 UTC
[Bug 10211] Log lines sent to files should not human-readable-ize numbers, ever
https://bugzilla.samba.org/show_bug.cgi?id=10211
Wayne Davison <wayned at samba.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Wayne Davison <wayned at samba.org> 2013-10-27
17:02:01 UTC ---
Indeed, the log was supposed to remain unaffected, but that FLOG message had
the wrong number-producing code. I'm checked-in a fix.
--
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.